[Bug 1475564] Review Request: python-pytest-fixture-config - Simple configuration objects for Py.test fixtures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475564

Randy Barlow  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2020-02-14 16:25:46



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1475564] Review Request: python-pytest-fixture-config - Simple configuration objects for Py.test fixtures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475564



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pytest-fixture-config

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475564] Review Request: python-pytest-fixture-config - Simple configuration objects for Py.test fixtures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475564



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pytest-fixture-config

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475564] Review Request: python-pytest-fixture-config - Simple configuration objects for Py.test fixtures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475564



--- Comment #4 from Randy Barlow  ---
Created attachment 1305655
  --> https://bugzilla.redhat.com/attachment.cgi?id=1305655=edit
review-2.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475564] Review Request: python-pytest-fixture-config - Simple configuration objects for Py.test fixtures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475564

Randy Barlow  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Randy Barlow  ---
Looks good!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475564] Review Request: python-pytest-fixture-config - Simple configuration objects for Py.test fixtures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475564

Kevin Fenzi  changed:

   What|Removed |Added

  Flags|needinfo?(ke...@scrye.com)  |



--- Comment #3 from Kevin Fenzi  ---
ok, -2 at the same place with the requires added:

Spec URL:
https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/python-pytest-fixture-config.spec
SRPM URL:
https://www.scrye.com/~kevin/fedora/review/python-pytest-fixture-config/python-pytest-fixture-config-1.2.11-2.fc27.src.rpm

I thought about using the github project, but I think that would just
complicate things more since all those other things are there in the same repo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475564] Review Request: python-pytest-fixture-config - Simple configuration objects for Py.test fixtures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475564

Randy Barlow  changed:

   What|Removed |Added

 CC||ke...@scrye.com
  Flags||needinfo?(ke...@scrye.com)



--- Comment #2 from Randy Barlow  ---
There is only one thing that must be fixed for approval: the package does need
py.test so it should Require it.

Other than that, I had a few optional suggestions:

* If you use github for Source0, you can include the LICENSE file. It
introduces
  some other questions though, since the git repo contains other packages too.
See
  the attached review.txt for details.
* I recommend filing a bug against python3 to get it to own the __pycache__
folder.

Anyways, I'm prepared to approve if you add the requirements on py.test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475564] Review Request: python-pytest-fixture-config - Simple configuration objects for Py.test fixtures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475564



--- Comment #1 from Randy Barlow  ---
Created attachment 1305478
  --> https://bugzilla.redhat.com/attachment.cgi?id=1305478=edit
review.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475564] Review Request: python-pytest-fixture-config - Simple configuration objects for Py.test fixtures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475564

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ra...@electronsweatshop.com
   Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org