[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-10-17 15:20:02 |2017-11-01 14:32:31



--- Comment #25 from Fedora Update System  ---
meta-test-family-0.7.4-3.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



--- Comment #24 from Fedora Update System  ---
meta-test-family-0.7.4-3.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7421f7d69d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-10-09 16:00:15 |2017-10-17 15:20:02



--- Comment #23 from Fedora Update System  ---
meta-test-family-0.7.4-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #22 from Fedora Update System  ---
meta-test-family-0.7.4-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7421f7d69d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



--- Comment #21 from Fedora Update System  ---
meta-test-family-0.7.4-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-db25621596

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-10-05 10:40:25 |2017-10-09 16:00:15



--- Comment #20 from Fedora Update System  ---
meta-test-family-0.7.4-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #19 from Fedora Update System  ---
meta-test-family-0.7.4-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-db25621596

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #18 from Fedora Update System  ---
meta-test-family-0.7.4-2.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-64694d69b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---
   Keywords||Reopened



--- Comment #17 from Fedora Update System  ---
meta-test-family-0.7.4-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d080215888

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Petr Hracek  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-10-05 10:40:25



--- Comment #16 from Petr Hracek  ---
Koji builds:
rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=22266414
f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=22267424
f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=22267919

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #15 from Fedora Update System  ---
meta-test-family-0.7.4-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d080215888

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #14 from Fedora Update System  ---
meta-test-family-0.7.4-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-64694d69b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #13 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/meta-test-family

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Tomas Tomecek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #12 from Tomas Tomecek  ---
I have opened two upstream issues for the rpmlint warnings and errors:

https://github.com/fedora-modularity/meta-test-family/issues/124
https://github.com/fedora-modularity/meta-test-family/issues/123

Those are not blocking this review, but please fix the one with executables
before building it in Fedora. Having manpages in a future release would be good
too.

Also please add at least README to the package, since there is literally no
documentation provided right now.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Check did not completechecksum differs and there are problems
  running diff. Please verify manually.
  See: http://fedoraproject.org/wiki/Packaging/SourceURL
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.rst is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later)", "GPL (v2 or later)", "Unknown or
 generated", "*No copyright* GPL". 71 files have unknown license.
 Detailed output of licensecheck in /home/tt/t/mtf-review/1477154-meta-
 test-family/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Tomas Tomecek  changed:

   What|Removed |Added

  Flags|fedora-review-  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #11 from Tomas Tomecek  ---
Checking.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #10 from Petr Hracek  ---
I did several fixes and here are updates based on the latest version:

Spec URL: https://phracek.fedorapeople.org/meta-test-family.spec
SRPM URL:
https://phracek.fedorapeople.org/meta-test-family-0.7.4-2.fc26.src.rpm

rpmlint output:
$ rpmlint -v meta-test-family-0.7.4-2.fc26.src.rpm 
meta-test-family.src: I: checking
meta-test-family.src: I: checking-url
https://github.com/fedora-modularity/meta-test-family (timeout 10 seconds)
meta-test-family.src: I: checking-url
https://github.com/fedora-modularity/meta-test-family/archive/0.7.4.tar.gz
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$


My fedora-review test:
Rpmlint
---
Checking: meta-test-family-0.7.4-2.fc25.noarch.rpm
  meta-test-family-0.7.4-2.fc25.src.rpm
meta-test-family.noarch: W: no-documentation
meta-test-family.noarch: W: no-manual-page-for-binary mtf
meta-test-family.noarch: W: no-manual-page-for-binary mtf-cmd
meta-test-family.noarch: W: no-manual-page-for-binary mtf-env-clean
meta-test-family.noarch: W: no-manual-page-for-binary mtf-env-set
meta-test-family.noarch: W: no-manual-page-for-binary mtf-generator
meta-test-family.noarch: W: no-manual-page-for-binary mtf-log-parser
2 packages and 0 specfiles checked; 0 errors, 7 warnings.




Rpmlint (installed packages)

meta-test-family.noarch: W: invalid-url URL:
https://github.com/fedora-modularity/meta-test-family 
meta-test-family.noarch: W: no-documentation
meta-test-family.noarch: W: no-manual-page-for-binary mtf-cmd
meta-test-family.noarch: W: no-manual-page-for-binary mtf-env-set
meta-test-family.noarch: W: no-manual-page-for-binary mtf-log-parser
meta-test-family.noarch: W: no-manual-page-for-binary mtf-env-clean
meta-test-family.noarch: W: no-manual-page-for-binary mtf-generator
meta-test-family.noarch: W: no-manual-page-for-binary mtf
1 packages and 0 specfiles checked; 0 errors, 8 warnings.



Requires

meta-test-family (rpmlib, GLIBC filtered):
/bin/bash
/usr/bin/python
/usr/bin/python2
docker
python(abi)
python-netifaces
python2-avocado
python2-avocado-plugins-output-html
python2-dockerfile-parse
python2-modulemd
python2-pdc-client

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #9 from Tomas Tomecek  ---
I'll do another review round once the release is done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #8 from Petr Hracek  ---
New updates based on PR.

Spec URL: https://phracek.fedorapeople.org/meta-test-family.spec
SRPM URL:
https://phracek.fedorapeople.org/meta-test-family-0.5.20-1.fc25.src.rpm

Installation errors
---
INFO: mock.py version 1.4.2 starting (python version = 3.5.3)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.2
INFO: Mock Version: 1.4.2
Finish: chroot init
INFO: installing package(s):
/home/phracek/work/programming/meta-test-family/review-meta-test-family/results/meta-test-family-0.5.20-1.fc25.noarch.rpm
/home/phracek/work/programming/meta-test-family/review-meta-test-family/results/python2-meta-test-family-0.5.20-1.fc25.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-25-x86_64/root/ --releasever
25 --disableplugin=local --setopt=deltarpm=False install
/home/phracek/work/programming/meta-test-family/review-meta-test-family/results/meta-test-family-0.5.20-1.fc25.noarch.rpm
/home/phracek/work/programming/meta-test-family/review-meta-test-family/results/python2-meta-test-family-0.5.20-1.fc25.noarch.rpm



Rpmlint
---
Checking: meta-test-family-0.5.20-1.fc25.noarch.rpm
  python2-meta-test-family-0.5.20-1.fc25.noarch.rpm
  meta-test-family-0.5.20-1.fc25.src.rpm
meta-test-family.noarch: W: no-documentation
meta-test-family.noarch: W: devel-file-in-non-devel-package
/usr/share/moduleframework/examples/base-runtime/resources/hello-world/hello.c
meta-test-family.noarch: E: script-without-shebang
/usr/share/moduleframework/examples/multios_testing/moduleframework/module_framework.py
meta-test-family.noarch: E: non-executable-script
/usr/share/moduleframework/examples/memcached/sanity2.sh 644 /bin/bash 
meta-test-family.noarch: W: no-manual-page-for-binary mtf-generator
meta-test-family.noarch: W: no-manual-page-for-binary moduleframework-cmd
meta-test-family.noarch: W: no-manual-page-for-binary modulelint
python2-meta-test-family.noarch: W: no-documentation
python2-meta-test-family.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/moduleframework/timeoutlib.py 644
/usr/bin/python 
python2-meta-test-family.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/moduleframework/bashhelper.py 644
/usr/bin/python 
python2-meta-test-family.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/moduleframework/mtf_generator.py 644
/usr/bin/python 
meta-test-family.src: W: invalid-url Source0:
https://codeload.github.com/fedora-modularity/meta-test-family/tar.gz/meta-test-family-0.5.20.tar.gz
HTTP Error 404: Not Found

3 packages and 0 specfiles checked; 5 errors, 7 warnings.


As soon as PR will be merged, I will create release.

mtf_generator.py is false possitive. It contains /usr/bin/python.
bashhelper.py will be probably deleted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #7 from Petr Hracek  ---
rpmlint Errors should be fixed by PR
https://github.com/fedora-modularity/meta-test-family/pull/42

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Tomas Tomecek  changed:

   What|Removed |Added

  Flags||fedora-review-



--- Comment #6 from Tomas Tomecek  ---
Please fix the source tarball url and all rpmlint warnings and errors. review-
in the meantime


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.rst is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later)", "GPL (v2 or later)", "Unknown or
 generated", "*No copyright* GPL". 119 files have unknown license.
 Detailed output of licensecheck in /home/tt/t/mtf-review/1477154-meta-
 test-family/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/moduleframework/examples/base-runtime(modularity-testing-
 framework), /usr/share/moduleframework/examples/base-
 runtime/resources/os_release(modularity-testing-framework),
 /usr/share/moduleframework/examples/multios_testing(modularity-
 testing-framework), /usr/share/moduleframework/examples/testing-module
 (modularity-testing-framework),
 /usr/share/moduleframework/examples/memcached(modularity-testing-
 framework), /usr/share/moduleframework/examples/haproxy(modularity-
 testing-framework), /usr/share/moduleframework/examples(modularity-
 testing-framework), /usr/share/moduleframework/examples/nginx
 (modularity-testing-framework), /usr/share/moduleframework/tools
 (modularity-testing-framework), /usr/share/moduleframework/examples
 /testing-module/modulelint(modularity-testing-framework),
 /usr/share/moduleframework/examples/base-runtime/resources/hello-world
 (modularity-testing-framework), /usr/share/moduleframework/examples
 /testing-module/moduleframework(modularity-testing-framework),
 /usr/share/moduleframework/examples/base-
 runtime/resources/installed_packages(modularity-testing-framework),
 /usr/lib/python2.7/site-packages/moduleframework(modularity-testing-
 framework), /usr/share/moduleframework/examples/nginx/html_pages
 (modularity-testing-framework), /usr/share/moduleframework/examples
 /base-runtime/resources(modularity-testing-framework),
 /usr/share/moduleframework/examples/template(modularity-testing-
 framework), /usr/share/moduleframework/docs/api(modularity-testing-
 framework),
 /usr/share/moduleframework/examples/multios_testing/moduleframework
 (modularity-testing-framework),
 /usr/share/moduleframework/docs/user_guide(modularity-testing-
 framework), /usr/share/moduleframework/examples/memcached-behave
 (modularity-testing-framework), /usr/share/moduleframework(modularity-
 testing-framework), /usr/share/moduleframework/tools/modulelint
 (modularity-testing-framework), /usr/share/moduleframework/docs
 (modularity-testing-framework), /usr/share/moduleframework/examples
 /memcached-behave/steps(modularity-testing-framework)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on 

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Tomas Tomecek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ttome...@redhat.com



--- Comment #5 from Tomas Tomecek  ---
> Avocado is not yet available as python3 package. We are waiting till it is 
> not supported in Python3. Tha't the reason.

That was not my point. My point was if you wanna have a package
meta-test-family which will include only executables and will require
python2-meta-test-family which will contain all python sources.

Review in-progress.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #4 from Petr Hracek  ---
(In reply to Tomas Tomecek from comment #2)
> > %description
> > %{summary}.
> 
> Can we get a real, verbose description?

Done.

+Tool to test components of a modular Fedora. Using MTF
+you can write tests for RPMs, modules and Docker containers
> 
> > ExcludeArch:ppc64
> 
https://bugzilla.redhat.com/show_bug.cgi?id=1465176

This should fix the problem.
%ifarch x86_64 i686
Requires:   docker
%endif

> What's the point when the package is noarch?
> 
> > chmod a+x 
> > %{buildroot}%{python_sitelib}/%{framework_name}/{module_framework,mtf_generator,bashhelper,setup}.py
> 
> Executables do not belong to sitelib.
> 
Fixed.
> 
> I am also thinking about whether it makes sense to have a 'python2-'
> subpackage which would contain all python source code and meta-test-family
> would just provide executables. Something like this:
> http://pkgs.fedoraproject.org/cgit/rpms/sen.git/tree/sen.spec
Avocado is not yet available as python3 package. We are waiting till it is not
supported in Python3. Tha't the reason.


Spec URL: https://phracek.fedorapeople.org/meta-test-family.spec
SRPM URL:
https://phracek.fedorapeople.org/meta-test-family-0.5.19-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #3 from Petr Hracek  ---
Previous review request is here.
https://bugzilla.redhat.com/show_bug.cgi?id=1437851

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Tomas Tomecek  changed:

   What|Removed |Added

 CC||ttome...@redhat.com



--- Comment #2 from Tomas Tomecek  ---
> %description
> %{summary}.

Can we get a real, verbose description?

> ExcludeArch:ppc64

What's the point when the package is noarch?

> chmod a+x 
> %{buildroot}%{python_sitelib}/%{framework_name}/{module_framework,mtf_generator,bashhelper,setup}.py

Executables do not belong to sitelib.


I am also thinking about whether it makes sense to have a 'python2-' subpackage
which would contain all python source code and meta-test-family would just
provide executables. Something like this:
http://pkgs.fedoraproject.org/cgit/rpms/sen.git/tree/sen.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154

Irina Gulina  changed:

   What|Removed |Added

 CC||igul...@redhat.com
Summary|Re-Review Request:  |Re-Review Request:
   |meta-test-family -  |meta-test-family - a tool
   |Framework for writing tests |to test components of a
   |for modules and containers  |modular Fedora



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org