[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 Zamir SUN changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2018-07-22 09:29:08 --- Comment #7 from Zamir SUN --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IRD2ZWO37F2DD4HRNK7CNA5B7ZO23PCJ/
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 Zamir SUNchanged: What|Removed |Added CC||szts...@gmail.com Alias||golang-github-msteinert-pam -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- golang-github-msteinert-pam-0-0.1.git2c288b3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-35f9c8f496 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 Fedora Update Systemchanged: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 --- Comment #5 from Fedora Update System--- golang-github-msteinert-pam-0-0.1.git2c288b3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-35f9c8f496 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 --- Comment #4 from Gwyn Ciesla--- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-msteinert-pam -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 Robert-André Mauchinchanged: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- All good, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 --- Comment #2 from sensor@gmail.com --- https://github.com/FZUG/repo/commit/860cbdf9fdc46c3df38e5348143376e009f4c02b Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 Robert-André Mauchin (afk until next Thu)changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? --- Comment #1 from Robert-André Mauchin (afk until next Thu) --- Hello, Changelog version is in the wrong format. It must 0-0.1.git2c288b3. warning: File listed twice: /usr/share/gocode/src/github.com/msteinert/pam → You probably need to remove the %dir directive here too. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/gocode/src/github.com/msteinert/pam See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (2 clause)", "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review /golang-github-msteinert-pam/review-golang-github-msteinert- pam/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gocode/src/github.com/msteinert [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode/src/github.com/msteinert, /usr/share/gocode, /usr/share/gocode/src/github.com [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 sensor@gmail.com changed: What|Removed |Added Blocks||1465889 ||(DeepinDEPackageReview) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org