[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350



--- Comment #13 from Fedora Update System  ---
python-treq-17.8.0-2.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350



--- Comment #12 from Fedora Update System  ---
python-treq-17.8.0-2.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-14 17:53:39



--- Comment #11 from Fedora Update System  ---
python-treq-17.8.0-2.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350



--- Comment #10 from Fedora Update System  ---
python-treq-17.8.0-2.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-45c989fc7b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350



--- Comment #9 from Fedora Update System  ---
python-treq-17.8.0-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-16b7dc8bfc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
python-treq-17.8.0-2.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d7322f7ae7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350



--- Comment #7 from Fedora Update System  ---
python-treq-17.8.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-45c989fc7b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350



--- Comment #6 from Fedora Update System  ---
python-treq-17.8.0-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-16b7dc8bfc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350



--- Comment #5 from Fedora Update System  ---
python-treq-17.8.0-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d7322f7ae7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-treq

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
>is there a way to test with python-incremental koji build

Not until python-incremental is integrated into Rawhide.

It's a noarch package though, there's no reason it will be any different than a
normal mockbuild.


Nevertheless, everything is good, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350



--- Comment #2 from Yatin Karel  ---
Incorporated comments except using pydist names(Actually i want to take this in
fedora 25 and pydist names not working there, please suggest)

Spec URL:
https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-treq.spec
SRPM URL:
https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-treq-17.8.0-1.fc25.src.rpm



Koji build is failing looks like because of absense of incremental in repo, is
there a way to test with python-incremental koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21434756

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,


 - MIT/X is not a valid Fedora license. Please consult the list of available
licenses here:
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
Here just MIT is sufficient:

License:MIT

 - Please use %python2dist/%python3dist macros when you can. See:
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names

%if 0%{?with_doc}
BuildRequires:  python2dist(sphinx)
BuildRequires:  python2dist(incremental)
%endif
BuildRequires:  python2dist(setuptools)

BuildRequires:  python3-devel
BuildRequires:  python3dist(setuptools)

 And:

Requires:   python2dist(requests) >= 2.1.0
Requires:   python2dist(six)
Requires:   python2dist(twisted) >= 16.3.0
Requires:   python2dist(attrs)

 And:

Requires:   python3dist(requests) >= 2.1.0
Requires:   python3dist(six)
Requires:   python3dist(twisted) >= 16.3.0
Requires:   python3dist(attrs)

 - Your description lines are too long, they should be below 80 characters per
line.

 -  In generate html doc, change export PYTHONPATH to:

export PYTHONPATH=%{python2_sitelib}:%{python3_sitelib}:src

Otherwise sphinx-build fails to find the imported modules.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 58 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-treq/review-python-
 treq/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not 

[Bug 1484350] Review Request: python-treq - A requests-like API built on top of twisted.web's Agent

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1484350

Yatin Karel  changed:

   What|Removed |Added

 Blocks||1427510 (RDO-PIKE)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1427510
[Bug 1427510] Tracker: Blockers and Review requests for new RDO Pike
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org