[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 Thomas Moschny changed: What|Removed |Added Summary|Review Request: Botan - A |Review Request: botan2 - A |C++11 crypto and TLS|C++11 crypto and TLS |library, version 2 |library, version 2 --- Comment #24 from Thomas Moschny --- Love this tool. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #25 from Thomas Moschny --- Can't create the repo: The Bugzilla review bug creator didn't match the requester in Pagure. https://pagure.io/releng/fedora-scm-requests/issue/4270 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #26 from Robert-André Mauchin --- Benjamin Kircher needs to do it then. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #27 from Benjamin Kircher --- If I can be of any help here, ping me (bkircher) on #fedora-devel or shoot me a mail. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 Rex Dieter changed: What|Removed |Added CC||rdie...@gmail.com Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #28 from Rex Dieter --- bkircher is not yet sponsored either, I can help out in that regard. Now, you (bkircher) can try: fedrepo-req botan2 -t 1487067 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #29 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/botan2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 Benjamin Kircher changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-03-06 11:44:44 --- Comment #30 from Benjamin Kircher --- Imported into https://src.fedoraproject.org/rpms/botan2 for rawhide/f29 Build https://koji.fedoraproject.org/koji/buildinfo?buildID=1054353 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #31 from Rex Dieter --- FYI, looks like botan2 hard-codes a bunch of it's own compiler/link flags, see: src/build-data/cc/gcc.txt (and throws away the distro default ones apparently) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #32 from Thomas Moschny --- Benjamin, as said earlier, I can co-maintain the package, if you want. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #33 from Jack Lloyd --- Re compile flags, configure.py script consumes flags from CXXFLAGS if set in the environment, which will override the defaults. Is there something else we should be doing here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067
--- Comment #34 from Thomas Moschny ---
(In reply to Jack Lloyd from comment #33)
> Re compile flags, configure.py script consumes flags from CXXFLAGS if set in
> the environment, which will override the defaults. Is there something else
> we should be doing here?
No, that's fine.
In many cases, spec files use %configure, which sets (amongst others) CXXFLAGS,
but as %configure is not used here, we should use
export CXXFLAGS=%{optflags}
instead.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #35 from Benjamin Kircher --- (In reply to Thomas Moschny from comment #32) > Benjamin, as said earlier, I can co-maintain the package, if you want. Of course. Any advice and help is greatly appreciated. I added you (thm) as admin to the repo on src.fedoraproject.org. If there is anything else I need to do, please let me know. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #36 from Thomas Moschny --- (In reply to Rex Dieter from comment #31) > FYI, looks like botan2 hard-codes a bunch of it's own compiler/link flags, > see: > src/build-data/cc/gcc.txt > (and throws away the distro default ones apparently) Fixed: https://src.fedoraproject.org/rpms/botan2/c/9c37fc9601eb1f5714a93d54c29502b94f15c92f?branch=master -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #37 from Rex Dieter --- Mind building botan2 for at least f27 too? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #38 from Benjamin Kircher --- > Mind building botan2 for at least f27 too? Not from my side. Thomas, is this okay with you? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #40 from Benjamin Kircher --- https://pagure.io/releng/fedora-scm-requests/issue/5529 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #39 from Thomas Moschny --- (In reply to Benjamin Kircher from comment #38) > > Mind building botan2 for at least f27 too? > > Not from my side. Thomas, is this okay with you? Sure, no objections. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 --- Comment #41 from Fedora Update System --- botan2-2.4.0-10.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-34628c68a4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #42 from Fedora Update System --- botan2-2.4.0-10.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-34628c68a4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2018-03-06 11:44:44 |2018-04-10 15:10:21 --- Comment #43 from Fedora Update System --- botan2-2.4.0-10.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
