[Bug 1488101] Review Request: eclipse-recommenders - Eclipse Code Recommenders
https://bugzilla.redhat.com/show_bug.cgi?id=1488101 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-09-16 23:51:09 --- Comment #7 from Fedora Update System --- eclipse-recommenders-2.4.9-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488101] Review Request: eclipse-recommenders - Eclipse Code Recommenders
https://bugzilla.redhat.com/show_bug.cgi?id=1488101 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- eclipse-recommenders-2.4.9-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-815a92de15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488101] Review Request: eclipse-recommenders - Eclipse Code Recommenders
https://bugzilla.redhat.com/show_bug.cgi?id=1488101 --- Comment #5 from Fedora Update System --- eclipse-recommenders-2.4.9-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-815a92de15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488101] Review Request: eclipse-recommenders - Eclipse Code Recommenders
https://bugzilla.redhat.com/show_bug.cgi?id=1488101 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488101] Review Request: eclipse-recommenders - Eclipse Code Recommenders
https://bugzilla.redhat.com/show_bug.cgi?id=1488101 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/eclipse-recommenders -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488101] Review Request: eclipse-recommenders - Eclipse Code Recommenders
https://bugzilla.redhat.com/show_bug.cgi?id=1488101 --- Comment #3 from Mat Booth --- New branches requested: https://pagure.io/releng/fedora-scm-requests/issue/1022 https://pagure.io/releng/fedora-scm-requests/issue/1023 https://pagure.io/releng/fedora-scm-requests/issue/1024 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488101] Review Request: eclipse-recommenders - Eclipse Code Recommenders
https://bugzilla.redhat.com/show_bug.cgi?id=1488101
Alexander Kurtakov changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #2 from Alexander Kurtakov ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* EPL (v1.0)", "*No copyright* EPL", "Unknown or
generated", "EPL (v1.0)".
Tests and build scripts are not properly licensed but that's ok.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
= SHOULD items =
Generic:
[x]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
http://git.eclipse.org/c/recommenders/org.eclipse.recommenders.git/snapshot/org.eclipse.recommenders-2.4.9.tar.xz
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
Eclipse download service not stable so it gives 500 quite often lately.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot
[Bug 1488101] Review Request: eclipse-recommenders - Eclipse Code Recommenders
https://bugzilla.redhat.com/show_bug.cgi?id=1488101 Alexander Kurtakov changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488101] Review Request: eclipse-recommenders - Eclipse Code Recommenders
https://bugzilla.redhat.com/show_bug.cgi?id=1488101 Alexander Kurtakov changed: What|Removed |Added CC||akurt...@redhat.com Assignee|nob...@fedoraproject.org|akurt...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488101] Review Request: eclipse-recommenders - Eclipse Code Recommenders
https://bugzilla.redhat.com/show_bug.cgi?id=1488101 --- Comment #1 from Mat Booth --- I noticed it didn't build correctly on F26 -- new revision fixes that: Spec URL: https://fedorapeople.org/~mbooth/reviews/eclipse-recommenders.spec SRPM URL: https://fedorapeople.org/~mbooth/reviews/eclipse-recommenders-2.4.9-2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
