[Bug 1489668] Review Request: Slurm Workload Manager - HPC cluster management and job scheduling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1489668

Robert-André Mauchin (afk until Mon 11)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Robert-André Mauchin (afk until Mon 11)  
---
 - You need to post a link to the SRPM, not instruction on how to build it,
otherwise we can't run fedora-review directly on the bug.

 - Similarly, you need to post a direct link to the spec.

 - You need to close the other bug as duplicate of this one if it's a stalled
review.

 - The title of the bug should be: "Review Request: slurm - HPC cluster
management and job scheduling" Otherwise you'll have an error message when
trying to create the repo with fedrepo-req. So please edit the bug title.

 - You need to remove %defattr(-,root,root,-) in the %files sections, it's not
used anymore.

 - This needs to be removed too:

>%clean
>rm -rf %{buildroot}

 - This is not needed:

>Requires(post): /sbin/ldconfig
>Requires(postun): /sbin/ldconfig

 - Don't use:

>Requires(post):   systemd
>Requires(preun):  systemd
>Requires(postun): systemd

But use the special macro:

%{?systemd_requires}
BuildRequires: systemd

See
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd

 - Replace make %{?_smp_mflags} with the macro %make_build

 - Replace make install DESTDIR=%{buildroot} with the macro %make_install

 - Use pkgconfig when you can for the -devel BR:

BuildRequires:  pkgconfig(gtk+-2.0)
BuildRequires:  hdf5-devel
BuildRequires:  pkgconfig(hwloc)
BuildRequires:  pkgconfig(libfreeipmi)
BuildRequires:  pkgconfig(libcurl)
BuildRequires:  pkgconfig(lua)
BuildRequires:  pkgconfig(mariadb)
BuildRequires:  pkgconfig(munge)
BuildRequires:  pkgconfig(ncurses)
BuildRequires:  pkgconfig(openssl)
BuildRequires:  pam-devel
BuildRequires:  pmix-devel
BuildRequires:  readline-devel
BuildRequires:  pkgconfig(librrd)
BuildRequires:  pkgconfig(zlib)

 - Not everything is under GPLv2, some parts are BSD:

BSD (2 clause)
--
slurm-17.02.7/src/common/log.c
slurm-17.02.7/src/common/log.h

BSD (unspecified)
-
slurm-17.02.7/src/common/uthash/LICENSE
slurm-17.02.7/src/common/uthash/uthash.h

  It should be reflected in the License: field

 - If there are GUI app (in slurm-gui) they must have a Desktop file.

 - You need to add:

Requires:   perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))

  for your Perl dependent subpackages.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "GPL (v2 or later)", "Unknown or generated", "MIT/X11
 (BSD like)", "BSD (unspecified)", "zlib/libpng", "GPL (v2 or later)
 (with incorrect FSF address)", "*No copyright* GPL (with incorrect FSF
 address)", "ISC", "BSD (2 clause)", "LGPL (v2.1 or later)", "*No
 copyright* GPL (v2 or later)", "GPL (v2)", "PostgreSQL GPL (v2 or
 later)". 1084 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/slurm/review-
 slurm/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/.build-id/c5,
 /usr/lib64/perl5, /usr/lib64/perl5/vendor_perl/auto, /usr/lib/.build-
 id/a8, /usr/lib/.build-id/ec, /usr/lib/.build-id/2c, /usr/lib/.build-
 id/90, /usr/lib/.build-id/a9, /usr/lib/.build-id/7b, /etc/slurm,
 /usr/lib/.build-id/d0, /usr/lib/.build-id/ab, /etc/logrotate.d,
 /usr/lib64/security, /usr/lib64/slurm, /usr/lib/.build-id/4f, /usr/lib
 /.build-id/ad, /usr/lib64/perl5/vendor_perl, /usr/lib/.build-id/c6,
 /usr/lib/.build-id/d5, 

[Bug 1489668] Review Request: Slurm Workload Manager - HPC cluster management and job scheduling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1489668

Philip Kovacs  changed:

   What|Removed |Added

URL||https://copr.fedorainfraclo
   ||ud.org/coprs/pkfed/slurm/



--- Comment #2 from Philip Kovacs  ---
I added this project to Copr and will maintain builds there for the time being.

https://copr.fedorainfracloud.org/coprs/pkfed/slurm/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1489668] Review Request: Slurm Workload Manager - HPC cluster management and job scheduling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1489668

Philip Kovacs  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1149566



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1489668] Review Request: Slurm Workload Manager - HPC cluster management and job scheduling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1489668

Philip Kovacs  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1489668] Review Request: Slurm Workload Manager - HPC cluster management and job scheduling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1489668



--- Comment #1 from Philip Kovacs  ---
To generate the SRPM:

I meant:

git clone https://github.com/pkovacs/fedora-slurm.git

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org