[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library
https://bugzilla.redhat.com/show_bug.cgi?id=1499569 --- Comment #9 from Fedora Update System --- python-twilio-6.8.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library
https://bugzilla.redhat.com/show_bug.cgi?id=1499569 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2017-11-07 17:15:19 --- Comment #8 from Fedora Update System --- python-twilio-6.8.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library
https://bugzilla.redhat.com/show_bug.cgi?id=1499569 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library
https://bugzilla.redhat.com/show_bug.cgi?id=1499569 --- Comment #7 from Fedora Update System --- python-twilio-6.8.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-36f9e309ec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library
https://bugzilla.redhat.com/show_bug.cgi?id=1499569 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- python-twilio-6.8.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-98f1a0a410 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library
https://bugzilla.redhat.com/show_bug.cgi?id=1499569 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library
https://bugzilla.redhat.com/show_bug.cgi?id=1499569 --- Comment #5 from Fedora Update System --- python-twilio-6.8.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-98f1a0a410 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library
https://bugzilla.redhat.com/show_bug.cgi?id=1499569 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-twilio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library
https://bugzilla.redhat.com/show_bug.cgi?id=1499569 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- All ok, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library
https://bugzilla.redhat.com/show_bug.cgi?id=1499569 --- Comment #2 from Michael Cullen --- > python2_sitelib is already defined in Fedora. Ah ok - I got that from the template created by newspec Spec URL: https://mich181189.fedorapeople.org/python-twilio/python-twilio.spec SRPM URL: https://mich181189.fedorapeople.org/python-twilio/python-twilio-6.8.0-1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1499569] Review Request: python-twilio - Python Twilio Helper Library
https://bugzilla.redhat.com/show_bug.cgi?id=1499569
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
Hello,
- Use a more meaningful name for your archive, with:
Source0:
https://github.com/twilio/twilio-python/archive/%{version}/%{name}-%{version}.tar.gz
- I don't think this is necessary:
# sitelib for noarch packages, sitearch for others (remove the unneeded one)
%{!?__python2: %global __python2 %__python}
%{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
python2_sitelib is already defined in Fedora.
- Use the appropriate python macros:
%{__python2} setup.py build ⇒ %py2_build
%{__python3} setup.py build ⇒ %py3_build
%{__python3} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT ⇒
%py3_install
%{__python2} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT ⇒
%py2_install
- add the examples directory to %doc:
%doc README.rst examples
- python2-twilio.noarch: E: description-line-too-long C The Twilio REST SDK
simplifies the process of making calls using the Twilio REST API.
Split your description to stay under 80 characters per line.
- python-twilio.src:26: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab:
line 26)
Use either spaces or tabs, not both.
- You could use the %{py2_dist/%{py3_dist macros to handle your Python
dependencies. See
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names
BuildRequires: python2-devel
BuildRequires: %{py2_dist nose}
BuildRequires: %{py2_dist pytz}
BuildRequires: %{py2_dist six}
BuildRequires: %{py2_dist mock}
BuildRequires: python2-jwt
BuildRequires: %{py2_dist requests}
%if %{with python3}
BuildRequires: python3-devel
BuildRequires: %{py3_dist nose}
BuildRequires: %{py3_dist pytz}
BuildRequires: %{py3_dist six}
BuildRequires: %{py3_dist mock}
BuildRequires: python3-jwt
BuildRequires: %{py3_dist requests}
%endif # with python3
%description
%{desc}
#python2 subpackage
%package -n python2-twilio
Summary:%{sum}
Requires: %{py2_dist six}
Requires: %{py2_dist requests}
Requires: python2-jwt
Requires: %{py2_dist pytz}
%{?python_provide:%python_provide python2-twilio}
%description -n python2-twilio
%{desc}
#python3 subpackage
%if %{with python3}
%package -n python3-twilio
Summary:%{sum}
Requires: %{py3_dist six}
Requires: %{py3_dist requests}
Requires: python3-jwt
Requires: %{py3_dist pytz}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
