[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-12 06:22:12



--- Comment #29 from Fedora Update System  ---
thonny-2.1.16-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #28 from Fedora Update System  ---
thonny-2.1.16-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-554c1f6747

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #27 from Fedora Update System  ---
thonny-2.1.16-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-554c1f6747

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #25 from Patrick Uiterwijk  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/thonny

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #26 from Patrick Uiterwijk  ---
(fedrepo-req-admin):  Welcome to the Fedora package maintainers!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #24 from Aivar Annamaa  ---
Thanks, Miro!

I'll continue the publishing process in couple of days.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Miro Hrončok  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags|fedora-review?  |fedora-review+



--- Comment #23 from Miro Hrončok  ---
I've sponsored Aivar Annamaa. Package APPROVED.

Aivar, thank you for contributing to Fedora. Let me know if you need any help.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #22 from Miro Hrončok  ---
(In reply to Aivar Annamaa from comment #21)
> (In reply to Miro Hrončok from comment #20)
> 
> > You might want to look at Xvfb. This seams relevant
> > https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/
> > thread/N7OW5LPNJUGFHATFTNHJZC7W4V772H4O/
> 
> Thanks! This did the trick:
> 
> %check
> xvfb-run py.test-3 --pyargs thonny

Awesome!

> > > When I install the package and run `py.test-3
> > > --pyargs thonny` manually in Terminal, then all tests pass.
> > 
> > When I do that, it collects 0 tests. What is the exact step by step guide?
> 
> 1) sudo dnf install RPMS/noarch/thonny-2.1.16-1.fc27.noarch.rpm
> 2) py.test-3 --pyargs thonny
> 
> Did you try it with package version 2.1.16? The older stdists didn't include
> the tests yet.

Oh, ok, with 2.1.16 it really collects and work.

I declare this package preliminarily approved. Good work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #21 from Aivar Annamaa  ---
(In reply to Miro Hrončok from comment #20)

> You might want to look at Xvfb. This seams relevant
> https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/
> thread/N7OW5LPNJUGFHATFTNHJZC7W4V772H4O/

Thanks! This did the trick:

%check
xvfb-run py.test-3 --pyargs thonny

Spec URL: https://bitbucket.org/plas/thonny-rpm/downloads/thonny.spec
SRPM URL:
https://bitbucket.org/plas/thonny-rpm/downloads/thonny-2.1.16-1.fc27.src.rpm

Changes:
https://bitbucket.org/plas/thonny-rpm/commits/a4c59df9bcd2a9f1defbe1a22cc5e52bddff7c8f


> > When I install the package and run `py.test-3
> > --pyargs thonny` manually in Terminal, then all tests pass.
> 
> When I do that, it collects 0 tests. What is the exact step by step guide?

1) sudo dnf install RPMS/noarch/thonny-2.1.16-1.fc27.noarch.rpm
2) py.test-3 --pyargs thonny

Did you try it with package version 2.1.16? The older stdists didn't include
the tests yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #20 from Miro Hrončok  ---
(In reply to Aivar Annamaa from comment #18)
> Miro, I think I have fixed all the items you brought up, except %check:

Great!

> About %check:
> 
> Several of my tests are creating a Tkinter window. When I tried running the
> tests with
> 
> %check 
> py.test-3 --pyargs thonny
> 
> then those tests failed because Tkinter couldn't access the display. I
> suppose this is because of the restricted build environment and there is
> nothing to do about it.

You might want to look at Xvfb. This seams relevant
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/thread/N7OW5LPNJUGFHATFTNHJZC7W4V772H4O/

> When I install the package and run `py.test-3
> --pyargs thonny` manually in Terminal, then all tests pass.

When I do that, it collects 0 tests. What is the exact step by step guide?

> I hope it's OK to omit the %check for now. I'll try to organize my tests
> better in future versions so that the package builder can run at least those
> tests which doesn't use Tkinter.

Sure thing. I'd sugest marking the test with some kind of marker
https://docs.pytest.org/en/latest/mark.html

> PS. Did I understand correctly that %check is run only at package building
> time, not when user installs the package?

Exactly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #19 from Miro Hrončok  ---
(In reply to Aivar Annamaa from comment #17)
> Thanks for the review! I'll fix the issues soon.
> 
> About doing my own review -- am I supposed to just show my ability to review
> or should I be really helpful?

I need the first, however the second is more important. Preferably you do both.

> I looked through the Python review requests which don't have a reviewer
> assigned yet. In all cases either somebody is already actively commenting
> the request or the submitter is really inactive (no responses for long time).
> 
> Is it of any use if I provide a second review for a request which already
> has a review or where someone has already promised to give a review?

That would satisfy my request but would only generate unnecessary noise and
would not be helpful to others, so probably don't do it.

> I found an interesting package without review (python-asttokens,
> https://bugzilla.redhat.com/show_bug.cgi?id=1510188), but looks like it's
> already (close to be?) included in the Fedora repo. Does it make sense if I
> write a review for it?

Actually the review there happened:
https://bugzilla.redhat.com/show_bug.cgi?id=1510188#c1 it was just
extraordinary sloppy (please don't do that kind of reviews once you are
sponsored.)

So we seem to have a problem that there is nothing to review :)

Here are the options I see:

 * skim trough other review requests, not just python related
 * ask on python-devel mailing list if someone is not working on a package
 * wait until something shows up

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #18 from Aivar Annamaa  ---
Miro, I think I have fixed all the items you brought up, except %check:

Spec URL: https://bitbucket.org/plas/thonny-rpm/downloads/thonny.spec
SRPM URL:
https://bitbucket.org/plas/thonny-rpm/downloads/thonny-2.1.16-1.fc27.src.rpm

Changes:
*
https://bitbucket.org/plas/thonny-rpm/commits/066a4208f320c561f4983864e8eedb5abdeca048
*
https://bitbucket.org/plas/thonny-rpm/commits/0e84d4abb4eb98a7464335978d43f5afe6ab11a1


About %check:

Several of my tests are creating a Tkinter window. When I tried running the
tests with

%check 
py.test-3 --pyargs thonny

then those tests failed because Tkinter couldn't access the display. I suppose
this is because of the restricted build environment and there is nothing to do
about it. When I install the package and run `py.test-3 --pyargs thonny`
manually in Terminal, then all tests pass.

I hope it's OK to omit the %check for now. I'll try to organize my tests better
in future versions so that the package builder can run at least those tests
which doesn't use Tkinter.

PS. Did I understand correctly that %check is run only at package building
time, not when user installs the package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #17 from Aivar Annamaa  ---
Thanks for the review! I'll fix the issues soon.

About doing my own review -- am I supposed to just show my ability to review or
should I be really helpful?

I looked through the Python review requests which don't have a reviewer
assigned yet. In all cases either somebody is already actively commenting the
request or the submitter is really inactive (no responses for long time).

Is it of any use if I provide a second review for a request which already has a
review or where someone has already promised to give a review?

I found an interesting package without review (python-asttokens,
https://bugzilla.redhat.com/show_bug.cgi?id=1510188), but looks like it's
already (close to be?) included in the Fedora repo. Does it make sense if I
write a review for it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #16 from Miro Hrončok  ---
Package Review
==

Not approved yet.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- gtk-update-icon-cache is not invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in thonny
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- update-desktop-database is not invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in thonny
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database
- the package should require hicolor-icon-theme, because it installs to
  directories owned by that package
- I see some tests in git. Can you execute them in the %check section please?

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/256x256/apps,
 /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English 

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #15 from Miro Hrončok  ---
About the icon(s), you should update the icon cache, see
https://fedoraproject.org/wiki/Packaging:Scriptlets#Icon_Cache

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #14 from Miro Hrončok  ---
In the meantime, could you please review some package(s) to show your ability
to do so? (It would help me to sponsor you.)

There is a list of Python related review requests at
https://fedoraproject.org/wiki/SIGs/Python#Review_Python_packages

Please indicate in the review that you are not yet sponsored.

See the review process explained here:
https://fedoraproject.org/wiki/Package_Review_Process

Ask me here, or via e-mail, or find me as mhroncok at #fedora-python or
#fedora-devel freenode IRC channels, if you have questions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Miro Hrončok  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #13 from Miro Hrončok  ---
(In reply to Aivar Annamaa from comment #12)
> Thanks!
> 
> I updated the spec:
> https://bitbucket.org/plas/thonny-rpm/commits/
> d27b7445bae27bd3a72cb340fffe6c27d0bcd941
> 
> New state:
> 
> * https://bitbucket.org/plas/thonny-rpm/downloads/thonny.spec
> *
> https://bitbucket.org/plas/thonny-rpm/downloads/thonny-2.1.15-1.fc26.src.rpm
> * https://copr.fedorainfracloud.org/coprs/aivarannamaa/thonny/monitor/

Please always post links in the described form, there are automated tools that
expect it that way:

Spec URL: https://bitbucket.org/plas/thonny-rpm/downloads/thonny.spec
SRPM URL:
https://bitbucket.org/plas/thonny-rpm/downloads/thonny-2.1.15-1.fc26.src.rpm


> Is it OK, if I leave adding the additional icon resolutions to for the next
> upstream release?

Sure.

Will do a formal review now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Aivar Annamaa  changed:

   What|Removed |Added

  Flags|needinfo?(aivar.annamaa@gma |
   |il.com) |



--- Comment #12 from Aivar Annamaa  ---
Thanks!

I updated the spec:
https://bitbucket.org/plas/thonny-rpm/commits/d27b7445bae27bd3a72cb340fffe6c27d0bcd941

New state:

* https://bitbucket.org/plas/thonny-rpm/downloads/thonny.spec
* https://bitbucket.org/plas/thonny-rpm/downloads/thonny-2.1.15-1.fc26.src.rpm
* https://copr.fedorainfracloud.org/coprs/aivarannamaa/thonny/monitor/

Is it OK, if I leave adding the additional icon resolutions to for the next
upstream release?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Miro Hrončok  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mhron...@redhat.com
  Flags||needinfo?(aivar.annamaa@gma
   ||il.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #11 from Miro Hrončok  ---
(In reply to Aivar Annamaa from comment #10)
> Thanks, Miro!
> 
> I got rid of pypi_name, the -n option, extra slahs after buildroot (the
> slash after %{_datadir} is required, right?)

Yes. You can check with:

$ rpm --eval '%{_datadir}'
/usr/share

> I also introduced
> desktop-file-install. I also updated the version in changelog (forgot it
> last time).

Good catch


> With `%{python3_sitelib}/thonny` rpmbuild gave me:
> 
> Checking for unpackaged file(s): /usr/lib/rpm/check-files
> /home/aivar/rpmbuild/BUILDROOT/thonny-2.1.15-1.fc26.x86_64
> error: Installed (but unpackaged) file(s) found:
>/usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/PKG-INFO
>/usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/SOURCES.txt
>   
> /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/
> dependency_links.txt
>   
> /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/entry_points.
> txt
>/usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/requires.txt
>   
> /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/top_level.txt
> 
> I tried `%{python3_sitelib}/thonny*` instead, and it seemed to work fine.
> Should I keep this?

Sorry about that, I forgot egg-info. Whether you go with thorny* or something
more sophisticated is up to you. Thorny* will continue the build even if
something like thorny_tests will get packaged by accident. I'd go with:

%{python3_sitelib}/%{name}/
%{python3_sitelib}/%{name}-%{version}-py%{python3_version}.egg-info/

Noticed the trailing slashes? I use them to make sure it's a directory.
Using %{name} here, spo others can copy paste form your spec with minimum
effort.

However this works as well:


%{python3_sitelib}/thonny/
%{python3_sitelib}/thonny-*.egg-info

It's your call here.

> 
> The changes are visible here:
> https://bitbucket.org/plas/thonny-rpm/commits/
> 8e6565e3b387cde2402f296ea2f11d303582a724

I see "%autosetup %{name}-%{version}" - you should be able to go with just
"%autosetup".

> I now noticed that I've forgotten a licensing issue. The toolbar icons are
> licensed with EPL, so I guess I need to change `License: MIT` to `License:
> MIT and EPL`. Am I right? But what should I then do with the EPL license
> text? (It is included in the upstream tarball in
> LICENSES/ECLIPSE-ICONS-LICENSE.txt) Currently my `%license LICENSE.txt`
> references the MIT license, which is the license for the code. I didn't find
> clear answers from
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#Multiple_Licensing_Scenarios

I haven't looked at the licenses yet, but if what you say is correect, than I'd
go with the following (notice the comment):



# Code is MIT, icons are EPL
License: MIT and EPL

...


%license LICENSE.txt LICENSES/ECLIPSE-ICONS-LICENSE.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Aivar Annamaa  changed:

   What|Removed |Added

  Flags|needinfo?(aivar.annamaa@gma |
   |il.com) |



--- Comment #10 from Aivar Annamaa  ---
Thanks, Miro!

I got rid of pypi_name, the -n option, extra slahs after buildroot (the slash
after %{_datadir} is required, right?). I also introduced desktop-file-install.
I also updated the version in changelog (forgot it last time).

With `%{python3_sitelib}/thonny` rpmbuild gave me:

Checking for unpackaged file(s): /usr/lib/rpm/check-files
/home/aivar/rpmbuild/BUILDROOT/thonny-2.1.15-1.fc26.x86_64
error: Installed (but unpackaged) file(s) found:
   /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/PKG-INFO
   /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/SOURCES.txt
  
/usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/dependency_links.txt
  
/usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/entry_points.txt
   /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/requires.txt
   /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/top_level.txt

I tried `%{python3_sitelib}/thonny*` instead, and it seemed to work fine.
Should I keep this?

The changes are visible here:
https://bitbucket.org/plas/thonny-rpm/commits/8e6565e3b387cde2402f296ea2f11d303582a724


I now noticed that I've forgotten a licensing issue. The toolbar icons are
licensed with EPL, so I guess I need to change `License: MIT` to `License: MIT
and EPL`. Am I right? But what should I then do with the EPL license text? (It
is included in the upstream tarball in LICENSES/ECLIPSE-ICONS-LICENSE.txt)
Currently my `%license LICENSE.txt` references the MIT license, which is the
license for the code. I didn't find clear answers from
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Miro Hrončok  changed:

   What|Removed |Added

 CC||mhron...@redhat.com
  Flags||needinfo?(aivar.annamaa@gma
   ||il.com)



--- Comment #9 from Miro Hrončok  ---
I can do a full review and I'm also willing to sponsor you.

I would very much like to include Thonny in the Fedora Python Classroom Lab.

From reading the spec, couple of nitpicks:

 * The reason to define and use the pypi_name macro does not apply here, since
it equals the package name. I'd recommend getting rid of it and use %{name}
everywhere.


 * I believe the -n option for %autosetup is not necessary, the used value is
the default.

 * %{buildroot} already contains the trailing slash, so using %{buildroot}/ is
not necessary and may eventually lead to trouble.

 * You can use desktop-file-install instead of install + desktop-file-validate.

 * Using %{python3_sitelib}/* in the %files section is very error prone.
Instead, I recommend to go with something more specific, like
%{python3_sitelib}/thonny (I haven't yet seen what the package installs
exactly, so this might differ a bit, but a quick look at setup.py makes me
think it should work here).

 * If more icon/logo resolutions are available, it would be a good idea to
package them as well. (At least the ico file seems to have more resolution
options).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #8 from Aivar Annamaa  ---
Thanks, Jason!

I'll contact you when the review gets done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #7 from Jason Tibbitts  ---
Please note that we don't sponsor packages, we sponsor people.  The sponsor is
responsible for helping the packager get their package through the system and
providing a direct contact point for questions when existing documentation or
mailing lists aren't enough.

I am always willing to sponsor upstream developers who wish to include their
software in Fedora, but I find it vastly preferable to work via public means of
communication, particularly via IRC.  That way anyone who is available can help
instead of everything relying on my response time (which can be variable).

So if you're on IRC, I'm tibbs in #fedora-devel on freenode.  Feel free to ping
me.  And if you're not but this gets through a package review without you
having picked up a sponsor, feel free to email me.

Note also that, sadly, I don't really have the time to do proper package
review.  So someone else will need to do that.  I did have a quick look at the
spec, though, and it certainly looks clean to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #6 from Aivar Annamaa  ---
I made a small tweak in the upstream (removed StartupNotify from the desktop
file). New state:

* https://bitbucket.org/plas/thonny-rpm/downloads/thonny.spec
* https://bitbucket.org/plas/thonny-rpm/downloads/thonny-2.1.15-1.fc26.src.rpm
* https://copr.fedorainfracloud.org/coprs/aivarannamaa/thonny/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #5 from Aivar Annamaa  ---
Thanks!

Here are the results with AppData validation included:

* https://bitbucket.org/plas/thonny-rpm/downloads/thonny.spec
* https://bitbucket.org/plas/thonny-rpm/downloads/thonny-2.1.14-1.fc26.src.rpm
* https://copr.fedorainfracloud.org/coprs/aivarannamaa/thonny/

Ben, are you willing to sponsor the package or should I keep searching?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #4 from Ben Rosser  ---
> Is it OK to leave the validation out?

If you add --nonet to the appstream-util command, it should work when ran
without internet access (as is the case when ran under mock). So, instead of:

> appstream-util validate-relax 
> %{buildroot}/%{_datadir}/metainfo/org.thonny.Thonny.appdata.xml

You can do this instead, and then it should be able to validate.

appstream-util validate-relax --nonet
%{buildroot}/%{_datadir}/metainfo/org.thonny.Thonny.appdata.xml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #3 from Aivar Annamaa  ---
Thanks a lot, Ben!

I added desktop file, man page and AppData file to the upstream sdist, changed
the Source0 and added icon installation.

The result is here: 

* https://bitbucket.org/plas/thonny-rpm/downloads/thonny.spec
* https://bitbucket.org/plas/thonny-rpm/downloads/thonny-2.1.14-1.fc26.src.rpm

PS. I tried also validating the AppData file in %install section (
https://bitbucket.org/plas/thonny-rpm/src/c15b8b97a1af5d58c28d695b51de57c2df609bb0/thonny.spec?fileviewer=file-view-default#thonny.spec-42
), but then mock complained about not finding the screenshot files. Looks like
it simply ran without internet access. Is it OK to leave the validation out?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Ben Rosser  changed:

   What|Removed |Added

 CC||rosser@gmail.com



--- Comment #2 from Ben Rosser  ---
Hi Aivar,

Welcome to Fedora!

As Sergey says, the copy of the spec here and the one in the SRPM differ. In
general this is a bad idea, even though here the differences are
minor/cosmetic:

$ diff thonny.spec thonny/thonny.spec 
11d10
< 
15d13
< 
31d28
< # In order to get rid of rpmlint warning

I took a quick look at the spec; it generally looks pretty reasonable. I have a
few initial comments:

Source0:   
https://pypi.python.org/packages/01/ad/b9ce07063b9d6b9c5f3835b0256775feacd75de44d86f813924ee96d3f16/thonny-2.1.12.tar.gz

You can replace the "2.1.12" here by the "%{version}" macro; this way whenever
you bump the version of the package the Source URL will automatically be
updated, too. (It's easy to forget otherwise to change the version in the URL).

Also, if possible, it's better to use the "files.pythonhosted.org" URLs for
PyPI, as they lack the magic hashes and are generally simpler. e.g. something
like the following, where %pypi_name is "thonny":

Source0:   
https://files.pythonhosted.org/packages/source/t/%{pypi_name}/%{pypi_name}-%{version}.tar.gz

(See https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
for another example of this).

While it's certainly fine to have the man page and desktop file in the spec
like this, if you are the upstream maintainer, is it possible to include them
in the upstream releases in the future? Distributions other than Fedora would
likely benefit from them.

You should also look into creating and shipping an AppData file for the package
as described here: https://fedoraproject.org/wiki/Packaging:AppData.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Sergey Avseyev  changed:

   What|Removed |Added

 CC||sergey.avse...@gmail.com



--- Comment #1 from Sergey Avseyev  ---
The spec file differ from the one in SRPM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1503175] Review Request: thonny - Python IDE for beginners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Aivar Annamaa  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org