[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591

mgans...@alice.de  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-10-31 04:26:55



--- Comment #18 from mgans...@alice.de  ---
package has been built successfully on f25, f26, f27 and rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #17 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/qxtglobalshortcut

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591

Raphael Groner  changed:

   What|Removed |Added

 Whiteboard|FTBFS   |



--- Comment #16 from Raphael Groner  ---
Sorry, I missed to continue here due to vacation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #15 from mgans...@alice.de  ---
Thanks for reviewing this ticket.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #14 from Robert-André Mauchin  ---
All ok for me, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #13 from mgans...@alice.de  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qxtglobalshortcut.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qxtglobalshortcut-0.0.1-0.5.20171021git1644620.fc26.src.rpm

%changelog
* Sun Oct 29 2017 Martin Gansser  -
0.0.1-0.5.20171021git1644620
- Don't include COPYING in %%doc, only in %%license
- Move Unversioned so-files directly in %%_libdir
- Use correct license tag BSD

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #12 from Robert-André Mauchin  ---
 - Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

libqxtglobalshortcut.so is currently in the main package whereas it should be
in the -devel subpackage.

 -The license in COPYING is BSD, not LGPLv3.

 - Don't include COPYING in %doc, only in %license:

%doc AUTHORS COPYING README.md
%license COPYING


Issues:
===
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "GPL (v3) LGPL (v3)", "Unknown or generated".
 26 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/qxtglobalshortcut/review-
 qxtglobalshortcut/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager 

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591

mgans...@alice.de  changed:

   What|Removed |Added

URL||https://github.com/hluk/qxt
   ||globalshortcut



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591

mgans...@alice.de  changed:

   What|Removed |Added

 Blocks||1507104




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1507104
[Bug 1507104] Review Request: vacuum-im - Cross platform Jabber client
written on Qt
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #11 from mgans...@alice.de  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qxtglobalshortcut.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qxtglobalshortcut-0.0.1-0.4.20171021git1644620.fc26.src.rpm

%changelog
* Tue Oct 24 2017 Martin Gansser  -
0.0.1-0.4.20171021git1644620
- Add BR cmake
- Add BR pkgconfig(Qt5Widgets)

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22680117

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591

Raphael Groner  changed:

   What|Removed |Added

 Whiteboard||FTBFS



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #10 from Raphael Groner  ---
Please please test your stuff before filing requests!

Therefore it's always a good idea to provide some link to a koji scratch build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #9 from Raphael Groner  ---
Still FTBFS:

CMake Warning at cmake/qt5.cmake:1 (find_package):
  By not providing "FindQt5Widgets.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "Qt5Widgets", but CMake did not find one.
  Could not find a package configuration file provided by "Qt5Widgets" with
  any of the following names:
Qt5WidgetsConfig.cmake
qt5widgets-config.cmake
  Add the installation prefix of "Qt5Widgets" to CMAKE_PREFIX_PATH or set
  "Qt5Widgets_DIR" to a directory containing one of the above files.  If
  "Qt5Widgets" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  cmake/qt.cmake:4 (include)
  CMakeLists.txt:29 (include)
-- Configuring incomplete, errors occurred!
See also
"/builddir/build/BUILD/qxtglobalshortcut-16446200b699e0610b8a5fb20b74938225d81d87/CMakeFiles/CMakeOutput.log".
CMake Error at cmake/qt5.cmake:3 (message):
  Qt 5 is unavailable.  To compile with Qt 4 use -DWITH_QT5=OFF.

Add BuildRequires:  pkgconfig(Qt5Widgets)

Execute cmake with %cmake -DWITH_QT5=ON

Do you plan to build for EPEL7? Please notice the package name is cmake3 there
and Qt5 is Qt is maintained by Red Hat people in RHEL7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #8 from Raphael Groner  ---
Are you interested in a review swap? Maybe take a look into bug #1506011.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #7 from mgans...@alice.de  ---
(In reply to Raphael Groner from comment #6)
> FTBFS:
> …
> + cd qxtglobalshortcut-16446200b699e0610b8a5fb20b74938225d81d87
> + %cmake .
> /var/tmp/rpm-tmp.1GGqi9: line 31: fg: no job control
> 
> Add BuildRequires: cmake

done, no extra file upload.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #6 from Raphael Groner  ---
FTBFS:
…
+ cd qxtglobalshortcut-16446200b699e0610b8a5fb20b74938225d81d87
+ %cmake .
/var/tmp/rpm-tmp.1GGqi9: line 31: fg: no job control

Add BuildRequires: cmake

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #5 from Raphael Groner  ---
(In reply to mgans...@alice.de from comment #3)
> (In reply to Raphael Groner from comment #1)
…
> What can i do ?

https://github.com/Vacuum-IM/vacuum-im/tree/dev_qt5

… as replied to your issue at upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #4 from mgans...@alice.de  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qxtglobalshortcut.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qxtglobalshortcut-0.0.1-0.3.20171021git1644620.fc26.src.rpm

%changelog
* Tue Oct 24 2017 Martin Gansser  -
0.0.1-0.3.20171021git1644620
- Disable qt4 build

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #3 from mgans...@alice.de  ---
(In reply to Raphael Groner from comment #1)
> You may want to build for Qt5 instead (or at least make Qt4 optional) as Qt4
> development is stalled at upstream.

The only Intention to build with qt4, is at the moment vacuum [1]. Vacuum a qt4
based app comes with a bundled version of qxtglobalshortcut. vacuum "core
dumped" with a qt5 compiled qxtglobalshortcut.

[1] https://github.com/Vacuum-IM/vacuum-im

What can i do ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #2 from mgans...@alice.de  ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qxtglobalshortcut.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/qxtglobalshortcut-0.0.1-0.2.20171021git1644620.fc26.src.rpm

%changelog
* Sat Oct 21 2017 Martin Gansser  -
0.0.1-0.2.20171021git1644620
- Update to 0.0.1-0.1.20171021git1644620

rpmlint -i -v qxtglobalshortcut.spec
/home/martin/rpmbuild/SRPMS/qxtglobalshortcut-0.0.1-0.2.20171021git1644620.fc26.src.rpm
/home/martin/rpmbuild/RPMS/x86_64/qxtglobalshortcut-0.0.1-0.2.20171021git1644620.fc26.x86_64.rpm
/home/martin/rpmbuild/RPMS/x86_64/qxtglobalshortcut-devel-0.0.1-0.2.20171021git1644620.fc26.x86_64.rpm
/home/martin/rpmbuild/RPMS/x86_64/qxtglobalshortcut-debuginfo-0.0.1-0.2.20171021git1644620.fc26.x86_64.rpm
qxtglobalshortcut.spec: I: checking
qxtglobalshortcut.spec: I: checking-url
https://github.com/hluk/qxtglobalshortcut/archive/16446200b699e0610b8a5fb20b74938225d81d87/qxtglobalshortcut-1644620.tar.gz
(timeout 10 seconds)
qxtglobalshortcut.src: I: checking
qxtglobalshortcut.src: I: checking-url
https://github.com/hluk/qxtglobalshortcut (timeout 10 seconds)
qxtglobalshortcut.src: I: checking-url
https://github.com/hluk/qxtglobalshortcut/archive/16446200b699e0610b8a5fb20b74938225d81d87/qxtglobalshortcut-1644620.tar.gz
(timeout 10 seconds)
qxtglobalshortcut.x86_64: I: checking
qxtglobalshortcut.x86_64: I: checking-url
https://github.com/hluk/qxtglobalshortcut (timeout 10 seconds)
qxtglobalshortcut.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/libqxtglobalshortcut.so
A file that is needed only e.g. when developing or building software is
included in a non-devel package. These files should go in devel packages.

qxtglobalshortcut-devel.x86_64: I: checking
qxtglobalshortcut-devel.x86_64: I: checking-url
https://github.com/hluk/qxtglobalshortcut (timeout 10 seconds)
qxtglobalshortcut-devel.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

qxtglobalshortcut-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

qxtglobalshortcut-debuginfo.x86_64: I: checking
qxtglobalshortcut-debuginfo.x86_64: I: checking-url
https://github.com/hluk/qxtglobalshortcut (timeout 10 seconds)
4 packages and 1 specfiles checked; 0 errors, 3 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591



--- Comment #1 from Raphael Groner  ---
You may want to build for Qt5 instead (or at least make Qt4 optional) as Qt4
development is stalled at upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504591] Review Request: qxtglobalshortcut - Cross-platform library for handling system-wide shortcuts in Qt applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504591

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms
 Blocks||928937 (qt-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org