needinfo canceled: [Bug 1505079] Review Request: php-goaop-parser-reflection - Provides reflection information, based on raw source

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for Shawn Iwinski
's needinfo:
Bug 1505079: Review Request: php-goaop-parser-reflection - Provides reflection
information, based on raw source
https://bugzilla.redhat.com/show_bug.cgi?id=1505079



--- Comment #6 from Package Review  ---
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1505079] Review Request: php-goaop-parser-reflection - Provides reflection information, based on raw source

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505079



--- Comment #4 from Shawn Iwinski  ---
(In reply to Shawn Iwinski from comment #3)
> (In reply to Remi Collet from comment #2)
> > - What do you think of raising minimal build dependency on phpparser ?
> > 
> > - What do you think of raising minimal runtime dependency on phpparser ?
> > Is this a problem in the drupal stack (ie, is there other package which
> > require another version of phpparser) ?
> 
> I should be able to do this.  I'll verify and update this pkg.

Raised

Diff:
https://github.com/siwinski/rpms/commit/8f37187d6698b443af57cb05b1051feecb625323



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/8f37187d6698b443af57cb05b1051feecb625323/php-goaop-parser-reflection/php-goaop-parser-reflection.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-goaop-parser-reflection-1.4.0-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505079] Review Request: php-goaop-parser-reflection - Provides reflection information, based on raw source

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505079



--- Comment #3 from Shawn Iwinski  ---
(In reply to Remi Collet from comment #2)
> - What do you think of raising minimal build dependency on phpparser ?
> 
> - What do you think of raising minimal runtime dependency on phpparser ?
> Is this a problem in the drupal stack (ie, is there other package which
> require another version of phpparser) ?

I should be able to do this.  I'll verify and update this pkg.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505079] Review Request: php-goaop-parser-reflection - Provides reflection information, based on raw source

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505079



--- Comment #2 from Remi Collet  ---
Running local bulid with phpparser 3 is ok

Running local bulid with phpparser 2 is KO

1) Go\ParserReflection\ReflectionFileTest::testIsStrictType with data set
"/Stub/FileWithClasses71.php" ('/Stub/FileWithClasses71.php', true)
PhpParser\Error: Syntax error, unexpected '?', expecting T_VARIABLE on line 20

Running local bulid with phpparser 1 is KO

1) Go\ParserReflection\ReflectionClassTest::testGetModifiers with data set
"PHP7.0" ('/dev/shm/extras/BUILD/parser-...70.php')
PhpParser\Error: Syntax error, unexpected '{', expecting T_STRING on line 15

2) Go\ParserReflection\ReflectionClassTest::testGetModifiers with data set
"PHP7.1" ('/dev/shm/extras/BUILD/parser-...71.php')
PhpParser\Error: Syntax error, unexpected '{', expecting T_STRING on line 14


- What do you think of raising minimal build dependency on phpparser ?

- What do you think of raising minimal runtime dependency on phpparser ?
Is this a problem in the drupal stack (ie, is there other package which require
another version of phpparser) ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505079] Review Request: php-goaop-parser-reflection - Provides reflection information, based on raw source

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505079

Remi Collet  changed:

   What|Removed |Added

 CC||fed...@famillecollet.com



--- Comment #1 from Remi Collet  ---
F26 scratch build OK
/dev/shm/extras/SRPMS/php-goaop-parser-reflection-1.4.0-1.fc25.remi.src.rpm

F28 scratch build OK
https://koji.fedoraproject.org/koji/taskinfo?taskID=22780170

I have tons of failure with fedora-review build (rawhide), strangely this one
pull phpparser v1...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505079] Review Request: php-goaop-parser-reflection - Provides reflection information, based on raw source

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505079

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285 (drush_v9_tracking)
  Alias||php-goaop-parser-reflection




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org