[Bug 1506315] Review Request: libstorj - Client library and CLI for encrypted file transfer on the Storj network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506315

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-11-10 22:05:33



--- Comment #8 from Fedora Update System  ---
libstorj-1.0.2-2.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506315] Review Request: libstorj - Client library and CLI for encrypted file transfer on the Storj network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506315

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
libstorj-1.0.2-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f3bd967c8f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506315] Review Request: libstorj - Client library and CLI for encrypted file transfer on the Storj network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506315

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506315] Review Request: libstorj - Client library and CLI for encrypted file transfer on the Storj network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506315



--- Comment #6 from Fedora Update System  ---
libstorj-1.0.2-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f3bd967c8f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506315] Review Request: libstorj - Client library and CLI for encrypted file transfer on the Storj network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506315



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libstorj. You may commit to the branch "f27"
in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506315] Review Request: libstorj - Client library and CLI for encrypted file transfer on the Storj network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506315



--- Comment #4 from Gwyn Ciesla  ---
Thank you! And likewise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506315] Review Request: libstorj - Client library and CLI for encrypted file transfer on the Storj network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506315

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
All ok then, package accepted.

Thanks for all your good work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506315] Review Request: libstorj - Client library and CLI for encrypted file transfer on the Storj network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506315



--- Comment #2 from Gwyn Ciesla  ---
Excellent, thank you!

SPEC: https://fedorapeople.org/~limb/review/libstorj/libstorj.spec
SPRM: https://fedorapeople.org/~limb/review/libstorj-1.0.2-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506315] Review Request: libstorj - Client library and CLI for encrypted file transfer on the Storj network

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506315

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,

 - Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz is 404ing.
Correct URL is:

Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz

 - Group: is not used in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - You must add a BuildRequires against gcc. See:
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

 - make %{?_smp_mflags} ⇒ %make_build

 - make DESTDIR=$RPM_BUILD_ROOT install ⇒ %make_install

 - ./autogen.sh ⇒ autoreconf -vif

 - Use pkgconfig when you can:

BuildRequires: pkgconfig(libuv)
BuildRequires: pkgconfig(libmicrohttpd)
BuildRequires: autoconf
BuildRequires: automake
BuildRequires: libtool
BuildRequires: pkgconfig(libcurl)
BuildRequires: pkgconfig(json-c)



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (2 clause)", "Unknown or generated".
 43 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/libstorj/review-libstorj/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package