[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-19 14:44:48



--- Comment #9 from Fedora Update System  ---
toxcore-0.1.10-2.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
toxcore-0.1.10-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6d37ee9718

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986



--- Comment #7 from Fedora Update System  ---
toxcore-0.1.10-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6d37ee9718

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/toxcore

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986

Sandro Mani  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Sandro Mani  ---
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/include/tox
[!]: Package must own all directories that it creates.

=> Please fix this on import by using
%{_includedir}/tox/
instead of
%{_includedir}/tox/*

Rest is good, approved. 


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "GPL (v3 or later)", "Unknown or generated", "MIT/X11
 (BSD like)", "BSD (unspecified)", "ISC", "BSD (2 clause)", "FSF All
 Permissive". 142 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/include/tox
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/include/tox
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 51200 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully 

[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986



--- Comment #4 from Robert-André Mauchin  ---
Fixed

Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/3cd73a7/toxcore.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00656774-toxcore/toxcore-0.1.10-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986



--- Comment #3 from Sandro Mani  ---
This also needs to be included in the license breakdown

ISC
---
c-toxcore-0.1.10/toxcore/crypto_core_mem.c


These don't seem to actually be used so I guess it's okay to leave them out.

MIT/X11 (BSD like)
--
c-toxcore-0.1.10/other/bootstrap_daemon/docker/get-nodes.py
c-toxcore-0.1.10/other/fun/bootstrap_node_info.py

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986



--- Comment #2 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/68026b4/toxcore.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00656750-toxcore/toxcore-0.1.10-2.fc28.src.rpm

 - Fixed licenses
 - Removed INSTALL_ROOT=%{buildroot}


Thank you for all the reviews!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986



--- Comment #1 from Sandro Mani  ---
Created attachment 1346390
  --> https://bugzilla.redhat.com/attachment.cgi?id=1346390=edit
licensecheck.txt

INSTALL_ROOT=%{buildroot} is usually only needed for qmake generated Makefiles
and shouldn't be necessary here.

Some files are BSD licensed, see licensecheck.txt attached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986

Sandro Mani  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||manisan...@gmail.com
   Assignee|nob...@fedoraproject.org|manisan...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507986

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1508002




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1508002
[Bug 1508002] Review Request: uTox - The lightweight Tox client
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org