[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 Sandro Mani changed: What|Removed |Added Status|NEW |ASSIGNED CC||manisan...@gmail.com Assignee|nob...@fedoraproject.org|manisan...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #1 from Sandro Mani --- There are a couple of errors like: RCC: Error in '../resources/rssguard.qrc': Cannot find file 'localizations/rssguard_cs.qm' messages in the build log, I suppose it might be related to the out-of-tree build and that localization is potentially broken? Does CONFIG+=debug actually have any effect? There appears to be a bundled qtsingleapplication, ideally it should be unbundled, otherwise you'll need to add the bundled(qtsingleapplication) provides, see [1]. Also note that qtsingleapplication is BSD licensed, hence you'd need to update the License field accordingly if you bundle. [1] https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #2 from Sandro Mani --- Created attachment 1346389 --> https://bugzilla.redhat.com/attachment.cgi?id=1346389&action=edit licensecheck.txt Actually there are a variety of licenses involved, see licensecheck.txt attached. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #3 from Robert-André Mauchin --- > in the build log, I suppose it might be related to the out-of-tree build and > that localization is potentially broken? It's normal, it searches for compiled qm files, doesn't find them, so it compiles them with lrelease-qt5. The translations work fine. > There appears to be a bundled qtsingleapplication, ideally it should be > unbundled I tried to do that, but it turns out the author "customized" the local copy of qtsingleapplication by adding functions to it. Specifically this commit: https://github.com/martinrotter/rssguard/commit/5a6870e184c92f4131c52e2b7d35e57c81ba4607#diff-b665d878174c480761afcde9c0eaa1f0 He added a function called finish: >void QtSingleApplication::finish() >{ > delete peer; peer = 0; >} If I try to build with the system qtsingleapplication, it fails because it desn't find thi finish function. I'm not sure how to proceed then. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #4 from Sandro Mani --- > It's normal, it searches for compiled qm files, doesn't find them, so it > compiles them with lrelease-qt5. The translations work fine. Ok > He added a function called finish: Ok, yes this is pretty un-unbundlable. In this case just add the bundled virtual provides, and perhaps add a comment about why it can't be unbundled. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #5 from Robert-André Mauchin --- Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/8392830/rssguard.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rssguard/fedora-rawhide-x86_64/00656729-rssguard/rssguard-3.5.4-3.fc28.src.rpm - I've fixed the license. - I've elected to remove the call to finish as it was not essential to the correct functioning of the restart function. - I've removed CONFIG+=debug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #6 from Sandro Mani --- You can also rm -rf src/qtsingleapplication in %prep to be sure, and then you don't need to include it in the license breakdown. For the rest, looks good! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #7 from Robert-André Mauchin --- Done. Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/4c01019/rssguard.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rssguard/fedora-rawhide-x86_64/00656759-rssguard/rssguard-3.5.4-3.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 Sandro Mani changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Sandro Mani --- The following should be fixed rssguard.x86_64: E: non-standard-executable-perm /usr/bin/rssguard 775 Otherwise all good, approved (but please fix the permission when importing). Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated", "AGPL (v3 or later)", "BSD (3 clause) GPL (v3 or later)", "CC0", "*No copyright* BSD (3 clause)", "BSD (3 clause)". [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rssguard-debuginfo , rssguard-debugsource [?]: Package func
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #9 from Robert-André Mauchin --- Will do, thanks again for the reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #10 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rssguard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 --- Comment #11 from Fedora Update System --- rssguard-3.5.4-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-36b5951b6d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- rssguard-3.5.4-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-36b5951b6d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1508034] Review Request: rssguard - Simple yet powerful feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1508034 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-11-10 22:13:56 --- Comment #13 from Fedora Update System --- rssguard-3.5.4-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org