[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-05 11:13:17



--- Comment #19 from Fedora Update System  ---
pew-1.1.2-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #18 from Mathieu Bridon  ---
>> Alright Mathieu I will take those packages.
> 
> I just made you admin for those 3 packages.
> 
> Somehow I can't find how to remove myself, though. :-/

And I just found it, thanks to Pierre-Yves.

They are all yours now, take good care of them. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #17 from Mathieu Bridon  ---
> Alright Mathieu I will take those packages.

I just made you admin for those 3 packages.

Somehow I can't find how to remove myself, though. :-/

>> Please take them, Michal; it's only fair :)
> 
> Also, I think Python SIG might be interested in co-maintaining those packages.

The Python SIG already had commit permissions on all 3 packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
pew-1.1.2-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5ecbcbff22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #15 from Fedora Update System  ---
pew-1.1.2-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5ecbcbff22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #14 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/pew. You may commit to the branch "f28" in
about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570

Miro Hrončok  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Miro Hrončok  ---
> Tool to manage multiple virtualenvs written in pure python

Please use uppercase P for Python.


> # Add pytest marker to test requiring connection
> Patch0: 0001-tests-connection-marker-fix.patch

Is this posted upstream?



Package is APPROVED.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 https://koji.fedoraproject.org/koji/taskinfo?taskID=24266546
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: Reviewer should test that the package builds in mock. (I've checked Koji,
had some local troubles)
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
 justified. Unsure here.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
 files.
[x]: Buildroot is not present

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570

Miro Hrončok  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mhron...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #12 from Michal Cyprian  ---
Alright Mathieu I will take those packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #11 from Miro Hrončok  ---
*** Bug 1385244 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #10 from Miro Hrončok  ---
> > Do you want python-rangehttpserver, python-pythonz-bd and 
> > python-resumable-urlretrieve?
> 
> Please take them, Michal; it's only fair :)


Also, I think Python SIG might be interested in co-maintaining those packages.

Thanks Mathieu for all the info, I'll go ahead with the review soon.(In reply
to

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #9 from Petr Viktorin  ---
> @Michal: If you keep the with_check condition, you probably want to 
> conditionalize this BR

When skipping tests in mock you'd probably also use --no-clean, so the extra
BuildRequire doesn't hurt. (And, no need to make the spec more complex for
what's just there for maintainers' convenience.)

> Do you want python-rangehttpserver, python-pythonz-bd and 
> python-resumable-urlretrieve?

Please take them, Michal; it's only fair :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #8 from Mathieu Bridon  ---
@Michal: If you keep the with_check condition, you probably want to
conditionalize this BR then, afaik it's only needed at runtime and for the
tests:

BuildRequires:  python3dist(pythonz-bd) >= 1.10.2

The setup.py script has an explicit requirement on "virtualenv >= 1.11". Maybe
add it explicitly as a BR/R? (it gets dragged in implicitly by virtualenv-clone
with your spec file)

Other than that, it's so close to the spec I had submitted that I'll let Miro
finish the review he started. :)

Do you want python-rangehttpserver, python-pythonz-bd and
python-resumable-urlretrieve? I really only added them for Pew, I don't
particularly care about them, so I'd be happier if they had a more interested
maintainer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570

Petr Viktorin  changed:

   What|Removed |Added

 CC||pvikt...@redhat.com



--- Comment #7 from Petr Viktorin  ---

> Finally, what's up with bcond_without for the tests? Sure, I forgot to add the
> tests in my spec, it's great you added them. :) But what's the point of
> conditionally running them? That's not even possible in mock/Koji anyway.

In mock it is! Both `mock` and recent versions of `fedpkg mockbuild` have
--with and --without options.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #6 from Michal Cyprian  ---
Thanks for sharing your experience with completion scripts Mathieu. I have
renamed package to pew and got rid of completion subpackages. 

I want to keep condition to skip test suite. It takes quite a long time to run
pew's tests and I sometimes find it useful to disable it temporarily. The
official builds will of course always run the tests.

Updated files are here:
Spec URL: https://mcyprian.fedorapeople.org/pew.spec
SRPM URL: https://mcyprian.fedorapeople.org/pew-1.1.2-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570

Michal Cyprian  changed:

   What|Removed |Added

Summary|Review Request: python-pew  |Review Request: pew - Tool
   |- Tool to manage multiple   |to manage multiple
   |virtualenvs written in pure |virtualenvs written in pure
   |python  |python



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org