[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 Marius Andreiana changed: What|Removed |Added CC||marius.andrei...@gmail.com --- Comment #9 from Marius Andreiana --- ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768
--- Comment #10 from Marius Andreiana ---
I've tried to build this on F30
dnf -y install cctz
dnf builddep clickhouse-1.1.54330-1.fc28.src.rpm
rpmbuild --rebuild clickhouse-1.1.54330-1.fc28.src.rpm
and it gives an error:
*** WARNING *** there are active plugins, do not report this as a bug unless
you can reproduce it without enabling any plugins.
Event| Plugins
PLUGIN_FINISH_UNIT | annobin: Generate final annotations
PLUGIN_START_UNIT| annobin: Generate global annotations
PLUGIN_ALL_PASSES_START | annobin: Generate per-function annotations
PLUGIN_ALL_PASSES_END| annobin: Register per-function end symbol
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/dbms/src/Storages/ColumnDefault.cpp:
In function 'std::string DB::toString(DB::ColumnDefaultType)':
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/dbms/src/Storages/ColumnDefault.cpp:31:90:
internal compiler error: in ocp_convert, at cp/cvt.c:766
31 | return it != std::end(map) ? it->second : throw Exception{"Invalid
ColumnDefaultType"};
|
^
Please submit a full bug report,
with preprocessed source if appropriate.
See for instructions.
[ 65%] Building CXX object
dbms/CMakeFiles/dbms.dir/src/Storages/StorageBuffer.cpp.o
...
Preprocessed source stored into /tmp/cci1BNri.out file, please attach this to
your bugreport.
make[2]: *** [dbms/CMakeFiles/dbms.dir/build.make:3069:
dbms/CMakeFiles/dbms.dir/src/Storages/ColumnDefault.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs
In file included from
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/dbms/src/Dictionaries/CacheDictionary.h:9,
from
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/dbms/src/Storages/StorageDictionary.cpp:7:
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/libs/libcommon/include/ext/bit_cast.h:
In instantiation of 'std::decay_t<_Tp> ext::bit_cast(const From&) [with To =
std::chrono::time_point > >; From = long
unsigned int; std::decay_t<_Tp> =
std::chrono::time_point > >]':
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/libs/libcommon/include/ext/bit_cast.h:28:34:
required from 'std::decay_t<_Tp> ext::safe_bit_cast(const From&) [with To =
std::chrono::time_point > >; From = long
unsigned int; std::decay_t<_Tp> =
std::chrono::time_point > >]'
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/dbms/src/Dictionaries/CacheDictionary.h:163:104:
required from here
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/libs/libcommon/include/ext/bit_cast.h:17:15:
warning: 'void* memcpy(void*, const void*, size_t)' copying an object of
non-trivial type 'struct
std::chrono::time_point > >' from an array of
'const long unsigned int' [-Wclass-memaccess]
17 | memcpy(&res, &from, std::min(sizeof(res), sizeof(from)));
| ~~^~
In file included from /usr/include/c++/9/mutex:39,
from
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/libs/libcommon/include/common/DateLUT.h:8,
from
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/dbms/src/Common/FieldVisitors.h:5,
from
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/dbms/src/Parsers/ASTSetQuery.h:4,
from
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/dbms/src/Parsers/ASTCreateQuery.h:5,
from
/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing/dbms/src/Storages/StorageDictionary.cpp:2:
/usr/include/c++/9/chrono:626:14: note: 'struct
std::chrono::time_point > >' declared here
626 | struct time_point
| ^~
make[2]: Leaving directory '/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing'
make[1]: *** [CMakeFiles/Makefile2:1910: dbms/CMakeFiles/dbms.dir/all] Error 2
make[1]: Leaving directory '/root/rpmbuild/BUILD/ClickHouse-1.1.54330-testing'
make: *** [Makefile:133: all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.QQhrtI (%build)
RPM build errors:
user roman does not exist - using root
group roman does not exist - using root
user roman does not exist - using root
group roman does not exist - using root
user roman does not exist - using root
group roman does not exist - using root
user roman does not exist - using root
group roman does not exist - using root
Bad exit status from /var/tmp/rpm-tmp.QQhrtI (%build)
Would also be great to upgrade to latest version.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of C
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 --- Comment #11 from Marius Andreiana --- Created attachment 1581180 --> https://bugzilla.redhat.com/attachment.cgi?id=1581180&action=edit /tmp/cci1BNri.out -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #8 from Elliott Sales de Andrade --- cctz is now packaged for Fedora 28+ [1] if you want to depend on it. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1556661 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 --- Comment #1 from Roman Tsisyk --- Minor changes: - Fix paths in /etc/clickhouse-server/config.xml - Fix permissions for /etc/clickhouse-server/ - Get clickhouse-server to work out of the box Spec URL: https://gist.githubusercontent.com/rtsisyk/1a45e69293f3e2c91126fe04a8374af8/raw/1780b8b0548841957b09cabdcfc1dc8b47e0dced/clickhouse.spec SRPM URL: https://gist.github.com/rtsisyk/1a45e69293f3e2c91126fe04a8374af8/raw/1780b8b0548841957b09cabdcfc1dc8b47e0dced/clickhouse-1.1.54326-1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 Michael Cullen changed: What|Removed |Added CC||mich...@cullen-online.com --- Comment #2 from Michael Cullen --- Ok... a few things I note: * The BuildRequires are at the top - I'd expect the name block at the top. * This bundles cctz without any comments as to why * Have you tried unbundling boost? Although it looks for 1.60 the bundled version is 1.65 so I'd guess the version isn't actually that critical - a small patch to remove the version number would most likely be all that's required * The CMake file seems to support ARM builds - any reason to make this exclusivearch other than the docs claiming it is? * Groups aren't needed or particularly wanted [1] [1] https://fedoraproject.org/wiki/RPMGroups -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 --- Comment #3 from Michael Cullen --- I tried a mock build of this in a rawhide container and got this error: CMake Error at dbms/cmake_install.cmake:61 (file): file INSTALL cannot copy file "/builddir/build/BUILD/ClickHouse-1.1.54326-testing/dbms/libclickhouse.so.1.1.54326" to "/builddir/build/BUILDROOT/clickhouse-1.1.54326-1.fc28.x86_64/usr/lib64/clickhouse/libclickhouse.so.1.1.54326". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 --- Comment #4 from Michael Cullen --- actually ignore me that's probably a disk space issue on my end! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 --- Comment #5 from Roman Tsisyk --- Hi Michael, Thanks for the fast response. * The BuildRequires are at the top - I'd expect the name block at the top. BuildRequires have been moved to a proper place. Fixed. * This bundles cctz without any comments as to why According to Github [1], the latest released version of google/cctz is 2.1, but ClickHouse's scripts needs src/zone_info_source.cc which was added after 2.1 release. I added a comment about that to spec file. This package is very tricky in terms of dependencies, as you can see in the BuildRequires list. [1] https://github.com/google/cctz/releases * Have you tried unbundling boost? Although it looks for 1.60 the bundled version is 1.65 so I'd guess the version isn't actually that critical - a small patch to remove the version number would most likely be all that's required Switched to boost-devel. Initially it didn't compile, but it seems that my combination of CMake flags has fixed this problem. Fixed. * The CMake file seems to support ARM builds - any reason to make this exclusivearch other than the docs claiming it is? Upstream claims that "Only x86_64 with SSE 4.2 is supported. Support for AArch64 is experimental." [2]. I tried to compile aarch64 on my test host and realized that some code under #ifdef..#else..#endif is completely broken. I fixed this problem and send a pull request to upstream [2], hope they will merge it soon. Using this fix I was able to reach 99% completeness in CMake. Unfortunately, linking of C++ code requires a lot of memory and fails with OOM on my coin-size aarch64 mini-PC. [2] https://clickhouse.yandex/docs/en/development/build.html [3] https://github.com/yandex/ClickHouse/pull/1674 Plan: - Wait until pull request is accepted or include this fix as a patch - Re-try on an aarch64 host with more RAM - Enable or disable aarch64 in ExclusiveArch depending on result I don't think that aarch64 supports blocks review. I'll make the best efforts to fix aarch64 both in upstream and this package. * Groups aren't needed or particularly wanted [1] I removed `Group:` tag. Fixed. Full changelog: - Re-order BuildRequires - Add `sed` to BuildRequires - Add a comment about google/cctz - Remove `Group` - Use `boost-devel` instead of bundled boost - Enable experimental aarch64 support Spec URL: https://gist.githubusercontent.com/rtsisyk/1a45e69293f3e2c91126fe04a8374af8/raw/f43fc9f556998507bfbbdfbee50410f1b6c8c39b/clickhouse.spec SRPM URL: https://gist.github.com/rtsisyk/1a45e69293f3e2c91126fe04a8374af8/raw/f43fc9f556998507bfbbdfbee50410f1b6c8c39b/clickhouse-1.1.54326-1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 Roman Tsisyk changed: What|Removed |Added Flags||needinfo?(michael@cullen-on ||line.com) --- Comment #6 from Roman Tsisyk --- Updated to 1.1.54330 Spec URL: https://gist.github.com/rtsisyk/1a45e69293f3e2c91126fe04a8374af8/raw/26e1b13080ea89eec86437a142aaaf80e8425da1/clickhouse.spec SRPM URL: https://gist.github.com/rtsisyk/1a45e69293f3e2c91126fe04a8374af8/raw/26e1b13080ea89eec86437a142aaaf80e8425da1/clickhouse-1.1.54330-1.fc28.src.rpm Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=24073176 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 Michael Cullen changed: What|Removed |Added Flags|needinfo?(michael@cullen-on | |line.com) | --- Comment #7 from Michael Cullen --- Looking much better in terms of comments! You might want to consider packaging cctz from that Git release (it doesn't seem to be in Fedora at all right now) but it isn't something I'm going to moan about too much. Just one thing about the bundling though: the guidelines [0] require any bundled libraries to be called out in the spec file as provides - something like: Provides: bundled(cctz) = 20171031.4f9776a should do the trick. [0] https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries [1] https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 Kfir Itzhak changed: What|Removed |Added CC||masterthekn...@gmail.com --- Comment #14 from Kfir Itzhak --- Hi, I rewrote an old SPEC file, and i'm using it to build ClickHouse for CentOS8 on x86 and aarch64, and currently working on getting it built on ppc64le. I would like to become a maintainer for this package on Fedora 32+ & RHEL8+ if possible. Kfir -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
https://bugzilla.redhat.com/show_bug.cgi?id=1526768 --- Comment #15 from Elliott Sales de Andrade --- This review died; you should probably just open a new one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
needinfo canceled: [Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Roman Tsisyk 's needinfo: Bug 1526768: Review Request: clickhouse - a distributed column-oriented DBMS https://bugzilla.redhat.com/show_bug.cgi?id=1526768 --- Comment #13 from Package Review --- This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
