[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Sergio Monteiro Basto  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1186900



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-17 11:20:21



--- Comment #11 from Fedora Update System  ---
twolame-0.3.13-9.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Yaakov Selkowitz  changed:

   What|Removed |Added

  Flags|needinfo?(yselkowi@redhat.c |
   |om) |



--- Comment #10 from Yaakov Selkowitz  ---
Thanks!  Good enough for me, but I imagine someone may want this in EPEL at
some point.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Zamir SUN  changed:

   What|Removed |Added

  Flags||needinfo?(yselkowi@redhat.c
   ||om)



--- Comment #9 from Zamir SUN  ---
Hi Yaakov,

Now I built twolame for Rawhide and Fedora 27. If you need other branch, feel
free to let me know.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719



--- Comment #8 from Fedora Update System  ---
twolame-0.3.13-9.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-95a02e792a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/twolame

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1534370




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1534370
[Bug 1534370] Requires: lame, twolame for MP2, MP3 encoding
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1534297




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1534297
[Bug 1534297] Use twolame for MP2 encoding
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1450227




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1450227
[Bug 1450227] audacity: enable MP2/MP3 output support
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1534291




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1534291
[Bug 1534291] Enable MP2 encoding with twolame
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1534289




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1534289
[Bug 1534289] Enable twolame element
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #6 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD
 like)", "*No copyright* LGPL", "*No copyright* Public domain", "LGPL
 (v2.1 or later)", "GPL (v2.1 or later) (with incorrect FSF address)
 LGPL (v2.1 or later)". 71 files have unknown license. Detailed output
 of licensecheck in /home/bob/packaging/review/twolame/review-
 twolame/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 481280 bytes in 30 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} 

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719



--- Comment #5 from Sergio Monteiro Basto  ---
sorry wrote in wrong bug is was for bug 1530090 ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719



--- Comment #4 from Zamir SUN  ---
(In reply to Sergio Monteiro Basto from comment #3)
> Packages remaining to rebuild:
> fawkes
> kf5-libkface
> player
> 
> but player is FTBFS bug #1533278 , fawkes depends on player and kf5-libkface
> bug #1423813 was retired and add to Fedora fedora-obsolete-packages

Hi Sergio,

This is the review request of twolame. I believe you are commenting about kde
related packages which is not about twolame. Let's keep this bug focused.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Sergio Monteiro Basto  changed:

   What|Removed |Added

 CC||ser...@serjux.com



--- Comment #3 from Sergio Monteiro Basto  ---
Packages remaining to rebuild:
fawkes
kf5-libkface
player

but player is FTBFS bug #1533278 , fawkes depends on player and kf5-libkface
bug #1423813 was retired and add to Fedora fedora-obsolete-packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719



--- Comment #2 from Zamir SUN  ---
Oh, I try to keep it mostly as-is from rpmfusion. I can post an update if this
is essential for a review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
># fix HTML docs line endings
>for file in html/*.html ; do
>   tr -d '\r' <$file >$file.unix && mv $file.unix $file
>done
Wouldn't it be simpler to use dos2unix here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org