[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 Björn "besser82" Esser changed: What|Removed |Added CC||zbys...@in.waw.pl --- Comment #1 from Björn "besser82" Esser --- *** Bug 1396819 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #2 from Björn "besser82" Esser --- Scratch builds: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24159255 fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24159256 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi-1.0.2-0.1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #3 from Björn "besser82" Esser --- Updated package: - New upstream release Scratch builds: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24160769 fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24160777 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi-1.0.3-0.1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #4 from Björn "besser82" Esser --- Updated package: - Asume optmem_max is at least 20480, if the real value cannot be obtained Scratch builds: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24168294 fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24168303 fc26: https://koji.fedoraproject.org/koji/taskinfo?taskID=24168313 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi-1.0.3-0.2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929
--- Comment #5 from Björn "besser82" Esser ---
Updated package:
- Move libraries to /%%{_lib} instead of %%{_libdir}, which is useful
during boot when the library might be needed before a potentially
seperate /usr partition is mounted
Scratch builds:
Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24168671
fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24168673
fc26: https://koji.fedoraproject.org/koji/taskinfo?taskID=24168681
Urls:
Spec URL:
https://pagure.io/besser82/package-review/raw/master/f/libkcapi.spec
SRPM URL:
https://pagure.io/besser82/package-review/raw/master/f/libkcapi-1.0.3-0.3.fc28.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #6 from Björn "besser82" Esser --- Updated package: - Asume the testsuite cannot be run, if the value of optmem_max cannot be obtained Scratch builds: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24168968 fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24168977 fc26: https://koji.fedoraproject.org/koji/taskinfo?taskID=24168986 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi-1.0.3-0.4.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #7 from Björn "besser82" Esser --- Updated package: - Add patches from upstream Scratch builds: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24172336 fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24172347 fc26: https://koji.fedoraproject.org/koji/taskinfo?taskID=24172356 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi-1.0.3-0.5.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #8 from Björn "besser82" Esser --- Updated package: - Add patches from upstream Scratch builds: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24182378 fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24182386 fc26: https://koji.fedoraproject.org/koji/taskinfo?taskID=24182395 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi-1.0.3-0.6.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929
--- Comment #9 from Björn "besser82" Esser ---
Updated package:
- Fix internal Requires of sub-packages
- Hardlink files in %%{_bindir}
Scratch builds:
Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24192398
fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24192406
fc26: https://koji.fedoraproject.org/koji/taskinfo?taskID=24192414
Urls:
Spec URL:
https://pagure.io/besser82/package-review/raw/master/f/libkcapi.spec
SRPM URL:
https://pagure.io/besser82/package-review/raw/master/f/libkcapi-1.0.3-0.7.fc28.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #10 from Björn "besser82" Esser --- Updated package: - Move the kcapi-hasher binary to -replacements package, since it is not of much use without the linked invocation names and saves the extra Requires on the -tools package Scratch builds: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24193416 fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24193424 fc26: https://koji.fedoraproject.org/koji/taskinfo?taskID=24193433 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi-1.0.3-0.8.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #11 from Robert-André Mauchin ---
As anticipated, the subpackage replacements conflicts with coreutils:
DEBUG util.py:479: Error: Transaction check error:
DEBUG util.py:479:file /usr/bin/md5sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64
DEBUG util.py:479:file /usr/bin/sha1sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64
DEBUG util.py:479:file /usr/bin/sha224sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64
DEBUG util.py:479:file /usr/bin/sha256sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64
DEBUG util.py:479:file /usr/bin/sha384sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64
DEBUG util.py:479:file /usr/bin/sha512sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64
Also what is the purpose of all these hidden hmac files dropped into /usr/bin?
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL", "*No copyright* GPL (v2 or later) (with incorrect FSF
address)", "Unknown or generated", "BSD (3 clause) GPL", "*No
copyright* BSD (3 clause)", "*No copyright* BSD (unspecified)", "BSD
(unspecified)", "FSF All Permissive". 54 files have unknown license.
Detailed output of licensecheck in /home/bob/packaging/review/libkcapi
/review-libkcapi/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #12 from Björn "besser82" Esser --- (In reply to Robert-André Mauchin from comment #11) > As anticipated, the subpackage replacements conflicts with coreutils: Allrighty, I'll disable it for now and until I could get an agreement with the maintainer of coreutils… > Also what is the purpose of all these hidden hmac files dropped into > /usr/bin? Those hidden hmac files are used by `fipscheck` to do some basic integrity check on the binaries: ``` fipscheck will perform a FIPS-140-2 validation of a file using a stored checksum of a file. The file containing the checksum value will be searched for in the same directory as the file which is being checksummed. The checksum file must have '.' prepended and '.hmac' appended to the original file name. ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #13 from Björn "besser82" Esser --- Updated package: - Disable the -replacements package until we have a plan for it Scratch builds: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24203658 fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24203666 fc26: https://koji.fedoraproject.org/koji/taskinfo?taskID=24203674 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libkcapi-1.0.3-0.9.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #14 from Björn "besser82" Esser --- Fixed scratch builds: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=24204151 fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24204152 fc26: https://koji.fedoraproject.org/koji/taskinfo?taskID=24204153 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #15 from Robert-André Mauchin --- Seems ok for me, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #16 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libkcapi. You may commit to the branch "f27" in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #18 from Fedora Update System --- libkcapi-1.0.3-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f21b93a29d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #17 from Fedora Update System --- libkcapi-1.0.3-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-7f6e43d389 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System --- libkcapi-1.0.3-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f21b93a29d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #20 from Fedora Update System --- libkcapi-1.0.3-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-7f6e43d389 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-01-26 12:55:49 --- Comment #21 from Fedora Update System --- libkcapi-1.0.3-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API
https://bugzilla.redhat.com/show_bug.cgi?id=1533929 --- Comment #22 from Fedora Update System --- libkcapi-1.0.3-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
