[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Bug 1534067 depends on bug 1504375, which changed state. Bug 1504375 Summary: python-nibabel-2.3.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1504375 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/TTKERKRVPA6YLVMR7YG2IEMWS5GS54FY/
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Bug 1534067 depends on bug 1280480, which changed state. Bug 1280480 Summary: Review Request: python-duecredit - Automated collection and reporting of citations for used software/methods/datasets https://bugzilla.redhat.com/show_bug.cgi?id=1280480 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OMR2G232RCH3OUC2UPHSRONJBN3OFKJK/
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Ankur Sinha (FranciscoD) --- Athmane, the package is now ready for review. Duecredit and grabbit have been packaged etc., and so the tests are all run, and the docs are built too. Can you please review it? Updated spec/srpm: https://ankursinha.fedorapeople.org/python-pybids/python-pybids.spec https://ankursinha.fedorapeople.org/python-pybids/python-pybids-0.6.5-1.gite35ced6.fc29.src.rpm Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #6 from Ankur Sinha (FranciscoD) --- Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30730136 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1276941 (fedora-neuro) Alias||python-pybids Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Manas Mangaonkar (Pac23) changed: What|Removed |Added CC||manasmangaon...@gmail.com --- Comment #7 from Manas Mangaonkar (Pac23) --- I am not a official Packager yet,this is a unofficial review. --- Mock build failed on two different machines,config error stating fc28 ERROR: Exception(/root/python-pybids-0.6.5-1.gite35ced6.fc29.src.rpm) Config(fedora-28-x86_64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #8 from Ankur Sinha (FranciscoD) --- (In reply to Manas Mangaonkar (Pac23) from comment #7) > I am not a official Packager yet,this is a unofficial review. > --- > > > Mock build failed on two different machines,config error stating fc28 > > ERROR: Exception(/root/python-pybids-0.6.5-1.gite35ced6.fc29.src.rpm) > Config(fedora-28-x86_64) Manas, I'm afraid that's not sufficient to be called a review. You must at least investigate the build logs and point out what the error is. In this case, I can guess what it is. it is that duecredit and grabbit are in testing and therefore not present in the stable repos. So, the package will build correctly in rawhide but will need build root overrides for the stable releases. Please check the build log to confirm if this is the case :) More information here: https://fedoraproject.org/wiki/Package_update_HOWTO#Updating_inter-dependent_packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #9 from Manas Mangaonkar (Pac23) --- (In reply to Ankur Sinha (FranciscoD) from comment #8) > (In reply to Manas Mangaonkar (Pac23) from comment #7) > > I am not a official Packager yet,this is a unofficial review. > > --- > > > > > > Mock build failed on two different machines,config error stating fc28 > > > > ERROR: Exception(/root/python-pybids-0.6.5-1.gite35ced6.fc29.src.rpm) > > Config(fedora-28-x86_64) > > Manas, I'm afraid that's not sufficient to be called a review. You must at > least investigate the build logs and point out what the error is. > > > In this case, I can guess what it is. it is that duecredit and grabbit are > in testing and therefore not present in the stable repos. So, the package > will build correctly in rawhide but will need build root overrides for the > stable releases. > Please check the build log to confirm if this is the case :) > > More information here: > https://fedoraproject.org/wiki/Package_update_HOWTO#Updating_inter- > dependent_packages Yes packages(grabbit & duecredit) Are missing. Will be detailed in my next review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #10 from Manas Mangaonkar (Pac23) --- (In reply to Ankur Sinha (FranciscoD) from comment #8) > (In reply to Manas Mangaonkar (Pac23) from comment #7) > > I am not a official Packager yet,this is a unofficial review. > > --- > > > > > > Mock build failed on two different machines,config error stating fc28 > > > > ERROR: Exception(/root/python-pybids-0.6.5-1.gite35ced6.fc29.src.rpm) > > Config(fedora-28-x86_64) > > Manas, I'm afraid that's not sufficient to be called a review. You must at > least investigate the build logs and point out what the error is. > > > In this case, I can guess what it is. it is that duecredit and grabbit are > in testing and therefore not present in the stable repos. So, the package > will build correctly in rawhide but will need build root overrides for the > stable releases. > Please check the build log to confirm if this is the case :) > > More information here: > https://fedoraproject.org/wiki/Package_update_HOWTO#Updating_inter- > dependent_packages Yes packages(grabbit & duecredit) Are missing. Will be detailed in my next review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #11 from Ankur Sinha (FranciscoD) --- Great. Please post when you've done a full review (and make a note of it so that we can show it to the sponsors). In the meantime, please check new packages against rawhide, not a stable release---it is not neccessary to make new packages available to stable releases. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #12 from Athmane Madjoudj --- (In reply to Marcel Plch from comment #3) <...snip...> > = SHOULD items = > > Generic: > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. Looks good, license included in the tarball. <...snip...> > [!]: Latest version is packaged. Looks good <...snip...> > [!]: %check is present and all tests pass. It's there and passes. ( check https://kojipkgs.fedoraproject.org//work/tasks/8868/30808868/build.log) <...snip...> Build OK: https://koji.fedoraproject.org/koji/taskinfo?taskID=30808867 === Result: PACKAGE APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Athmane Madjoudj changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #13 from Ankur Sinha (FranciscoD) --- Thank you for the review, Athmane. SCM requested: https://pagure.io/releng/fedora-scm-requests/issue/8802 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #14 from Ankur Sinha (FranciscoD) --- (In reply to Marcel Plch from comment #3) > Note that I am not a packager yet and this is an informal review. > - Thanks for you review too, Marcel. If I can help you become a package maintainer (assuming that's why you did the informal review), please do let me know. Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #15 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pybids -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #16 from Fedora Update System --- python-pybids-0.6.5-2.gite35ced6.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c4baca0d2f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #17 from Fedora Update System --- python-pybids-0.6.5-2.gite35ced6.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1e92147c94 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- python-pybids-0.6.5-2.gite35ced6.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1e92147c94 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #19 from Fedora Update System --- python-pybids-0.6.5-2.gite35ced6.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c4baca0d2f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-11-21 21:22:27 --- Comment #20 from Fedora Update System --- python-pybids-0.6.5-2.gite35ced6.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #21 from Fedora Update System --- python-pybids-0.6.5-2.gite35ced6.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067
Marcel Plch changed:
What|Removed |Added
CC||mp...@redhat.com
--- Comment #3 from Marcel Plch ---
Note that I am not a packager yet and this is an informal review.
-
There already is version 0.6.3 released, could you update this package?
The rest is probably mentioned by Athmane.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "BSD (unspecified)", "Unknown or
generated". 10 files have unknown license. Detailed output of
licensecheck in /home/mplch/reviews/1534067-python-
pybids/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: python2-pybids (summary), python3-pybids (summary)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python2-pybids , python3-pybids
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include licen
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Bug 1534067 depends on bug 1538824, which changed state. Bug 1538824 Summary: Review Request: python-grabbit - Get grabby with file trees https://bugzilla.redhat.com/show_bug.cgi?id=1538824 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IAAHKSQAYQLFDYIFPT6VILSKZQ2HTQRD/
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Ankur Sinha (FranciscoD) changed: What|Removed |Added Depends On||1504375, 1280480 ||(python-duecredit) --- Comment #4 from Ankur Sinha (FranciscoD) --- Thanks for the review! I've updated the package: - https://ankursinha.fedorapeople.org/python-pybids/python-pybids.spec - https://ankursinha.fedorapeople.org/python-pybids/python-pybids-0.6.3-1.fc28.src.rpm The tests depend on duecredit and nibabel which are not ready, so I've skipped them for the time being. Cheers! Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1280480 [Bug 1280480] Review Request: python-duecredit - Automated collection and reporting of citations for used software/methods/datasets https://bugzilla.redhat.com/show_bug.cgi?id=1504375 [Bug 1504375] python-nibabel-2.3.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7RQGI3OASV2RUFKYLV7KF6CMGLRYH2BU/
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Athmane Madjoudj changed: What|Removed |Added CC||athma...@gmail.com Assignee|nob...@fedoraproject.org|athma...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Athmane Madjoudj changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067
--- Comment #1 from Athmane Madjoudj ---
Looks good, here's few points to consider:
1. About license: it's preferable to ask upstream to include the license in the
tarball (reference the request in the spec)
2. For readability reasons, it's recommended to put one requirement per line
(Requires/BuildRequires and Recommends)
3. It seems that there's a test suite, but not included in the pypi tarball
(not a blocker)
https://github.com/INCF/pybids/tree/master/bids/grabbids/tests
To fix point 1 and 3, you may want to switch to github tarball instead of
pypi's
Source0:
https://github.com/INCF/%{srcname}/archive/%{version}/%{srcname}-%{version}.tar.gz
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #2 from Ankur Sinha (FranciscoD) --- Thanks for the review! The tests require python grabbit, so I'm afraid I'll have to package that up first. https://pypi.python.org/pypi/grabbit Doing that now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Ankur Sinha (FranciscoD) changed: What|Removed |Added Depends On||1534799 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1534799 [Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Ankur Sinha (FranciscoD) changed: What|Removed |Added Depends On|1534799 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1534799 [Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Ankur Sinha (FranciscoD) changed: What|Removed |Added Depends On||1538824 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1538824 [Bug 1538824] Review Request: python-grabbit - Get grabby with file trees -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
