[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Phil Cameron  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-24 13:25:42



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/openvswitch-ovn-kubernetes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Phil Cameron  changed:

   What|Removed |Added

   Assignee|pcame...@redhat.com |admil...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Phil Cameron  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|pcame...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159



--- Comment #4 from Phil Cameron  ---
admil...@redhat.com
Thanks for doing the review. I deleted the "ExclusiveArch" line and updated the
files. Now its on to requesting a repo...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Adam Miller  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #3 from Adam Miller  ---
ackage Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "CDDL", "CC by (v4.0)", "CC by-sa (v4.0)",
 "*No copyright* BSD (2 clause)", "Unknown or generated", "MIT/X11 (BSD
 like)", "*No copyright* Apache", "*No copyright* BSD (unspecified)",
 "*No copyright* LGPL", "*No copyright* MPL (v2.0)", "ISC", "CDDL
 (v1.0)", "MIT/X11 (BSD like) BSD (2 clause)", "MIT/X11 (BSD like) BSD
 (3 clause)", "BSD (3 clause)", "BSD (2 clause)", "GPL (v3)", "LGPL
 (v3)", "*No copyright* Apache (v2.0)". 5278 files have unknown
 license. Detailed output of licensecheck in
 /home/admiller/reviews/1536159-openvswitch-ovn-
 kubernetes/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/openvswitch
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 51200 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream 

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159



--- Comment #2 from Phil Cameron  ---
RE comment #1
I have access to x86_64 and that is were the work was done. This connects
Openshift/kubernetes and OVN so it will be supported on all common
environments.
I will delete the "ExclusiveArch" line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Why is there "ExclusiveArch: x86_64"? Should this be restricted to all
Golang-supported arches?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Phil Cameron  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |opwnvswitch-ovn-kubernetes  |openvswitch-ovn-kubernetes
   |- Wedge between kubernetes  |- Wedge between kubernetes
   |and OVN |and OVN



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org