[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990

Dan Horák  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||openssl-ibmpkcs11-1.0.1-2.f
   ||c28
 Resolution|--- |RAWHIDE
Last Closed||2018-01-30 11:29:51



--- Comment #9 from Dan Horák  ---
Thanks for the review, imported and built.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/openssl-ibmpkcs11. You may commit to the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #7 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990



--- Comment #6 from Dan Horák  ---
Updated spec URL: http://fedora.danny.cz/openssl-ibmpkcs11.spec
Updated SRPM URL: http://fedora.danny.cz/openssl-ibmpkcs11-1.0.1-2.fc27.src.rpm

Changes:
- apply upstreamed fix for autotools
- don't hard-code %%enginesdir
- use simpler Source URL

The opencryptoki library is dlopen()-ed, so the rpmlint complaint bellow is not
valid. But I changed that to "R: opencryptoki-libs%{?_isa}" to be multilib
safe.
openssl-ibmpkcs11.x86_64: E: explicit-lib-dependency opencryptoki-libs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990



--- Comment #5 from Robert-André Mauchin  ---
Done: https://github.com/opencryptoki/openssl-ibmpkcs11/pull/10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990



--- Comment #4 from Dan Horák  ---
Thanks for the review, could you submit a PR for the autotools fix at
https://github.com/opencryptoki/openssl-ibmpkcs11 ? They are handled promptly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #3 from Robert-André Mauchin  ---
 - Nitpick, use this simplified Source0:

Source0:   
https://github.com/opencryptoki/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz

 - Package use an obsolete M4 macro, patch it out:

AutoTools: Obsoleted m4s found
--
  AC_PROG_LIBTOOL found in: openssl-ibmpkcs11-1.0.1/configure.ac:45


   Here's a patch for it:

diff -up openssl-ibmpkcs11-1.0.1/configure.ac.fix_obsolete_m4s
openssl-ibmpkcs11-1.0.1/configure.ac
--- openssl-ibmpkcs11-1.0.1/configure.ac.fix_obsolete_m4s2017-12-08
17:01:52.0 +0100
+++ openssl-ibmpkcs11-1.0.1/configure.ac2018-01-23 14:40:26.962655055 +0100
@@ -42,7 +42,7 @@ AC_CHECK_LIB(crypto, RAND_add, [], \

 AC_DISABLE_STATIC
 AC_PROG_CC
-AC_PROG_LIBTOOL
+LT_INIT

 CFLAGS="$CFLAGS -Wall -DLINUX -DOPENCRYPTOKI"
 AC_SUBST(CFLAGS)



==
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "*No copyright* NTP", "Unknown or generated".
 16 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/openssl-ibmpkcs11/review-openssl-
 ibmpkcs11/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec 

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990



--- Comment #2 from IBM Bug Proxy  ---
any update here?
This should really make Fedora 19 ... to make RHEL xx based on F19
Thx in advance

*** Bug 139187 has been marked as a duplicate of this bug. ***

--- Comment From ebarre...@br.ibm.com 2017-01-31 06:38 EDT---
Hi Dan and Hans-Georg,

the openssl-ibmpkcs11 is since last semester under my responsibility as well as
opencryptoki.

I'm working on make it stable, whenever I have a break from opencryptoki, as
there are many issues on it.

I was not aware of this Fedora requirement and I will make sure as soon as it
gets stable that I will implement it.

I don't have a specific date yet for this to be done.

If you need more information or requests just let me know.

Thanks,
Eduardo

--- Comment From m...@de.ibm.com 2017-12-11 06:03 EDT---
There is a new version of  OpenSSL-ibmpkcs11 available upstream
You can easily grab this release in tarball format on Github:
https://github.com/opencryptoki/openssl-ibmpkcs11/archive/v1.0.1.tar.gz

Please integrate into Fedora

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990

Dan Horák  changed:

   What|Removed |Added

 Blocks||1525184



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990

Dan Horák  changed:

   What|Removed |Added

 Blocks||467765 (ZedoraTracker)
 CC||k...@linux.vnet.ibm.com



--- Comment #1 from Dan Horák  ---
*** Bug 794793 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=467765
[Bug 467765] Fedora for System z (s390): Bug Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org