[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-08-30 00:53:26



--- Comment #30 from Fedora Update System  ---
moby-engine-18.06.0-1.ce.git0ffa825.fc28 has been pushed to the Fedora 28
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #29 from Scott McCarty  ---
Will the versioning track the Docker CE version closely so that people
understand what this is?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VELKGP7EVHSAJ2XL3SF5I7YUJEFJLH55/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Scott McCarty  changed:

   What|Removed |Added

 CC||smcca...@redhat.com



--- Comment #28 from Scott McCarty  ---
Will people be able to type "yum install docker" "systemctl enable docker" and
"docker run -it fedora bash" with this package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/EN5DHIOLWPLNXFRVZ3EV5QE4XUHQHB5G/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #27 from Fedora Update System  ---
moby-engine-18.06.0-1.ce.git0ffa825.fc28 has been pushed to the Fedora 28
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-a37148fc00

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WUIRXNTIP2N7H4YYNP5F7I6CGKBUWNQN/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #26 from Lokesh Mandvekar  ---
I noticed the reviewed version didn't work well on Fedora :\ . So, I kept the
binary locations and unitfile similar to what docker-ce upstream  rpm provides
for now.

I'll check on using fedora's packaged containerd instead of bundled containerd
in future builds.

I undid the symlinks to "moby" for now, best to wait until we hear from
upstream.

Let me know how this works..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5NCD6RZCJUBRS7546UV3PK2ZMHEM3XQQ/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #25 from Fedora Update System  ---
moby-engine-18.06.0-1.ce.git0ffa825.fc28 has been submitted as an update to
Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a37148fc00

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7BIHKMCZPCU7O426ONR5VLKEW6EAL353/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/EPZKWW747JVQ3ZXWMD7RQY6KGRDOLDHS/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #24 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/moby-engine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/TZNU7EW5KC55W5RF4QULXCBKSYD6IKBW/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #23 from Lokesh Mandvekar  ---
(In reply to Neal Gompa from comment #22)
> Since the review has already been done, I'll do it...

Thanks Neal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/P7UFWSUENK5IBHICFCV76Z4BFURRQRG4/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/PLAJBIMAQFOJ6ZTA4C44WJAUIMXC6UWB/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Neal Gompa  changed:

   What|Removed |Added

   Assignee|fkluk...@redhat.com |ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2KZID7CALE4AOC5MUM35ZSKCWYV3LMG7/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |



--- Comment #22 from Neal Gompa  ---
Since the review has already been done, I'll do it...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/Z5GEZ65JEQHUZ7BRFFAIWVROHBHUTZQP/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Lokesh Mandvekar  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



--- Comment #21 from Lokesh Mandvekar  ---
Frantisek, can you set the fedora-review+ again? Since, the review was 60 days
ago, fedpkg request-repo refuses to work.

Thanks,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/W34V3DYSNTGX3G5V62KENC5R3RAMVU4C/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com



--- Comment #20 from Neal Gompa  ---
Can we please have an updated docker package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VEX4IZZQME3BLWM24FOWYVS3KIQA4DB7/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #19 from Daniel Walsh  ---
Sadly this is an option that podman does not have either.  Will add it to the
todo list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CW4HVWGMDFJBNR4WMDIRBXTZFMHTYMTI/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #18 from Brian J. Murrell  ---
The --mount option for docker run since "-v" cannot handle paths with : in
them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/Q6PT3SCU2FT7UVJ7MEZCW3MANTMV4NYW/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #17 from Daniel Walsh  ---
What features are you looking for?  Have you checked out podman?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VNL63PZY2ROZ4KQP4KI7NH5ZAYGPQGQB/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Brian J. Murrell  changed:

   What|Removed |Added

 CC||br...@interlinx.bc.ca



--- Comment #16 from Brian J. Murrell  ---
Any progress here in the last couple of months?  The docker package in F28 is
getting long-in-the-tooth.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/S56AABOVDVFKX7OM7T5D3ORBSQX2DGAQ/

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Frantisek Kluknavsky  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #15 from Frantisek Kluknavsky  ---
The statically linked binary is needed to run inside a container with unknown
content.
Other warnings seem quite minor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Lokesh Mandvekar  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1514841



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #14 from Lokesh Mandvekar  ---
fixed some rpmlint errors. Currently I see: 

 $ rpmlint moby-engine.spec RPMS/x86_64/*
SRPMS/moby-engine-17.03.2-4.ce.gitf5ec1e2.fc28.src.rpm 
moby-engine.x86_64: E: statically-linked-binary
/usr/libexec/moby-engine/moby-init
moby-engine.x86_64: W: manual-page-warning /usr/share/man/man1/moby-run.1.gz
1125: warning: macro `You' not defined
moby-engine.x86_64: W: no-manual-page-for-binary docker
moby-engine.x86_64: W: no-manual-page-for-binary moby-engine
moby-engine-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
moby-engine-debugsource.x86_64: W: no-documentation
moby-engine-fish-completion.x86_64: W: no-documentation
moby-engine-nano.x86_64: W: summary-not-capitalized C nano syntax highlighting
files for Moby
moby-engine-nano.x86_64: W: no-documentation
moby-engine-vim.x86_64: W: no-documentation
moby-engine-zsh-completion.x86_64: W: no-documentation
8 packages and 1 specfiles checked; 2 errors, 9 warnings.


Spec URL: https://pagure.io/moby-engine/blob/master/f/moby-engine.spec
SRPM URL:
https://pagure.io/moby-engine/blob/master/f/SRPMS/moby-engine-17.03.2-4.ce.gitf5ec1e2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #13 from Frantisek Kluknavsky  ---
incoherent-version-in-changelog is a false positive (Am I missing a difference?
The scanner seems confused by .ce suffix.)
udev-rule-in-etc - pull request created
non-conffile-in-etc - goes away with the udev rule
non-executable-script - bash completions are non-executable on purpose
manual-page-warning - should probably be fixed upstream
no-manual-page-for-binary docker - true, but judging by the content of the man
pages, they need bigger changes than just a symlink.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #12 from Frantisek Kluknavsky  ---
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.

file /usr/libexec/moby-engine is not owned by any package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #11 from Frantisek Kluknavsky  ---
rpmlint *.rpm
moby-engine.x86_64: W: incoherent-version-in-changelog 17.03.2-3.ce
['17.03.2-3.ce.gitf5ec1e2.fc26', '17.03.2-3.ce.gitf5ec1e2']
moby-engine.x86_64: E: statically-linked-binary
/usr/libexec/moby-engine/moby-init
moby-engine.x86_64: W: udev-rule-in-etc /etc/udev/rules.d/80-moby.rules
moby-engine.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/80-moby.rules
moby-engine.x86_64: E: wrong-script-interpreter
/usr/share/bash-completion/completions/moby /usr/bin/env bash
moby-engine.x86_64: E: non-executable-script
/usr/share/bash-completion/completions/moby 644 /usr/bin/env bash
moby-engine.x86_64: W: manual-page-warning /usr/share/man/man1/moby-run.1.gz
1125: warning: macro `You' not defined
moby-engine.x86_64: W: no-manual-page-for-binary docker
moby-engine.x86_64: W: no-manual-page-for-binary moby-engine
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/armon/go-metrics/metrics.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/armon/go-metrics/sink.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/armon/go-metrics/start.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/armon/go-metrics/statsite.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/asn1/asn1.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/asn1/common.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/asn1/marshal.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/cert_pool.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/pem_decrypt.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/pkcs1.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/pkix/pkix.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/root.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/root_unix.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/verify.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/google/certificate-transparency/go/x509/x509.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/pborman/uuid/dce.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/pborman/uuid/node.go
moby-engine-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/moby-f5ec1e2936dcbe7b5001c2b817188b095c700c27/_build/src/github.com/docker/docker/vendor/github.com/pborman/uuid/time.go
moby-engine-fish-completion.x86_64: W: summary-not-capitalized C fish
completion files for Docker
moby-engine-fish-completion.x86_64: W: no-documentation
moby-engine-nano.x86_64: W: summary-not-capitalized C nano syntax highlighting
files for 

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #10 from Lokesh Mandvekar  ---
SRPM URL:
https://pagure.io/moby-engine/blob/master/f/SRPMS/moby-engine-17.03.2-3.ce.gitf5ec1e2.fc27.src.rpm

docker-* are symlinks to moby-* in this build.

Spec location is the same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Lokesh Mandvekar  changed:

   What|Removed |Added

  Comment #7 is|1   |0
private||



--- Comment #9 from Lokesh Mandvekar  ---
(In reply to Daniel Walsh from comment #7)
> We also want to get some of our patches merged into this package.  We should
> be packaging up projectatomic/moby not moby/moby

Sure, that can be done once we have projectatomic/moby ready with the patches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #8 from Lokesh Mandvekar  ---
RE: binary renames, I'll include docker-* as symlinks to the moby-* binaries.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #5 from Daniel Walsh  ---
Seems like the rename process has sore o hung

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #6 from Daniel Walsh  ---
sort of hung

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #4 from Daniel Walsh  ---
I am fine with using the same storage until moby changes the default.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #3 from Lokesh Mandvekar  ---
Spec URL: https://pagure.io/moby-engine/raw/master/f/moby-engine.spec
SRPM URL:
https://pagure.io/moby-engine/blob/master/f/SRPMS/moby-engine-17.03.2-2.ce.gitf5ec1e2.fc27.src.rpm

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=25221033

binaries renamed:

docker -> moby
dockerd -> moby-engine
docker-containerd -> moby-containerd
docker-containerd-ctr -> moby-containerd-ctr
docker-containerd-shim -> moby-containerd-shim
docker-init -> moby-init
docker-proxy -> moby-proxy
docker-runc -> moby-runc

RE: container storage, it uses /var/lib/docker which would be the same as that
for the docker package. I'd just like to make sure common dir wouldn't cause
problems ahead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Lokesh Mandvekar  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1545820



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #2 from Carl George  ---
I came across this today.

https://github.com/moby/moby/pull/34226

I think it's worth considering starting this package with those binary names to
avoid having to change them later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Carl George  changed:

   What|Removed |Added

 CC||carl@george.computer



--- Comment #1 from Carl George  ---
Source3 in this spec file is containerd.  containerd is already packaged for
Fedora, and provides the commands containerd, containerd-shim, and ctr.  Based
on my current understanding of this brave new Moby world, Source3 and relevant
sections can be dropped and instead just require containerd.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Lokesh Mandvekar  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1492331



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Lokesh Mandvekar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||bbre...@redhat.com,
   ||dwa...@redhat.com,
   ||jho...@redhat.com,
   ||j...@redhat.com
   Assignee|nob...@fedoraproject.org|fkluk...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org