[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 Fabian Affolter changed: What|Removed |Added Resolution|WONTFIX |DUPLICATE --- Comment #15 from Fabian Affolter --- *** This bug has been marked as a duplicate of bug 1820915 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 Germano Massullo changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2018-11-18 16:45:20 --- Comment #14 from Germano Massullo --- It is not possible to package Bettercap due the amount of libraries that need to be packaged -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 Fabian Affolterchanged: What|Removed |Added CC||m...@fabian-affolter.ch Blocks||563471 (FE-SECLAB) Alias||bettercap Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #13 from Germano Massullo--- I will submit review requests for missing libraries github.com/elazarl/goproxy github.com/gin-gonic/gin github.com/gin-gonic/gin/binding github.com/google/gopacket github.com/google/gopacket/layers github.com/google/gopacket/pcap github.com/google/gopacket/pcapgo github.com/inconshreveable/go-vhost github.com/malfunkt/iprange github.com/mdlayher/dhcp6 github.com/mdlayher/dhcp6/dhcp6opts -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #12 from Robert-André Mauchin--- Also note that these dependencies may have their own dependencies as well, in other words, lots of work ahead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #11 from Robert-André Mauchin--- (In reply to Germano Massullo from comment #6) > > Done, but I still obtain some errors > > main.go:7:2: cannot find package "github.com/evilsocket/bettercap-ng/core" > in any of: > /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/core (from > $GOROOT) > > /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/ > _build/src/github.com/evilsocket/bettercap-ng/core (from $GOPATH) > /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/core > main.go:8:2: cannot find package "github.com/evilsocket/bettercap-ng/log" in > any of: > /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/log (from > $GOROOT) > > /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/ > _build/src/github.com/evilsocket/bettercap-ng/log (from $GOPATH) > /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/log > main.go:9:2: cannot find package > "github.com/evilsocket/bettercap-ng/modules" in any of: > /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/modules (from > $GOROOT) > > /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/ > _build/src/github.com/evilsocket/bettercap-ng/modules (from $GOPATH) > /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/modules > main.go:10:2: cannot find package > "github.com/evilsocket/bettercap-ng/session" in any of: > /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/session (from > $GOROOT) > > /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/ > _build/src/github.com/evilsocket/bettercap-ng/session (from $GOPATH) > /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/session You did not fix the header as I said so it doesn't work: >Your Gopath is probably fcked up. Yes I see, fix your header: %global providergithub %global provider_tldcom %global project evilsocket %global repo bettercap-ng %global provider_prefix %{provider}.%{provider_tld}/%{project} Once you do that you'll see that you are missing plenty of dependencies because you haven't done your job beforehand: + go build -buildmode pie -compiler gc -tags=rpm_crashtraceback -ldflags ' -B 0x45265e550377a69ca63e577f452392918e5720c2 -extldflags '\''-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\''' -a -v -x -o bettercap . WORK=/tmp/go-build248343626 _build/src/github.com/evilsocket/bettercap-ng/session/command_handler.go:4:2: cannot find package "github.com/chzyer/readline" in any of: /usr/lib/golang/src/github.com/chzyer/readline (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/chzyer/readline (from $GOPATH) /usr/share/gocode/src/github.com/chzyer/readline _build/src/github.com/evilsocket/bettercap-ng/session/prompt.go:10:2: cannot find package "github.com/dustin/go-humanize" in any of: /usr/lib/golang/src/github.com/dustin/go-humanize (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/dustin/go-humanize (from $GOPATH) /usr/share/gocode/src/github.com/dustin/go-humanize _build/src/github.com/evilsocket/bettercap-ng/modules/http_proxy_base.go:24:2: cannot find package "github.com/elazarl/goproxy" in any of: /usr/lib/golang/src/github.com/elazarl/goproxy (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/elazarl/goproxy (from $GOPATH) /usr/share/gocode/src/github.com/elazarl/goproxy _build/src/github.com/evilsocket/bettercap-ng/modules/api_rest.go:14:2: cannot find package "github.com/gin-gonic/gin" in any of: /usr/lib/golang/src/github.com/gin-gonic/gin (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/gin-gonic/gin (from $GOPATH) /usr/share/gocode/src/github.com/gin-gonic/gin _build/src/github.com/evilsocket/bettercap-ng/modules/api_rest_utils.go:8:2: cannot find package "github.com/gin-gonic/gin/binding" in any of: /usr/lib/golang/src/github.com/gin-gonic/gin/binding (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/gin-gonic/gin/binding (from $GOPATH) /usr/share/gocode/src/github.com/gin-gonic/gin/binding _build/src/github.com/evilsocket/bettercap-ng/packets/dhcp6_layer.go:4:2: cannot find package "github.com/google/gopacket" in any of: /usr/lib/golang/src/github.com/google/gopacket (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/google/gopacket (from $GOPATH) /usr/share/gocode/src/github.com/google/gopacket _build/src/github.com/evilsocket/bettercap-ng/packets/arp.go:6:2: cannot find package
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #10 from Germano Massullo--- bettercap 2.0.0 will be released on 28 February 2018 https://github.com/evilsocket/bettercap-ng/milestones -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #9 from Germano Massullo--- (In reply to Robert-André Mauchin from comment #8) > Emphasis on will. Thit isn't yet bettercap 2.0, it will be in the future. I > also question the pertinence of packaging it right now instead of waiting > for the merge with bettercap. For the moment we do the package review and start a master branch. When bettercap will be released I will make a bodhi release. > When the merge happens, we will have two > packages bettercap and bettercap-ng for the same thing There will not be anything to upgrade since when bettercap will be released I will make a bodhi release. The package name will be "bettercap" not "bettercap-ng", so there will be no problem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #8 from Robert-André Mauchin--- > bettercap-ng *will* be merged into the bettercap original repository, commits > history preserved and this repo deleted, these are the steps to take in order > to release it as version 2.0.0 of bettercap. Emphasis on will. Thit isn't yet bettercap 2.0, it will be in the future. I also question the pertinence of packaging it right now instead of waiting for the merge with bettercap. When the merge happens, we will have two packages bettercap and bettercap-ng for the same thing, and we will have to provide an upgrade path for one to the other. It really depends if you need this now, it seems to still be in an alpha state. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #7 from Germano Massullo--- (In reply to Robert-André Mauchin from comment #4) > - go-bindata only provides a binary, not a library, and only the binary is > needed for your package. See https://src.fedoraproject.org/rpms/go-bindata > >So just replace golang(github.com/jteeuwen/go-bindata) with "go-bindata" > >I'm not even sure you even need it since it's only used in the make > script that you don't use anyway. It seems to be used only by the developer. > It's safe to remove imho. Upstream confirmed that go-bindata is not necessary -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #6 from Germano Massullo--- https://germano.fedorapeople.org/package_reviews/bettercap/rev2/bettercap.spec https://germano.fedorapeople.org/package_reviews/bettercap/rev2/bettercap-2.0.0-0.1.fc27.src.rpm (In reply to Robert-André Mauchin from comment #4) > - go-bindata only provides a binary, not a library, and only the binary is > needed for your package. See https://src.fedoraproject.org/rpms/go-bindata > >So just replace golang(github.com/jteeuwen/go-bindata) with "go-bindata" > >I'm not even sure you even need it since it's only used in the make > script that you don't use anyway. It seems to be used only by the developer. > It's safe to remove imho. I am going to ask upstream > - Where did you get your Version:2.0.0 from? > > According to > https://github.com/evilsocket/bettercap-ng/blob/master/core/banner.go the > latest version is 0.9. (In reply to Germano Massullo from comment #0) > [...] > Note: > - bettercap-ng was the original project name, that has been changed today > into bettercap 2.0, more infos at > https://github.com/evilsocket/bettercap-ng/issues/35 > > - This import path seems dubious: > > %global import_path code.google.com/p/go.net > > It's not needed for packaging a binary anyway. Done > > - This: > > %doc > README.md > > %license > LICENSE.md > >should be inline, they are not new sections of the SPEC: > > %files > %doc README.md > %license LICENSE.md > %{_bindir}/%{name} Done >Then fix %build: > > %build > mkdir -p ./_build/src/%{provider}.%{provider_tld}/%{project} > ln -s $(pwd) ./_build/src/%{provider}.%{provider_tld}/%{project}/%{repo} > export GOPATH=$(pwd)/_build:%{gopath} > > %gobuild -o %{name} . Done, but I still obtain some errors main.go:7:2: cannot find package "github.com/evilsocket/bettercap-ng/core" in any of: /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/core (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/core (from $GOPATH) /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/core main.go:8:2: cannot find package "github.com/evilsocket/bettercap-ng/log" in any of: /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/log (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/log (from $GOPATH) /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/log main.go:9:2: cannot find package "github.com/evilsocket/bettercap-ng/modules" in any of: /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/modules (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/modules (from $GOPATH) /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/modules main.go:10:2: cannot find package "github.com/evilsocket/bettercap-ng/session" in any of: /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/session (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/session (from $GOPATH) /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/session -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #5 from Robert-André Mauchin--- (In reply to Germano Massullo from comment #3) > https://germano.fedorapeople.org/package_reviews/bettercap/rev1/bettercap. > spec > https://germano.fedorapeople.org/package_reviews/bettercap/rev1/bettercap-2. > 0.0-0.1.fc27.src.rpm > > > I have changed > > BuildRequires: golang(github.com/jteeuwen/go-bindata) > to > BuildRequires: go-bindata > > and > %setup -q -n %{name}-%{gittag} > to > %setup -q -n bettercap-ng-%{commit} > > now mock returns errors > > > > > main.go:7:2: cannot find package "github.com/evilsocket/bettercap-ng/core" > in any of: > /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/core (from > $GOROOT) > > /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/ > _build/src/github.com/evilsocket/bettercap-ng/core (from $GOPATH) > /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/core > main.go:8:2: cannot find package "github.com/evilsocket/bettercap-ng/log" in > any of: > /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/log (from > $GOROOT) > > /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/ > _build/src/github.com/evilsocket/bettercap-ng/log (from $GOPATH) > /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/log > main.go:9:2: cannot find package > "github.com/evilsocket/bettercap-ng/modules" in any of: > /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/modules (from > $GOROOT) > > /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/ > _build/src/github.com/evilsocket/bettercap-ng/modules (from $GOPATH) > /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/modules > main.go:10:2: cannot find package > "github.com/evilsocket/bettercap-ng/session" in any of: > /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/session (from > $GOROOT) > > /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/ > _build/src/github.com/evilsocket/bettercap-ng/session (from $GOPATH) > /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/session Your Gopath is probably fcked up. Yes I see, fix your header: %global providergithub %global provider_tldcom %global project evilsocket %global repo bettercap-ng %global provider_prefix %{provider}.%{provider_tld}/%{project} Then fix %build: %build mkdir -p ./_build/src/%{provider}.%{provider_tld}/%{project} ln -s $(pwd) ./_build/src/%{provider}.%{provider_tld}/%{project}/%{repo} export GOPATH=$(pwd)/_build:%{gopath} %gobuild -o %{name} . -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #4 from Robert-André Mauchin--- - go-bindata only provides a binary, not a library, and only the binary is needed for your package. See https://src.fedoraproject.org/rpms/go-bindata So just replace golang(github.com/jteeuwen/go-bindata) with "go-bindata" I'm not even sure you even need it since it's only used in the make script that you don't use anyway. It seems to be used only by the developer. It's safe to remove imho. - Where did you get your Version:2.0.0 from? According to https://github.com/evilsocket/bettercap-ng/blob/master/core/banner.go the latest version is 0.9. You should ask upstream to tag its release, it would be easier for packaging. - This import path seems dubious: %global import_path code.google.com/p/go.net It's not needed for packaging a binary anyway. - This: %doc README.md %license LICENSE.md should be inline, they are not new sections of the SPEC: %files %doc README.md %license LICENSE.md %{_bindir}/%{name} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #3 from Germano Massullo--- https://germano.fedorapeople.org/package_reviews/bettercap/rev1/bettercap.spec https://germano.fedorapeople.org/package_reviews/bettercap/rev1/bettercap-2.0.0-0.1.fc27.src.rpm I have changed BuildRequires: golang(github.com/jteeuwen/go-bindata) to BuildRequires: go-bindata and %setup -q -n %{name}-%{gittag} to %setup -q -n bettercap-ng-%{commit} now mock returns errors main.go:7:2: cannot find package "github.com/evilsocket/bettercap-ng/core" in any of: /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/core (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/core (from $GOPATH) /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/core main.go:8:2: cannot find package "github.com/evilsocket/bettercap-ng/log" in any of: /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/log (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/log (from $GOPATH) /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/log main.go:9:2: cannot find package "github.com/evilsocket/bettercap-ng/modules" in any of: /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/modules (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/modules (from $GOPATH) /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/modules main.go:10:2: cannot find package "github.com/evilsocket/bettercap-ng/session" in any of: /usr/lib/golang/src/github.com/evilsocket/bettercap-ng/session (from $GOROOT) /builddir/build/BUILD/bettercap-ng-eb1a53efa3171aefed0ec9766d8c5047bd0df289/_build/src/github.com/evilsocket/bettercap-ng/session (from $GOPATH) /usr/share/gocode/src/github.com/evilsocket/bettercap-ng/session -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 --- Comment #2 from Germano Massullo--- (In reply to Robert-André Mauchin from comment #1) > - You should link directly to the RAW SPEC and provide a SRPM too https://germano.fedorapeople.org/package_reviews/bettercap/bettercap.spec https://germano.fedorapeople.org/package_reviews/bettercap/bettercap-2.0.0-0.1.fc27.src.rpm > - This SPEC file has an empty Source0 so I can't do anything with it. Done > - LICENSE.md is not installed in %files, nor is README.md with %doc LICENSE.md has been placed under %license README.md has been placed under %doc > - %changelog is empty Done > - It's "compiler(go-compiler)" with no "s" at compiler Thank you, it was a typo into https://fedoraproject.org/wiki/PackagingDrafts/Go#Go_Language_Architectures which I just corrected During mock process, I obtain error message No matching package to install: 'golang(github.com/jteeuwen/go-bindata)' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540726] Review request: bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1540726 Robert-André Mauchinchanged: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- - You should link directly to the RAW SPEC and provide a SRPM too - This SPEC file has an empty Source0 so I can't do anything with it. - LICENSE.md is not installed in %files, nor is README.md with %doc - %changelog is empty - It's "compiler(go-compiler)" with no "s" at compiler You should try to build the package in mock first before posting a Review request with half-assed SPEC. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org