[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 --- Comment #13 from Fedora Update System --- patool-1.12-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:38:31 --- Comment #12 from Fedora Update System --- patool-1.12-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 --- Comment #11 from Fedora Update System --- patool-1.12-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-3a91b279e2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- patool-1.12-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-aabb305a90 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 --- Comment #9 from Fedora Update System --- patool-1.12-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-aabb305a90 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 --- Comment #8 from Fedora Update System --- patool-1.12-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-3a91b279e2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 --- Comment #7 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/patool. You may commit to the branch "f27" in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|POST Flags||fedora-review+ --- Comment #6 from Zbigniew Jędrzejewski-Szmek --- + package name is OK + license is acceptable for Fedora (GPLv3+) + license is specified correctly + builds and installs OK + Requires/BuildRequires/Provides/Recommends look good + fedora-review finds no important issues + tests are present and pass Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 --- Comment #5 from Robert-André Mauchin --- Spec URL: https://github.com/eclipseo/packaging/blob/7f99098/patool.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/patool/fedora-rawhide-x86_64/00711629-patool/patool-1.12-1.fc28.src.rpm SPEC diff: https://github.com/eclipseo/packaging/commit/7f99098c0c1efbfbc8ab5cba59927288038caa1b#diff-978fea9b8642e77c470ed419b5f34bfd I patched the test of Zopfli: it was testing decompression which the zopfli binary doesn't do. It now tests the compression. The other errors were related to Star: the program assumed the arguments were the same as "tar" but in fact they are slightly different for verbosity and compress-type. I rewrote this portion and now tests are successful. Thanks again for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- Created attachment 1392508 --> https://bugzilla.redhat.com/attachment.cgi?id=1392508&action=edit pytest-2 output when reqs are installed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646
--- Comment #3 from Zbigniew Jędrzejewski-Szmek ---
> File "/usr/lib/python3.6/site-packages/patoolib/configuration.py", line 5, in
>
>import _patool_configdata as configdata
Yeah, that'd require changing the code…
Other packages you quote don't installl *private* modules. Top-level
single-file modules are OK, it's just the ones that start with "_" that bother
me. Anyway, that's an RFE, not something that matters for package review.
> %{__install}
There's no benefit over using plain "install".
pytest-{2,3} should be called -v so that the tests are listed.
I'm not sure about the Recommends: some of those binaries are not available in
Fedora. Not sure what dnf does in that case, but it'll at least warn. You might
want to comment those out until they are available.
If all those binaries are available in the build environment, tests fail, see
attached file. You should add whatever as much as possible to BR and then fix
the tests or filter them out.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646
--- Comment #2 from Robert-André Mauchin ---
> %{python2_sitelib}/_patool_configdata.*
This is really an upstream issue, but a package should never ever install
private modules into the top-level namespace. Maybe you can talk with upstream
to move it underneath patoollib/ ?
Wouldn't work currently:
File "/usr/lib/python3.6/site-packages/patoolib/configuration.py", line 5, in
import _patool_configdata as configdata
I doubt I'll manage to get upstream to change this as the GIT repo and issue
tracker haven't bulge for 2 years now.
There's also a handful of top-level packages that already exist:
$ ll /usr/lib/python3.6/site-packages/*.py
-rw-r--r--. 1 root root 24K août 31 2014
/usr/lib/python3.6/site-packages/augeas.py
-rw-r--r--. 1 root root 16K févr. 16 2016
/usr/lib/python3.6/site-packages/cycler.py
-rw-r--r--. 1 root root 16K janv. 15 2017
/usr/lib/python3.6/site-packages/decorator.py
-rw-r--r--. 1 root root 39K déc. 24 17:29
/usr/lib/python3.6/site-packages/distro.py
-rw-r--r--. 1 root root 126 nov. 28 16:47
/usr/lib/python3.6/site-packages/easy_install.py
-rw-r--r--. 1 root root 19K juil. 26 2017
/usr/lib/python3.6/site-packages/git_archive_all.py
-rw-r--r--. 1 root root 59K avril 1 2013
/usr/lib/python3.6/site-packages/IPy.py
-rw-r--r--. 1 root root 75K nov. 9 10:24
/usr/lib/python3.6/site-packages/langtable.py
-rw-r--r--. 1 root root 8,2K avril 4 2017
/usr/lib/python3.6/site-packages/magic.py
-rw-r--r--. 1 root root 14K juil. 27 2015
/usr/lib/python3.6/site-packages/ntplib.py
-rw-r--r--. 1 root root 1,1K janv. 6 2017
/usr/lib/python3.6/site-packages/OleFileIO_PL.py
-rw-r--r--. 1 root root 6,2K déc. 15 2015
/usr/lib/python3.6/site-packages/ordered_set.py
-rw-r--r--. 1 root root 87K juin 4 2015
/usr/lib/python3.6/site-packages/pyinotify.py
-rw-r--r--. 1 root root 225K juil. 28 2017
/usr/lib/python3.6/site-packages/pyparsing.py
-rw-r--r--. 1 root root 4,4K août 24 2015
/usr/lib/python3.6/site-packages/requests_file.py
-rw-r--r--. 1 root root 118K juil. 28 2017
/usr/lib/python3.6/site-packages/sh.py
-rw-r--r--. 1 root root 31K sept. 19 15:47
/usr/lib/python3.6/site-packages/six.py
-rw-r--r--. 1 root root 2,9K mars 28 2015
/usr/lib/python3.6/site-packages/sockshandler.py
-rw-r--r--. 1 root root 32K mars 23 2017
/usr/lib/python3.6/site-packages/socks.py
-rw-r--r--. 1 root root 5,0K janv. 13 2011
/usr/lib/python3.6/site-packages/termcolor.py
-rw-r--r--. 1 root root 9,7K déc. 8 16:02
/usr/lib/python3.6/site-packages/tldr.py
I could patch it I guess.
>> %{_datadir}/bash-completion/completions/patool.bash-completion
>This should be called just 'patool', without the extension.
Done.
> Shouldn't this package have Recommends on various tools for all the
> non-natively-supported formats?
Yes I forgot about this.
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/7bf94ea/patool.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/patool/fedora-rawhide-x86_64/00711233-patool/patool-1.12-1.fc28.src.rpm
SPEC diff:
https://github.com/eclipseo/packaging/commit/7bf94eab8915ea4021e01df12059e4aa4e1da804#diff-978fea9b8642e77c470ed419b5f34bfd
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
> %{_datadir}/bash-completion/completions/patool.bash-completion
This should be called just 'patool', without the extension.
> %{python2_sitelib}/_patool_configdata.*
This is really an upstream issue, but a package should never ever install
private modules into the top-level namespace. Maybe you can talk with upstream
to move it underneath patoollib/ ?
Shouldn't this package have Recommends on various tools for all the
non-natively-supported formats?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
