[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/bitlbee,
/usr/share/bitlbee
You should own thses dirs:
%dir %{_libdir}/bitlbee
%dir %{_datadir}/bitlbee
[!]: Package should not use obsolete m4 macros
Note: Some obsoleted macros found, see the attachment.
AutoTools: Obsoleted m4s found
--
AC_PROG_LIBTOOL found in: bitlbee-discord-0.4.1/configure.ac:32
Replace it with LT_INIT.
See for details
https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html
Actually I've sent a patch for this upstream. Add it to your SPEC:
Patch0:
https://github.com/sm00th/bitlbee-discord/pull/135.patch#/%{name}-%{version}-remove_obsolete_m4s_macro.patch
And add -p1 to autosetup:
%autosetup -p1
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* GPL (v2 or later)", "GPL (v2 or later)",
"Unknown or generated". 2 files have unknown license. Detailed output
of licensecheck in /home/bob/packaging/review/bitlbee-discord/review-
bitlbee-discord/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/bitlbee,
/usr/share/bitlbee
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663
--- Comment #2 from Ben Rosser ---
> %dir %{_libdir}/bitlbee
> %dir %{_datadir}/bitlbee
Ah, my bad. This is because I forgot to require bitlbee (which owns these
directories), and RPM doesn't detect it automatically.
Thanks for the LT_INIT patch. I've added it and a Requires: bitlbee.
Spec URL: https://tc01.fedorapeople.org/chat/bitlbee-discord.spec
SRPM URL:
https://tc01.fedorapeople.org/chat/bitlbee-discord-0.4.1-2.fc27.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/bitlbee-discord -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663 --- Comment #5 from Fedora Update System --- bitlbee-discord-0.4.1-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e3cf77ed71 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663 --- Comment #6 from Fedora Update System --- bitlbee-discord-0.4.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-829e7a235a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- bitlbee-discord-0.4.1-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-e3cf77ed71 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663 --- Comment #8 from Fedora Update System --- bitlbee-discord-0.4.1-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-829e7a235a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-27 11:52:47 --- Comment #9 from Fedora Update System --- bitlbee-discord-0.4.1-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542663] Review Request: bitlbee-discord - Bitlbee plugin for Discord
https://bugzilla.redhat.com/show_bug.cgi?id=1542663 --- Comment #10 from Fedora Update System --- bitlbee-discord-0.4.1-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
