[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163

Honza Horak  changed:

   What|Removed |Added

 CC||hho...@redhat.com
  Flags|needinfo?(mcyprian@redhat.c |
   |om) |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #15 from Fedora Update System  ---
python-sphinx-click-1.0.4-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/EQCL35Q3SBLGLO6CG34MMA46LZPPJXDG/

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-05-23 11:38:24



--- Comment #14 from Fedora Update System  ---
python-sphinx-click-1.0.4-1.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/PDM6QN2RURVG2YBME5FNPQJ2SS3RJ75V/

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163

Miro Hrončok  changed:

   What|Removed |Added

 CC||mcypr...@redhat.com
  Flags||needinfo?(mcyprian@redhat.c
   ||om)



--- Comment #13 from Miro Hrončok  ---
This is ON_QA for 2 months now. Please push the updates.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #12 from Fedora Update System  ---
python-sphinx-click-1.0.4-1.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-7f3409174f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
python-sphinx-click-1.0.4-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0e75ce7192

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #9 from Fedora Update System  ---
python-sphinx-click-1.0.4-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-7f3409174f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #10 from Fedora Update System  ---
python-sphinx-click-1.0.4-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0e75ce7192

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-sphinx-click. You may commit to the
branch "f28" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163

Miro Hrončok  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Miro Hrončok  ---
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #6 from Michal Cyprian  ---
I haven't realized there was a comment from Robert-André before and I've read
only Miro's comment, sorry for that. All the other issues might be fixed now:

Spec URL: https://mcyprian.fedorapeople.org/python-sphinx-click.spec
SRPM URL:
https://mcyprian.fedorapeople.org/python-sphinx-click-1.0.4-1.fc27.src.rpm

The only rpmlint warning is the binary file generated by Sphinx:
/usr/share/doc/python-sphinx-click-doc/html/objects.inv

Similar file is present also in other rpm using Sphinx documentation. Is this
really an issue?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #5 from Miro Hrončok  ---
Package Review
==

Not yet approved.

As said before in comment #2, fix the description macro:

$ rpm -qip python3-sphinx-click-1.0.4-1.fc28.noarch.rpm 
...
Description :
%{sphinx_click-desc}

$ rpm -qip python-sphinx-click-1.0.4-1.fc28.src.rpm 
...
Description :
%{sphinx-click-desc}

Also, some rpmlint problems.


Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated".
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python3-sphinx-click (description)
[!]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: 

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #4 from Michal Cyprian  ---
Thank for the review Miro. I removed Python 2 subpackage, you are right that it
is not needed at least for Pipenv, I also simplified requirements definition.
Updated files: 
Spec URL: https://mcyprian.fedorapeople.org/python-sphinx-click.spec
SRPM URL:
https://mcyprian.fedorapeople.org/python-sphinx-click-1.0.4-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #3 from Miro Hrončok  ---
Is the python2 subpackage needed? Have you consider not packaging it at all?


> # Must do the default python version install last because
> # the scripts in /usr/bin are overwritten with every setup.py install.

Bogus comment, there are no scripts in /usr/bin.


We have sphinx >= 1.5, click >= 5.0 and coverage > 4.3 in all Fedoras, maybe
the dependency declarations are needlessly overcomplicated?

Also, does the automatic deps generator work here? Maybe try to use it instead
of specific requires. https://pagure.io/packaging-committee/issue/740

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #2 from Robert-André Mauchin  ---
 - There seems to be an error because of the way you named the description
macro:

warning: Macro %sphinx needs whitespace before body

   It considers %{sphinx-click-desc} to be part of a %{sphinx} macro and it
causes an error when trying to build in mock.

   Rename you macro to %{desc} for example to avoid this error.

 - License should just be "MIT":

License:MIT



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 24 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-sphinx-click/review-python-sphinx-
 click/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
 -sphinx-click , python3-sphinx-click
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and 

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163

Miro Hrončok  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mhron...@redhat.com
   Assignee|nob...@fedoraproject.org|mhron...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545163] Review Request: python-sphinx-click - Sphinx extension that automatically documents click applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545163



--- Comment #1 from Michal Cyprian  ---
SRPM was build for f27 not rawhide, updated files:

Spec URL: https://mcyprian.fedorapeople.org/python-sphinx-click.spec
SRPM URL:
https://mcyprian.fedorapeople.org/python-sphinx-click-1.0.4-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org