[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #28 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #27 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #26 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-04-14 22:34:20



--- Comment #25 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711
Bug 1559711 depends on bug 1559699, which changed state.

Bug 1559699 Summary: Review Request: libdasm - Simple x86 disassembly library
https://bugzilla.redhat.com/show_bug.cgi?id=1559699

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #24 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-42ed2dfa4e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #23 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-6e774e5bc6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #22 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-27aaee2a9c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #21 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-ad1355662c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #19 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.fc28 has been submitted as an update to
Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-42ed2dfa4e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #20 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-6e774e5bc6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #18 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-ad1355662c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #17 from Fedora Update System  ---
libemu-0.2.0-8.20130410gitab48695.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-27aaee2a9c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711

Michal Ambroz  changed:

   What|Removed |Added

  Alias|libemu  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #16 from Jason Tibbitts  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libemu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #15 from Michal Ambroz  ---
https://pagure.io/releng/fedora-scm-requests/issue/5587
https://pagure.io/releng/fedora-scm-requests/issue/5588
https://pagure.io/releng/fedora-scm-requests/issue/5589
https://pagure.io/releng/fedora-scm-requests/issue/5590
https://pagure.io/releng/fedora-scm-requests/issue/5591
https://pagure.io/releng/fedora-scm-requests/issue/5592

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #14 from Michal Ambroz  ---
Thank you Robert-Andre.

BTW just try running "rpmbuild -bp libemu.spec" then going to the build
directory and using "git status", "git log" , "git diff" , "git reset --hard
HEAD~1" commands. It is extremely usefull for the packaging workflow fiddling
with more than couple of patches / changes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #13 from Robert-André Mauchin  ---
Ok, package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #12 from Michal Ambroz  ---
Hi Robert
- I am using git the same way from prep script how it is used from the
autosetup.

It is same reason as already mentioned by Jason - I have all changes from
patches (14 is too many to fiddle without version control) auto-commited with
the autosetup -S git to be able to pinpoint the issues separately and change
individual patches.

I do some unbundling changes with scripts like removing files ... so I do the
commits at those points as well.

If "-S git" is recommended for autosetup ... why it should be problem to make
git commits from a script ... so I have got clean slate after %prep and before
%build.

Please note the git is not used for downloading stuff online or pushing to
upstream. It is simply used for having more granular atomic pin-points in the
process of patching.

Best regards
Michal Ambroz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #11 from Robert-André Mauchin  ---
I'm talking about:

git commit -q -a -m "unbundle libdasm"

git commit -q -a -m "downgrade autoconf for rhel6"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #10 from Jason Tibbitts  ---
From a package maintainer standpoint, it can be extremely useful to use
%autosetup -S git if you are applying more than a couple of patches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #9 from Robert-André Mauchin  ---
Why do you git commit stuff? This is useless. You shouln't even need git.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #8 from Michal Ambroz  ---
Hello Robert-Andre,
thankyou for review - here is the updated package:
Spec URL: http://rebus.fedorapeople.org/libemu.spec
SRPM URL:
http://rebus.fedorapeople.org/libemu-0.2.0-8.20130410gitab48695.fc27.src.rpm

- use ldconfig_scriptlets   
- fix release version number in the changelog
- fix the obsolete m4 macros
- Exclude the private libemu.so library in python sitearch dir  

- show all warnings to autoreconf   
- use autosetup+git for troubleshooting the patches

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #7 from Robert-André Mauchin  ---

 - Use the new %ldconfig_scriptlets. See
https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets#Upgrade.2Fcompatibility_impact

 - Release in the header and in the %changelog are mismatched:

libemu.x86_64: W: incoherent-version-in-changelog 0.2.0-0.7.20130410gitab48695
['0.2.0-7.20130410gitab48695.fc29', '0.2.0-7.20130410gitab48695']

 - [!]: Package should not use obsolete m4 macros
 Note: Some obsoleted macros found, see the attachment.
 See: https://fedorahosted.org/FedoraReview/wiki/AutoTools

AutoTools: Obsoleted m4s found
--
  AC_PROG_LIBTOOL found in: libemu-
  ab48695b7113db692982a1839e3d6eb9e73e90a9/configure.ac:49
  AM_CONFIG_HEADER found in: libemu-
  ab48695b7113db692982a1839e3d6eb9e73e90a9/configure.ac:14

Replace AC_PROG_LIBTOOL with LT_INIT and AM_CONFIG_HEADER with
AC_CONFIG_HEADERS

 - Exclude libemu.so from Python2 provides

python2-libemu.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/libemu.so libemu.so()(64bit)

%global __provides_exclude_from ^%{python2_sitearch}/libemu.so$



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3)", "GPL (v2 or later)", "Unknown or generated". 51
 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/libemu/review-libemu/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
 Note: Multiple Release: tags found
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in

[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-04-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #6 from Michal Ambroz  ---
Spec URL: http://rebus.fedorapeople.org/libemu.spec
SRPM URL:
http://rebus.fedorapeople.org/libemu-0.2.0-7.20130410gitab48695.fc27.src.rpm

- unbundle the libdasm library and use system-installed one
- disable python3 build/installation as it doesn't work at this point

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-03-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #5 from Michal Ambroz  ---
Hello Robert,
> - What's the point of:
I just wanted to see the error-logs from the python3 build - although it is now
failing. I do not plan to use this stanza

>- How do you plan to unbundle libdasm since you're also packaging it?
Yes I plan to unbundle it once it is ready as a standalone package.
Code here is the old-old version 1.4 (2006) with the same license doubts.
I plan to remove the libdasm.c and libdasm.h and use the system-installed
library instead.

> ldconfig
OK will do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-03-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #4 from Robert-André Mauchin  ---

 - What's the point of:

|| touch python3_build_failed

|| touch %{buildroot}/%{python3_sitearch}/python3_install_failed
[ -f python3_build_failed ] && touch
%{buildroot}/%{python3_sitearch}/python3_build_failed


 - Use the new %ldconfig_scriptlets. See
https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets#Upgrade.2Fcompatibility_impact

 - Not needed:

# ldconfig is provided by glibc
Requires(post): ldconfig
Requires(postun): ldconfig

 - How do you plan to unbundle libdasm since you're also packaging it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-03-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711

Michal Ambroz  changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)
 Depends On||1559699 (libdasm)



--- Comment #3 from Michal Ambroz  ---
Known issue - there is embedded version 1.4 of the libdasm library.
This should be de-referenced and updated to current version.

Adding dependency to #1559699


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1559699
[Bug 1559699] Review Request: libdasm - Simple x86 disassembly library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-03-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #2 from Michal Ambroz  ---
Spec URL: http://rebus.fedorapeople.org//libemu.spec
SRPM URL:
http://rebus.fedorapeople.org//libemu-0.2.0-0.5.20130410gitab48695.fc27.src.rpm

- adding the missing python3-devel build dependency

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-03-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711



--- Comment #1 from Michal Ambroz  ---
= Koji scratch build 

$ koji build --scratch rawhide 
libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm 
Uploading srpm: libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm
[] 100% 00:00:00 561.05 KiB 626.21 KiB/sec
Created task: 25897719
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=25897719
Watching tasks (this may be safely interrupted)...
25897719 build (rawhide, libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm):
open (buildvm-ppc64le-13.ppc.fedoraproject.org)
  25897726 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm,
armv7hl): free
  25897725 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm, s390x):
free
  25897724 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm, i686):
free
  25897723 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm, ppc64):
free
  25897722 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm,
aarch64): open (buildvm-aarch64-09.arm.fedoraproject.org)
  25897721 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm,
ppc64le): free
  25897720 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm,
x86_64): free
  25897726 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm,
armv7hl): free -> open (buildvm-armv7-20.arm.fedoraproject.org)
  25897725 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm, s390x):
free -> open (buildvm-s390x-13.s390.fedoraproject.org)
  25897724 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm, i686):
free -> open (buildvm-13.phx2.fedoraproject.org)
  25897723 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm, ppc64):
free -> open (buildvm-ppc64-13.ppc.fedoraproject.org)
  25897721 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm,
ppc64le): free -> open (buildvm-ppc64le-13.ppc.fedoraproject.org)
  25897720 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm,
x86_64): free -> open (buildhw-05.phx2.fedoraproject.org)
  25897720 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm,
x86_64): open (buildhw-05.phx2.fedoraproject.org) -> closed
  0 free  7 open  1 done  0 failed
  25897724 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm, i686):
open (buildvm-13.phx2.fedoraproject.org) -> closed
  0 free  6 open  2 done  0 failed
  25897725 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm, s390x):
open (buildvm-s390x-13.s390.fedoraproject.org) -> closed
  0 free  5 open  3 done  0 failed
  25897722 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm,
aarch64): open (buildvm-aarch64-09.arm.fedoraproject.org) -> closed
  0 free  4 open  4 done  0 failed
  25897721 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm,
ppc64le): open (buildvm-ppc64le-13.ppc.fedoraproject.org) -> closed
  0 free  3 open  5 done  0 failed
  25897723 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm, ppc64):
open (buildvm-ppc64-13.ppc.fedoraproject.org) -> closed
  0 free  2 open  6 done  0 failed
  25897726 buildArch (libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm,
armv7hl): open (buildvm-armv7-20.arm.fedoraproject.org) -> closed
  0 free  1 open  7 done  0 failed
25897719 build (rawhide, libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm):
open (buildvm-ppc64le-13.ppc.fedoraproject.org) -> closed
  0 free  0 open  8 done  0 failed

25897719 build (rawhide, libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm)
completed successfully

== rpmlint 
$ rpmlint libemu.spec libemu-0.2.0-0.4.20130410gitab48695.fc27.src.rpm 
1 packages and 1 specfiles checked; 0 errors, 0 warnings.

== knnown issues
fails to build the python3 package - I have the stanzas in the spec to see what
is failing and how in koji

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1559711] Review Request: libemu - The x86 shell-code detection and emulation

2018-03-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1559711

Michal Ambroz  changed:

   What|Removed |Added

 CC||re...@seznam.cz
 Blocks||563471 (FE-SECLAB)
  Alias||libemu




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=563471
[Bug 563471] Tracker: Review Requests for Fedora Security Lab related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org