[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864



--- Comment #11 from Sachidananda Urs  ---
Looks good to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5GW67VH7JTWSRRPIIRVN4WBTF56EXXEX/

[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864



--- Comment #10 from Venkata R Edara  ---
(In reply to Sachidananda Urs from comment #9)
> (In reply to Venkata R Edara from comment #8)
> > (In reply to Sachidananda Urs from comment #7)
> > > (In reply to Venkata R Edara from comment #4)
> > > > Sorry for delay, I made changes to spec file , now the build is 
> > > > success. 
> > > > 
> > > > SPEC:
> > > > https://github.com/gluster/gluster-collectd/blob/master/gluster-collectd.spec
> > > > 
> > > 
> > > * Instead of /usr/share use the _datadir macro.
> > > 
> > > > Requires : collectd >= 5.8.0
> > > > Requires : collectd-python >= 5.8.0
> > > 
> > > If the fedora releases targeted has latest above 5.8.x you can ignore the
> > > version numbers.
> > > 
> 
> Did you get a chance to check this? For the releases you are packaging, if
> they
> by default ship later versions the checks are redundant.

Now i removed the versions, fedora is shipping 5.8.0 only. 
Here is latest spec :
https://copr-be.cloud.fedoraproject.org/results/redara/gluster-collectd/fedora-27-x86_64/00772262-gluster-collectd/gluster-collectd.spec

Here is successful build:
https://copr-be.cloud.fedoraproject.org/results/redara/gluster-collectd/fedora-27-x86_64/00772262-gluster-collectd/

I will checkin spec file to git repo, once review is over.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MIMMF4N2IO74A4YMQJHLXFTSIFTBPRJI/

[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864



--- Comment #9 from Sachidananda Urs  ---
(In reply to Venkata R Edara from comment #8)
> (In reply to Sachidananda Urs from comment #7)
> > (In reply to Venkata R Edara from comment #4)
> > > Sorry for delay, I made changes to spec file , now the build is success. 
> > > 
> > > SPEC:
> > > https://github.com/gluster/gluster-collectd/blob/master/gluster-collectd.spec
> > > 
> > 
> > * Instead of /usr/share use the _datadir macro.
> > 
> > > Requires : collectd >= 5.8.0
> > > Requires : collectd-python >= 5.8.0
> > 
> > If the fedora releases targeted has latest above 5.8.x you can ignore the
> > version numbers.
> > 

Did you get a chance to check this? For the releases you are packaging, if they
by default ship later versions the checks are redundant.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FIKIPD46MJX3BOVYGI2SMPNWZLCYYYVN/

[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864



--- Comment #8 from Venkata R Edara  ---
(In reply to Sachidananda Urs from comment #7)
> (In reply to Venkata R Edara from comment #4)
> > Sorry for delay, I made changes to spec file , now the build is success. 
> > 
> > SPEC:
> > https://github.com/gluster/gluster-collectd/blob/master/gluster-collectd.spec
> > 
> 
> * Instead of /usr/share use the _datadir macro.
> 
> > Requires : collectd >= 5.8.0
> > Requires : collectd-python >= 5.8.0
> 
> If the fedora releases targeted has latest above 5.8.x you can ignore the
> version numbers.
> 
> > %{__python2} setup.py build
> * py2_build macro should achieve this. Have you tried it?
> 
> Below is a comment from Ken Dreyer from another package. Since I see python2
> in many places, I think it is still relevant.
> 
> Can this package work with Python 3 instead of Python 2? Maybe it would be a
> good idea to add a comment to the .spec file explaining why this will not
> work with Python 3 if that is the case.
> https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3 is coming
> eventually. You could conditionalize py2/py3 with "%if %{?rhel} < 8" if you
> want to share the same .spec file across RHEL 7 and Fedora.

I added comment saying why Python 2 is supported. for Python 3 we have to test
many dependencies and packages. I added macro for _datadir. but for py2_build
macro the build is failing in FAS site.

here is link for successful build:
https://copr-be.cloud.fedoraproject.org/results/redara/gluster-collectd/fedora-27-x86_64/00772030-gluster-collectd/

specfile:
https://github.com/gluster/gluster-collectd/blob/master/gluster-collectd.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WTFVZ5VTVVHPISRFXLJEPLXPQNRN66RV/

[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864

Sachidananda Urs  changed:

   What|Removed |Added

  Flags|needinfo?(s...@redhat.com)  |



--- Comment #7 from Sachidananda Urs  ---
(In reply to Venkata R Edara from comment #4)
> Sorry for delay, I made changes to spec file , now the build is success. 
> 
> SPEC:
> https://github.com/gluster/gluster-collectd/blob/master/gluster-collectd.spec
> 

* Instead of /usr/share use the _datadir macro.

> Requires : collectd >= 5.8.0
> Requires : collectd-python >= 5.8.0

If the fedora releases targeted has latest above 5.8.x you can ignore the
version numbers.

> %{__python2} setup.py build
* py2_build macro should achieve this. Have you tried it?

Below is a comment from Ken Dreyer from another package. Since I see python2 in
many places, I think it is still relevant.

Can this package work with Python 3 instead of Python 2? Maybe it would be a
good idea to add a comment to the .spec file explaining why this will not work
with Python 3 if that is the case.
https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3 is coming
eventually. You could conditionalize py2/py3 with "%if %{?rhel} < 8" if you
want to share the same .spec file across RHEL 7 and Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LJZ44N2MSUVG3YDFFEEMQ6FCOFD5DEDQ/

[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864

Sahina Bose  changed:

   What|Removed |Added

 CC||sab...@redhat.com,
   ||s...@redhat.com
  Flags||needinfo?(s...@redhat.com)



--- Comment #6 from Sahina Bose  ---
Sachi, could you help here

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ANHYHAC3QAYVRA47HGT3FRLHIHKY34JC/

[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864



--- Comment #5 from Venkata R Edara  ---
can anyone pick this up and do the review please.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/STCAPYR5GCUAEQLSNHI3KO7Q6E2FQW5U/

[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864



--- Comment #4 from Venkata R Edara  ---
Sorry for delay, I made changes to spec file , now the build is success. 

SPEC:
https://github.com/gluster/gluster-collectd/blob/master/gluster-collectd.spec

SOURCE RPM:
https://copr-be.cloud.fedoraproject.org/results/redara/gluster-collectd/fedora-27-x86_64/00761614-gluster-collectd/gluster-collectd-1.0.0-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CKMPSN62YEQ4LRDW4OQALLI2R3C62GNI/

[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #3 from Iwicki Artur  ---
>Release: 0%{?dist}
This should start at 1.

>Source0: gluster-collectd-%{version}-%{_release}.tar.gz
It's preferred for Source0 to be a downloadable URL.

>cp -r conf/* %{buildroot}/%{_confdir}/
>cp -r types/* %{buildroot}/usr/share/collectd/
You should aim to preserve file timestamps. Use "cp -a" or "cp -rp". 

Also, the linked copr build failed.
>+ '%{__python2}' setup.py build
>BUILDSTDERR: /var/tmp/rpm-tmp.JzTM17: line 31: fg: no job control
The "no job control" error usually means that the macro failed to expand and
the shell is interpeting the "%" as job control. You may need to add a
BuildRequires for "python2-rpm-macros".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864



--- Comment #2 from Venkata R Edara  ---
(In reply to Robert-André Mauchin from comment #1)
> You don't seem to have a FAS account?

red...@redhat.com is my FAS account.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
You don't seem to have a FAS account?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559864] Review Request: gluster-collectd plugin to collect metrics and push to collectd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559864

Venkata R Edara  changed:

   What|Removed |Added

 Blocks||1470532




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470532
[Bug 1470532] [RFE] Collect gluster metrics from nodes
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org