[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

Neal Gompa  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2018-09-08 10:47:42



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184



--- Comment #12 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rpkg-util

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Neal Gompa  ---
Well, there's nothing else left, I suppose...

Please work with upstream to resolve missing tarballs and switch to that.

Otherwise... APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184



--- Comment #10 from cl...@redhat.com ---
Neal, can your objections be satisfied by specific pointers into Fedora
Packaging Guidelines? If not, I don't really see why not continue. So, please,
express your take on this because I would like to move it forward.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184



--- Comment #9 from cl...@redhat.com ---
(In reply to clime from comment #8)
> (In reply to Neal Gompa from comment #7)
> > Still has a VCS tag, and the Source0 isn't a URL that can be fetched to get
> > the tarball.
> 
> I haven't found any mention in guidelines of VCS tag being forbidden. I
> believe it's ok to use it as a tag describing upstream source for the
> package.
> 
> Using non-url Source0 should be also alright as described here:
> 
> https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
> 
> Comments how to obtain the Source0 were added.

Also...as you can see...

https://releases.pagure.org/rpkg-util

upstream does not provide source tarball *shrugs*.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184



--- Comment #8 from cl...@redhat.com ---
(In reply to Neal Gompa from comment #7)
> Still has a VCS tag, and the Source0 isn't a URL that can be fetched to get
> the tarball.

I haven't found any mention in guidelines of VCS tag being forbidden. I believe
it's ok to use it as a tag describing upstream source for the package.

Using non-url Source0 should be also alright as described here:

https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control

Comments how to obtain the Source0 were added.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184



--- Comment #7 from Neal Gompa  ---
Still has a VCS tag, and the Source0 isn't a URL that can be fetched to get the
tarball.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184



--- Comment #6 from cl...@redhat.com ---
ping.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184



--- Comment #5 from cl...@redhat.com ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhide-x86_64/00739073-rpkg-util/rpkg-util.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhide-x86_64/00739073-rpkg-util/rpkg-util-1.0-1.fc29.src.rpm

...fixes according to the review notes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184



--- Comment #4 from Neal Gompa  ---
Review notes:
[x] Package is named appropriately
[x] Licensing is correctly noted and license files are correctly installed
[x] Packaging follows Fedora Python Packaging Guidelines
[!] Packaging follows Fedora Packaging Guidelines
* VCS tag is used, Source0 isn't verifiable
* Version scheme doesn't follow current snapshot release guidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184



--- Comment #3 from cl...@redhat.com ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhide-x86_64/00738939-rpkg-util/rpkg-util.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/clime/rpkg-util/fedora-rawhide-x86_64/00738939-rpkg-util/rpkg-util-1.0.git.231.febc6f2-1.fc29.src.rpm

Can you re-review, please?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184



--- Comment #2 from Neal Gompa  ---
Package build fails on %check section:

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.oJ7Crn
+ umask 022
+ cd /builddir/build/BUILD
+ cd rpkg-util-1.0.git.198.d77c2b9
+ FULL=1
+ ./run_tests.sh
= test session starts
==
platform linux2 -- Python 2.7.14, pytest-3.4.2, py-1.5.3, pluggy-0.6.0
rootdir: /builddir/build/BUILD/rpkg-util-1.0.git.198.d77c2b9, inifile:
collected 29 items
BUILDSTDERR: tests/test_cli.py .This function is deprecated and will be removed
in a future release.
BUILDSTDERR: .This function is deprecated and will be removed in a future
release.
BUILDSTDERR: ..Auto-packing is deprecated and will be removed in a future
release.
BUILDSTDERR: .This function is deprecated and will be removed in a future
release.
BUILDSTDERR: This function is deprecated and will be removed in a future
release.
.
BUILDSTDERR: tests/test_cmd.py ..error: Package has no %description:
testpkg
...
tests/test_lookaside.py .
tests/test_utils.py .
== 29 passed in 0.83 seconds
===
== test_bash ==
Initialized empty Git repository in /tmp/tmp.AnQ2iUXGBa/.git/
> ../preproc.py --path /tmp/tmp.AnQ2iUXGBa --input /tmp/tmp.AnQ2iUXGBa/input 
> --output /tmp/tmp.wkDoLIha3j/output | log_filter &> /tmp/tmp.wkDoLIha3j/log
> diff /tmp/tmp.CNJEmyUSlI /tmp/tmp.wkDoLIha3j/output || die
3c3
< date --date='@2147483647' +%y%m%d: 380119
---
> date --date='@2147483647' +%y%m%d: 380118
fail.
BUILDSTDERR: error: Bad exit status from /var/tmp/rpm-tmp.oJ7Crn (%check)
RPM build errors:
BUILDSTDERR: Bad exit status from /var/tmp/rpm-tmp.oJ7Crn (%check)
Child return code was: 1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563184] Review Request: rpkg-util - RPM packaging utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563184

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org