[Bug 1567202] Review Request: gerbera - UPnP Media Server
https://bugzilla.redhat.com/show_bug.cgi?id=1567202 Gwyn Ciesla changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-04-20 10:33:27 --- Comment #7 from Gwyn Ciesla --- Thank you for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1567202] Review Request: gerbera - UPnP Media Server
https://bugzilla.redhat.com/show_bug.cgi?id=1567202 Bug 1567202 depends on bug 1567201, which changed state. Bug 1567201 Summary: Review Request: duktape - Embeddable Javascript engine https://bugzilla.redhat.com/show_bug.cgi?id=1567201 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1567202] Review Request: gerbera - UPnP Media Server
https://bugzilla.redhat.com/show_bug.cgi?id=1567202 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gerbera -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1567202] Review Request: gerbera - UPnP Media Server
https://bugzilla.redhat.com/show_bug.cgi?id=1567202 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #5 from Robert-André Mauchin --- Everything is good, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1567202] Review Request: gerbera - UPnP Media Server
https://bugzilla.redhat.com/show_bug.cgi?id=1567202 --- Comment #4 from Gwyn Ciesla --- Thank you! Updated. SRPM: https://fedorapeople.org/~limb/review/gerbera/gerbera-1.1.0-2.20180413git2f6dcb5.fc29.src.rpm SPEC: https://fedorapeople.org/~limb/review/gerbera/gerbera.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1567202] Review Request: gerbera - UPnP Media Server
https://bugzilla.redhat.com/show_bug.cgi?id=1567202
--- Comment #3 from Robert-André Mauchin ---
- Build error:
BUILDSTDERR: CMake Error at
/usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
BUILDSTDERR: Could NOT find ZLIB (missing: ZLIB_LIBRARY ZLIB_INCLUDE_DIR)
BUILDSTDERR: Call Stack (most recent call first):
BUILDSTDERR: /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:378
(_FPHSA_FAILURE_MESSAGE)
BUILDSTDERR: /usr/share/cmake/Modules/FindZLIB.cmake:112
(FIND_PACKAGE_HANDLE_STANDARD_ARGS)
BUILDSTDERR: CMakeLists.txt:552 (find_package)
-- Configuring incomplete, errors occurred!
Add:
BuildRequires: zlib-devel
- Add these license to the license field:
MIT/X11 (BSD like)
--
gerbera-2f6dcb5e941dce3ace651394cfa86b862becaa77/web/vendor/popper/popper.js
SIL (v1.1)
--
gerbera-2f6dcb5e941dce3ace651394cfa86b862becaa77/web/vendor/lato/LICENCE.md
- You should own these directories:
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gerbera/web,
/etc/logrotate.d, /usr/share/gerbera, /usr/share/gerbera/js
- gerbera.x86_64: E: non-root-user-log-file /var/log/gerbera gerbera
gerbera.x86_64: E: non-root-group-log-file /var/log/gerbera gerbera
non-root-user-log-file:
If you need log files owned by a non-root user, just create a subdir in
/var/log and put your log files in it.
Create a subdir for the logs. Don't forget to change the location in the
config file and the logrotate file too.
- The log file should be ghosted:
gerbera.x86_64: E: non-ghost-file /var/log/gerbera
- [!]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Note: Arch-ed rpms have a total of 5396480 bytes in /usr/share
Move the data to a noarch data subpackage
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD
like)", "SIL (v1.1)", "zlib/libpng", "*No copyright* BSD (3 clause)",
"BSD (2 clause)", "GPL (v2)", "GPL (v2) LGPL (v2.1)". 375 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/gerbera/review-gerbera/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/gerbera/web, /usr/share/gerbera/js,
/usr/share/gerbera
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gerbera/web,
/etc/logrotate.d, /usr/share/gerbera, /usr/share/gerbera/js
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does no
[Bug 1567202] Review Request: gerbera - UPnP Media Server
https://bugzilla.redhat.com/show_bug.cgi?id=1567202
--- Comment #2 from Robert-André Mauchin ---
- I made a typo, Source0 should be:
Source0:
https://github.com/gerbera/gerbera/archive/%{commit}/%{name}-%{commit}.tar.gz
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1567202] Review Request: gerbera - UPnP Media Server
https://bugzilla.redhat.com/show_bug.cgi?id=1567202
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- That's not good:
#Source0:
https://github.com/gerbera/gerbera/archive/v%%{version}/%%{name}-%%{version}.tar.gz
#Use tarball to address build issue.
Source0:gerbera-1.1.0-2f6dcb5e94.tar.gz
If you're packaging a snapshot, just use:
%global commit 2f6dcb5e941dce3ace651394cfa86b862becaa77
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global snapshotdate20180413
Name: gerbera
Version:1.1.0
Release:1.%{snapshotdate}git%{shortcommit}%{?dist}
Summary:UPnP Media Server
License:GPLv2
Url:https://gerbera.io
Source0:
https://github.com/gerbera/gerbera/archive/{commit}/%{name}-%{commit}.tar.gz
Then:
%prep
%autosetup -n %{name}-%{commit}
And the %changelog:
* Fri Apr 13 2018 Gwyn Ciesla -
1.1.0-1.20180413git2f6dcb5
- You're missing the dist tag:
Release:1.%{snapshotdate}git%{shortcommit}%{?dist}
- %{__make} %{?_smp_mflags} → %make_build
- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" → %make_install
- %{__install}, %{__mkdir_p}, %{__cat} don't bring anything, just use install,
mkdir -p and cat.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1567202] Review Request: gerbera - UPnP Media Server
https://bugzilla.redhat.com/show_bug.cgi?id=1567202 Gwyn Ciesla changed: What|Removed |Added Depends On||1567201 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1567201 [Bug 1567201] Review Request: duktape - Embeddable Javascript engine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
