[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 --- Comment #15 from Fernando Pereira dos Santos --- (In reply to Miro Hrončok from comment #14) > You can review my package proposal at bz1613753. I'd list you as > co-maintainer if you'd like. Yeah! Sure, I will add to my agenda. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XZZSKIX4H7JUEYYSGKN7SRW7VOX54BKA/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 --- Comment #14 from Miro Hrončok --- You can review my package proposal at bz1613753. I'd list you as co-maintainer if you'd like. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2CNV6TT2OOM5E2PIQZ6W4TQPQ256IF7I/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 --- Comment #13 from Fernando Pereira dos Santos --- OK Miro. Sorry it took me so long to get back to you. Do you need a hand? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MF3ATFU3HDUFLOSYD2KMMPUULUWEEAZC/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 Miro Hrončok changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |DUPLICATE Flags|fedora-review+ | |needinfo?(ferox@fedoraproje | |ct.org) | Last Closed||2018-08-08 05:51:43 --- Comment #12 from Miro Hrončok --- *** This bug has been marked as a duplicate of bug 1613753 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/6N5SIRPUPBLGWCD5SYX2NJ4EURE7BOI7/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 Miro Hrončok changed: What|Removed |Added CC||fe...@fedoraproject.org, ||mhron...@redhat.com Blocks||1610571 Flags||needinfo?(ferox@fedoraproje ||ct.org) --- Comment #9 from Miro Hrončok --- I need python3-dotenv. Can we move this forward? Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1610571 [Bug 1610571] ampy-1.0.5 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GLZZT7WIPXSOOSNUJRIROB4T557JAEH3/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638
--- Comment #11 from Miro Hrončok ---
Also, as for the content:
%{_bindir}/dotenv should be just one and in the Python 3 package, as it's a
tool that behaves the same on both Pythons.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/JVHOMHJE5S2FDM2J34J4KHHUCPD2RVKN/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 --- Comment #10 from Miro Hrončok --- As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews I'm indicating that the review is stalled and that a response is needed soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/UP3E42NIS7V2PL6ZIXHYXRHYSE63PCIC/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Assignee|athoscribe...@gmail.com |zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- Thanks for taking the sponsorship! Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/Z3KQJ5ACTZFY7PU4UWXJIA6QZR7HYZTE/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 Athos Ribeiro changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #7 from Athos Ribeiro --- Removing FE-NEEDSPONSOR: I started the process with Fernando and will aponsor him as soon as he complete some tasks to show he is able to apply the Fedora Packaging Guidelines when working on Fedora packages. He will be either performing a few informal package reviews or applying some patches in packages I maintain in our next iterations (his choice). When he is done, I will approve this package if Robert does not do it until then. Robert, Thanks for the review, feel free to take the ticket and finish the review if you want :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KIJDIEACAJMJ3IGYP4UU6NKIQBF4QI3G/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 Athos Ribeiro changed: What|Removed |Added CC||athoscribe...@gmail.com Blocks|177841 (FE-NEEDSPONSOR) | Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SO44VOCSLTGIZBDVRN7NJDOWUZDPXKYA/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 --- Comment #6 from Fernando Pereira dos Santos --- (In reply to Robert-André Mauchin from comment #5) > It's good for approval but you need to find a sponsor first. Try introducing > yourself to the devel mailing list. Thanks buddy. I will! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 --- Comment #5 from Robert-André Mauchin --- It's good for approval but you need to find a sponsor first. Try introducing yourself to the devel mailing list. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 --- Comment #4 from Fernando Pereira dos Santos --- Fixed Spec URL: https://ferox.fedorapeople.org/rpm-packages/python-dotenv/0.8.2/python-dotenv.spec SRPM URL: https://ferox.fedorapeople.org/rpm-packages/python-dotenv/0.8.2/python-dotenv-0.8.2-3.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638
--- Comment #3 from Robert-André Mauchin ---
- The correct license shorthand is BSD:
License:BSD
See the full list: https://fedoraproject.org/wiki/Licensing#SoftwareLicenses
- %{sum} is not a valid macro. Use %{summary}:
Summary:%{summary}
- Escape the macros in %changelog by doubling %:
- %%{_bindir}/dotenv removed and added BSD License
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "Unknown or generated". 17 files have unknown
license. Detailed output of licensecheck in /home/bob/packaging/review
/python-dotenv/review-python-dotenv/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: python3-dotenv (summary)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python2-dotenv , python3-dotenv
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is prese
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 --- Comment #2 from Fernando Pereira dos Santos --- Fixed Spec URL: https://ferox.fedorapeople.org/rpm-packages/python-dotenv/0.8.2/python-dotenv.spec SRPM URL: https://ferox.fedorapeople.org/rpm-packages/python-dotenv/0.8.2/python-dotenv-0.8.2-2.fc27.src.rpm License: BSD License -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- License is not "None", the License is BSD:
https://github.com/theskumar/python-dotenv/blob/master/LICENSE
- %{_bindir}/dotenv can't be in both package
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 Itamar Reis Peixoto changed: What|Removed |Added CC||ita...@ispbrasil.com.br Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
