[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217



--- Comment #10 from Fedora Update System  ---
python-gitlab-1.3.0-3.el7.1 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5XK6M5VB7VBIYEPHDDV3N65ZGNYSZDW4/

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-06-13 11:17:22



--- Comment #9 from Fedora Update System  ---
python-gitlab-1.3.0-3.fc28 has been pushed to the Fedora 28 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/C54ZII52MDUQSZKVICY33XNYURLYOOFJ/

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217



--- Comment #8 from Fedora Update System  ---
python-gitlab-1.3.0-3.fc28 has been pushed to the Fedora 28 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d60efc70c2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GI6R5J4UKZL3OZ4RSOJZZUG357E4IWPW/

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
python-gitlab-1.3.0-3.el7.1 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-4619de4f36

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/TP3DUA6WPMIV5LUQQZJP55MM2EQIHUBU/

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5QDERE47FWUAWOPWXEXK47CLZQVG4XV5/

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217



--- Comment #6 from Fedora Update System  ---
python-gitlab-1.3.0-3.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d60efc70c2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/JEMN7PXURNF7QCVLPXQW3V6R4LOEIXY6/

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217



--- Comment #5 from Fedora Update System  ---
python-gitlab-1.3.0-3.el7.1 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-4619de4f36

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/J5MEVAOTFGZHFX7GP3TZLTSOLBG64F2G/

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217
Bug 1577217 depends on bug 1577198, which changed state.

Bug 1577198 Summary: Review Request: python-httmock - mocking library for 
requests
https://bugzilla.redhat.com/show_bug.cgi?id=1577198

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/R6AVS2ADEAW2POKCD3RIPTBZVYLOCSO3/

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-gitlab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
 - You've made a mistake here:

BuildRequires:  python3-devel
BuildRequires:  python3dist(requests) >= 1.0
BuildRequires:  python3dist(setuptools)
BuildRequires:  python3dist(six)
BuildRequires:  python3dist(sphinx)
BuildRequires:  python3dist(httmock)
BuildRequires:  python2dist(mock)

   It should be python3dist(mock)


Package otherwise accepted. Fix the above error before import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217



--- Comment #2 from Steve Traylen  ---
THanks for the comments.
%license added mock build requires added.


Spec URL: http://cern.ch/straylen/rpms/python-gitlab/python-gitlab.spec
SRPM URL:
http://cern.ch/straylen/rpms/python-gitlab/python-gitlab-1.3.0-2.fc28.src.rpm

I'll confirm mock once the httmock dependency is processed...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - The COPYING file should be marked as %license in %files:

%files -n python2-%{pypi_name}
%doc README.rst contrib/docker/README.rst
%license COPYING
%{python2_sitelib}/%{pypi_name}
%{python2_sitelib}/python_gitlab-%{version}-py?.?.egg-info

%files -n python3-%{pypi_name}
%doc README.rst contrib/docker/README.rst
%license COPYING
%{_bindir}/gitlab
%{python3_sitelib}/%{pypi_name}
%{python3_sitelib}/python_gitlab-%{version}-py?.?.egg-info

%files -n python-%{pypi_name}-doc
%license COPYING
%doc html

 - I've got a test failure:

BUILDSTDERR: ERROR: gitlab.tests.test_config
(unittest.loader.ModuleImportFailure)
BUILDSTDERR:
--
BUILDSTDERR: ImportError: Failed to import test module:
gitlab.tests.test_config
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/loader.py", line 254, in
_find_tests
BUILDSTDERR: module = self._get_module_from_name(name)
BUILDSTDERR:   File "/usr/lib64/python2.7/unittest/loader.py", line 232, in
_get_module_from_name
BUILDSTDERR: __import__(name)
BUILDSTDERR:   File
"/builddir/build/BUILD/python-gitlab-1.3.0/gitlab/tests/test_config.py", line
23, in 
BUILDSTDERR: import mock
BUILDSTDERR: ImportError: No module named mock
BUILDSTDERR:
--
BUILDSTDERR: Ran 166 tests in 0.338s
BUILDSTDERR: FAILED (errors=1)

   Add python2dist(mock) / python3dist(mock) as a BR to fix this.




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v3 or later)", "GPL (v3)", "Unknown or generated". 94
 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-gitlab/review-python-
 gitlab/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: 

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217

Steve Traylen  changed:

   What|Removed |Added

 Depends On||1577198




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1577198
[Bug 1577198] Review Request: python-httmock - mocking library for requests
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org