[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103



--- Comment #13 from Fedora Update System  ---
python-hyperlink-18.0.0-1.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/PDWKE2QB63EP2SHIPGSO7HIXJZEI633O/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-06-22 10:09:15



--- Comment #12 from Fedora Update System  ---
python-hyperlink-18.0.0-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/W3QZICZSN5KDMWB2EHNLJ4SSPSZAWMUZ/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103



--- Comment #11 from Fedora Update System  ---
python-hyperlink-18.0.0-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5ad25743b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LF527IJCVNNZWQV4MWD5Y6BXQNWS4LZU/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
python-hyperlink-18.0.0-1.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5251a80496

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VLP5OIQCMPVSPTGA3IINWWOML4PQPETU/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103



--- Comment #9 from Fedora Update System  ---
python-hyperlink-18.0.0-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5ad25743b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/UUCERSEM6KUO3MICXJSJEM3HZBU7CZ2P/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/Y6BQFUNF2D4LPOHBOE446OKRNWVDOX6P/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103



--- Comment #8 from Fedora Update System  ---
python-hyperlink-18.0.0-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5251a80496

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/U6F6PWHN7XRMNV2XATI4ML3YCOWLTASI/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-hyperlink

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YTJXQQTOFWH6WLWVUC5PXE6YGYAAEEOS/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103

Fabio Valentini  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #6 from Fabio Valentini  ---
> I actually did send a PR to update Inconsolata but the maintainer is Kevin 
> Fenzi and he is a very busy man.

Good! So once the inconsolata package is updated (whenever that may be), you
can unbundle that font, too.


Typo alarm:
---

You made a small mistake when you "refactored" the -doc subpackage (you missed
to drop the -n flag), so the doc (sub)package is now really named only "doc" -
which is probably not what you wanted

You can just drop the "-n" flag for the "doc" subpackage in the %package,
%description, and %files stanzas before importing the package - I won't block
the review on that.


Otherwise:
Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/C2WSZ3Y7OBJD7EEEYQNPXU7LFFLITYX5/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103



--- Comment #5 from Robert-André Mauchin  ---
(In reply to Fabio Valentini from comment #4)
> ISSUES
> ==
> 
> 1) The "%package -n python-%{pypi_name}-doc" can just be "%package doc". Same
>goes for "%description" and %files" stanzas.
> 

Ok.


> 2) You'll also need to add these to the "-doc" subpackage, otherwise the
>installed package will only have broken symlinks (see rpmlint messages):
> 
> Requires:   fontawesome-fonts
> Requires:   fontawesome-fonts-web
> Requires:   lato-fonts
> Requires:   google-roboto-slab-fonts
> Requires:   js-underscore
> Requires:   js-jquery
> 

Ooops you're right.


> 3) Since you're bundling inconsolata, you'll also need to add this to the
> "-doc"
>subpackage:
> 
> Provides:   bundled(levien-inconsolata-fonts)

Ok.

> 
> It would be nice if you could ping the maintainer of the inconsolata fonts in
> fedora to update the package so you could unbundle those in a future version
> of
> this package, but that's probably out of the scope of this review.
> 

I actually did send a PR to update Inconsolata but the maintainer is Kevin
Fenzi and he is a very busy man.
https://src.fedoraproject.org/rpms/levien-inconsolata-fonts/pull-request/1

> 
> With those 3 issues fixed, I'll approve the package. (Detailed review below.)
> 

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/python-twisted/fedora-rawhide-x86_64/00763687-python-hyperlink/python-hyperlink.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/python-twisted/fedora-rawhide-x86_64/00763687-python-hyperlink/python-hyperlink-18.0.0-1.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/US6UXWA5BQE4R3JF4DCPUQLTVZK4OR4X/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103



--- Comment #4 from Fabio Valentini  ---
ISSUES
==

1) The "%package -n python-%{pypi_name}-doc" can just be "%package doc". Same
   goes for "%description" and %files" stanzas.

2) You'll also need to add these to the "-doc" subpackage, otherwise the
   installed package will only have broken symlinks (see rpmlint messages):

Requires:   fontawesome-fonts
Requires:   fontawesome-fonts-web
Requires:   lato-fonts
Requires:   google-roboto-slab-fonts
Requires:   js-underscore
Requires:   js-jquery

3) Since you're bundling inconsolata, you'll also need to add this to the
"-doc"
   subpackage:

Provides:   bundled(levien-inconsolata-fonts)

It would be nice if you could ping the maintainer of the inconsolata fonts in
fedora to update the package so you could unbundle those in a future version of
this package, but that's probably out of the scope of this review.


With those 3 issues fixed, I'll approve the package. (Detailed review below.)


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[x]: Fully 

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103



--- Comment #3 from Robert-André Mauchin  ---
Inconsolata is too old on Fedora and modernizr is not packaged. I have
unbundled the rest.

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/python-twisted/fedora-rawhide-x86_64/00763262-python-hyperlink/python-hyperlink.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/python-twisted/fedora-rawhide-x86_64/00763262-python-hyperlink/python-hyperlink-18.0.0-1.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/B7OQXXV2AJKMHYIBS7347JSEIBHWTQIV/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103

Fabio Valentini  changed:

   What|Removed |Added

 CC||decatho...@gmail.com
   Assignee|besse...@fedoraproject.org  |decatho...@gmail.com
  Flags|fedora-review?  |



--- Comment #2 from Fabio Valentini  ---
Taking over this review as per Robert-André's request.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= ISSUES =

- Package bundles fonts: "/usr/share/doc/%{name}/html/_static/fonts/":
  - fontawesome-4.7.0
  - Inconsolata
  - Lato
  - RobotoSlab

- Package bundles JavaScript libraries: "/usr/share/doc/%{name}/html/_static/":
  - jquery-3.2.1
  - underscore-1.3.1
  - modernizr-2.6.2 

- Some shipped JavaScript code is BSD-licensed, not MIT-licensed.


 -> Un-bundle the fonts and JavaScript libraries (remove the vendored ones and
replace them with symlinks to fedora-packaged versions), if possible.

 -> Update the License tag to also reflect any left-over bundled BSD-licensed
code.

 -> Easiest solution: Don't build and ship offline documentation.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103



--- Comment #1 from Robert-André Mauchin  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/python-twisted/fedora-rawhide-x86_64/00763197-python-hyperlink/python-hyperlink.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/python-twisted/fedora-rawhide-x86_64/00763197-python-hyperlink/python-hyperlink-18.0.0-1.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/X3WNR5BIFI4DXYZHPWNMNTWKLJLQGDLU/

[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1578103

Björn 'besser82' Esser  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||besse...@fedoraproject.org
   Assignee|nob...@fedoraproject.org|besse...@fedoraproject.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2MAOVWH6GQFQ5ULUOIIYE2EQJJEB7HMU/