[Bug 1579416] Review Request: ghc-bdcs - Tools for managing a content store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579416

Chris Lumens  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-05-18 11:07:55



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/BHSE5I2HOAJ7N3NTK645Q2JNWHLJA6RU/

[Bug 1579416] Review Request: ghc-bdcs - Tools for managing a content store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579416



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-bdcs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XCWTZ62AH5B36YEUASM5GLCMVYCZHHNV/

[Bug 1579416] Review Request: ghc-bdcs - Tools for managing a content store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579416

David Shea  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from David Shea  ---
Looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KIGKAENEX2LG5PJMBNRCU3EB5FRL6LCP/

[Bug 1579416] Review Request: ghc-bdcs - Tools for managing a content store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579416



--- Comment #2 from Chris Lumens  ---
Okay, I've updated the links with new versions that should address all those
problems.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/6FK7UXRRE4UKDXQTNK2PHIW7JYVA4JAY/

[Bug 1579416] Review Request: ghc-bdcs - Tools for managing a content store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579416



--- Comment #1 from David Shea  ---
Created attachment 1438049
  --> https://bugzilla.redhat.com/attachment.cgi?id=1438049=edit
package review

Ah jeez this review file is long, no wonder it took so long. My favorite part
is the line saying that other packages own /lib/.build-id owned by this
package, and then it lists the other packages, which is every package in
Fedora. So good.

But anyway good news most of it is garbage or complaining about things that
don't apply to haskell. Here's the highlights:

* The docs are too dang big. I think juhp is maybe working on something for
that in cabal-rpm? I don't know, but The Guidelines are clear that we have to
be as hostile as possible to developers if docs are over 1MB.
https://src.fedoraproject.org/rpms/ghc-servant/blob/master/f/ghc-servant.spec
is how I did it (split -devel.files into -devel-doc and -devel-nodoc in
%install), and remove the -doc Provides from -devel

* Nothing owns %{_libexecdir}/%{pkgver}. Just add that to %files.

* We misspelled "included" in the desscription. That can wait for later since
we can just blame upstream for now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/U4R6SDAHQ2ESEG5CEBLZZO437W5TTSN2/

[Bug 1579416] Review Request: ghc-bdcs - Tools for managing a content store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1579416

David Shea  changed:

   What|Removed |Added

 CC||ds...@redhat.com
   Assignee|nob...@fedoraproject.org|ds...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/JQXQYTRSHIFD7YTUYJR4QLQD46JPW5WE/