[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-06-22 11:05:06



--- Comment #9 from Fedora Update System  ---
libsmbios-cpp-2.3.3-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SXJHXU4FNCDL2MO7CJVPQS5PMGAVNF2T/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
libsmbios-cpp-2.3.3-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-b03a9eeb2f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4IMLPUWAYRMDPB3W72ELAASC2TO4LCZF/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831



--- Comment #7 from Fedora Update System  ---
libsmbios-cpp-2.3.3-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-b03a9eeb2f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/DVEP4QEHKTX3TPDLGBAVCLSJR4ITT4AI/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OINLDZJULAVOMXJFS7WH6Z32YWNF23WK/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libsmbios-cpp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MT2LOVPXPL32J5V6AW77J7LBNBSHE6QM/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831

Carl George  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|smo...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ES5AG5N6NAXL7SRMKEQHFB3THJGTFYQ5/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831

Stephen John Smoogen  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #5 from Stephen John Smoogen  ---
After much searching and clicking.. I found the correct review button.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/NPRIU23AHTCABVS2SIW2I2JEDUHKQ5DD/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831

Stephen John Smoogen  changed:

   What|Removed |Added

 Attachment||review+
 #1446357 Flags||



--- Comment #4 from Stephen John Smoogen  ---
Created attachment 1446357
  --> https://bugzilla.redhat.com/attachment.cgi?id=1446357=edit
Review done by user

This covers the files needed to show that a review was done and that the items
which fedora-review flagged were checked and confirmed to be ok for EL-7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/UFQ74HJOU2ISRYHCQXAQMJXHR4DWXYSW/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831

Stephen John Smoogen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||smo...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HJK2E53EXSMGRBPGCEZOQIPFNVAB2QN4/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831



--- Comment #3 from Carl George  ---
> libsmbios-cpp.src:58: W: configure-without-libdir-spec
> libsmbios-cpp.src:62: W: configure-without-libdir-spec
> libsmbios-cpp.src:63: W: configure-without-libdir-spec

I think these are false positives based on searching for the string
"./configure".  Lines 58, 62, and 63 all happen to contain that string, but
aren't actually executing the configure script.  Besides, that section of
%build was lifted directly from the RHEL spec file.

> libsmbios-cpp.src: W: patch-not-applied Patch0: 
> disable-unwanted-components.patch

Another false positive.  Patch0 is applied via the %autosetup macro.  Fedora's
rpmlint is aware of this and doesn't return this warning.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IB7JSHJRURBWW2S4BXFD4EKFXKKU3VKW/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831



--- Comment #2 from R P Herrold  ---
I get this

# -- rpmlint starts -- 
rpmlint version 1.5 Copyright (C) 1999-2007 Frederic Lepied, Mandriva
libsmbios-cpp.src:58: W: configure-without-libdir-spec
libsmbios-cpp.src:62: W: configure-without-libdir-spec
libsmbios-cpp.src:63: W: configure-without-libdir-spec
libsmbios-cpp.src: W: patch-not-applied Patch0:
disable-unwanted-components.patch
./holding/libsmbios-cpp.spec:58: W: configure-without-libdir-spec
./holding/libsmbios-cpp.spec:62: W: configure-without-libdir-spec
./holding/libsmbios-cpp.spec:63: W: configure-without-libdir-spec
./holding/libsmbios-cpp.spec: W: patch-not-applied Patch0:
disable-unwanted-components.patch
1 packages and 1 specfiles checked; 0 errors, 8 warnings.
# -- rpmlint ends --

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7UVTJFSQQL7CFCAUR2RF2X4MBEROI4RB/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831

Carl George  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1562440,
   ||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1581722



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/P2J3UF7PNKOYEV2WVMGLD5MKEPLOUAYE/

[Bug 1581831] Review Request: libsmbios-cpp - Libsmbios C++ shared libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1581831

Carl George  changed:

   What|Removed |Added

  Component|Package Review  |Package Review
Version|rawhide |epel7
Product|Fedora  |Fedora EPEL



--- Comment #1 from Carl George  ---
This package is for EPEL7 only.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/BJYDBXC2IB2N7LYXICKIU3ZZ6KDDSHCG/