[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 --- Comment #14 from Fedora Update System --- airnef-1.1-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FEQ5VPOIZD3W3CKECCJ757W6IATBBA3N/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 --- Comment #13 from Fedora Update System --- airnef-1.1-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OUJ3C2S3F56JUYVXDXL5S2BNMLVIIPYM/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-08-18 20:21:26 --- Comment #12 from Fedora Update System --- airnef-1.1-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2VHE55ZUUR7DT3HMO6K36OCPT62DTTJ4/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 --- Comment #11 from Fedora Update System --- airnef-1.1-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-05fb282fde -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4AM35TQ4JSI7YIH4AQMSSBK4YDP7ISCP/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 --- Comment #10 from Fedora Update System --- airnef-1.1-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-4e79a8d043 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/Q6QFCVCJWSRGNCMNWTZVFC7AMSODVBST/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- airnef-1.1-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-941f036f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IMJKHEEDBIBOSFYDMPOFZSOICZIM7WWR/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 --- Comment #8 from Fedora Update System --- airnef-1.1-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-05fb282fde -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/Y46KUIA6R2IWWZJFDQWC2QOSK6ZUGBAF/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 --- Comment #7 from Fedora Update System --- airnef-1.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-941f036f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/6E6MIOTMMMR3C3N6FC3NG3IEBGUUMRYX/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 --- Comment #6 from Fedora Update System --- airnef-1.1-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-4e79a8d043 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/NOXRBS6KJNMPVA2SQTZAH6LZN5RZS6MB/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IYXCJPMVO27C5AU6USMAS5LMA3GUVFJH/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/airnef -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ZW7VQAQPFHMSK76R5GLZYA4FKGMEOKTN/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #4 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YW3474D2HS75TJHDD5O6R5KZAFU7FSAT/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 --- Comment #3 from Pavel Raiskup --- Spec URL: https://raw.githubusercontent.com/praiskup/airnef-rpm/master/airnef.spec SRPM URL: http://praiskup.fedorapeople.org/airnef-1.1-2.src.rpm Robert-André, thanks for the quick look! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5IOVCV2IFSKJ7BXFIVCHRYJZKE6WULL4/
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #2 from Robert-André Mauchin ---
Remove the Python shebangs in %prep:
airnef.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/airnef/airnef.py /usr/bin/env python
airnef.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/airnef/airnef.py 644 /usr/bin/env python
airnef.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/airnef/airnefcmd.py /usr/bin/env python
airnef.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/airnef/airnefcmd.py 644 /usr/bin/env python
airnef.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/airnef/applog.py /usr/bin/env python
airnef.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/airnef/applog.py 644 /usr/bin/env python
airnef.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/airnef/dlinkedlist.py /usr/bin/env python
airnef.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/airnef/dlinkedlist.py 644 /usr/bin/env python
airnef.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/airnef/mtpdef.py /usr/bin/env python
airnef.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/airnef/mtpdef.py 644 /usr/bin/env python
airnef.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/airnef/mtpwifi.py /usr/bin/env python
airnef.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/airnef/mtpwifi.py 644 /usr/bin/env python
airnef.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/airnef/rename.py /usr/bin/env python
airnef.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/airnef/rename.py 644 /usr/bin/env python
airnef.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/airnef/ssdp.py /usr/bin/env python
airnef.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/airnef/ssdp.py 644 /usr/bin/env python
airnef.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/airnef/strutil.py /usr/bin/env python
airnef.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/airnef/strutil.py 644 /usr/bin/env python
- Perms should be 644 for the patch:
airnef.src: W: strange-permission airnef-1.1-rpm-paths.patch 600
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 14 files have unknown license. Detailed
output of licensecheck in /home/bob/packaging/review/airnef/review-
airnef/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build
[Bug 1583475] Review Request: airnef - Wireless download from your Nikon/ Canon Camera
https://bugzilla.redhat.com/show_bug.cgi?id=1583475 --- Comment #1 from Pavel Raiskup --- Copr: https://copr.fedorainfracloud.org/coprs/praiskup/airnef/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XQN5YRLUPVEGKLDTZHZ5AP4ATXBAKQN4/
