[Bug 1585308] Review Request: rubygem-jekyll-seo-tag - Jekyll plugin to add SEO metadata tags

2018-06-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1585308

Fabio Valentini  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-06-04 09:30:32



--- Comment #3 from Fabio Valentini  ---
Built for rawhide, and jekyll will be updated later today. Thanks!

https://koji.fedoraproject.org/koji/buildinfo?buildID=1088596

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/QFLHCD3DXJ2AVUZNY5A7S2NRYNZSPY7G/


[Bug 1585308] Review Request: rubygem-jekyll-seo-tag - Jekyll plugin to add SEO metadata tags

2018-06-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1585308



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rubygem-jekyll-seo-tag

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XZDUP62BTC4M54WUZ6OZLTJQ2D3UZMY4/


[Bug 1585308] Review Request: rubygem-jekyll-seo-tag - Jekyll plugin to add SEO metadata tags

2018-06-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1585308

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - You need to update Jekyll first to install this package:

DEBUG util.py:483:  BUILDSTDERR: Error: 
DEBUG util.py:483:  BUILDSTDERR:  Problem 1: conflicting requests
DEBUG util.py:483:  BUILDSTDERR:   - nothing provides (rubygem(jekyll) >= 3.3
with rubygem(jekyll) < 4) needed by rubygem-jekyll-seo-tag-2.5.0-1.fc29.noarch
DEBUG util.py:483:  BUILDSTDERR:  Problem 2: package
rubygem-jekyll-seo-tag-doc-2.5.0-1.fc29.noarch requires rubygem-jekyll-seo-tag
= 2.5.0-1.fc29, but none of the providers can be installed
DEBUG util.py:483:  BUILDSTDERR:   - conflicting requests
DEBUG util.py:483:  BUILDSTDERR:   - nothing provides (rubygem(jekyll) >= 3.3
with rubygem(jekyll) < 4) needed by rubygem-jekyll-seo-tag-2.5.0-1.fc29.noarch


Package approved.




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Package contains Requires: ruby(release).


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.