[Bug 1590453] Review Request: newsboat - terminal RSS/ATOM feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1590453 Jan Staněk changed: What|Removed |Added CC||jsta...@redhat.com --- Comment #9 from Jan Staněk --- *** Bug 1677291 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1590453] Review Request: newsboat - terminal RSS/ATOM feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1590453 l...@onesimussystems.com changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-06-25 11:35:31 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7JG24BVELSSNLFM3GWYZUE6JTOFFQKHZ/
[Bug 1590453] Review Request: newsboat - terminal RSS/ATOM feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1590453 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/newsboat -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/RO2YB5QBTGQ7HVAJW2QPVSHQEMLSXQJ5/
[Bug 1590453] Review Request: newsboat - terminal RSS/ATOM feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1590453 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KXNZT7F53DMDAQPPVZVUXCQM37BRE76E/
[Bug 1590453] Review Request: newsboat - terminal RSS/ATOM feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1590453 --- Comment #6 from l...@onesimussystems.com --- Changes made. Build is successful and installs/runs fine. Spec URL: https://pagure.io/newsboat-spec/blob/master/f/newsboat.spec SRPM URL: https://pagure.io/newsboat-spec/blob/master/f/newsboat-2.12-1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OW72WZNJE2SZHWPNVJQBYYL2NFUQOLAY/
[Bug 1590453] Review Request: newsboat - terminal RSS/ATOM feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1590453 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? --- Comment #5 from Robert-André Mauchin --- - %{_datadir}/doc/newsboat/* Remove the * to also own the directory - Bump to 2.12 - Use autosetup or %setup -q: %prep %autosetup -n %{name}-r%{version} - Instead of: %{_datadir}/locale/** use the %find_lang macro: %install %make_install prefix=%{_prefix} %find_lang %{name} %files -f %{name}.lang %license LICENSE %doc README.md Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 252 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/newsboat/review-newsboat/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package s
[Bug 1590453] Review Request: newsboat - terminal RSS/ATOM feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1590453 --- Comment #4 from l...@onesimussystems.com --- I've added a temporary workaround for the bug in asciidoc in rawhide. The docs won't be generated for anything greater than 28. Once the problem is resolved I'll remove the workaround. Please let me know if there's anything else I need to fix. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GVK5EFBTTH33YSWV54I4H7FQ5CMWAV53/
[Bug 1590453] Review Request: newsboat - terminal RSS/ATOM feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1590453 --- Comment #3 from l...@onesimussystems.com --- The spec file is updated. Same links as above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/D73ORRJ3MELZ4AKJPKEB7BT47VDT3D34/
[Bug 1590453] Review Request: newsboat - terminal RSS/ATOM feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1590453 --- Comment #2 from l...@onesimussystems.com --- I can't believe I missed that. I'll get it changed. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/JNUJTEUJRQWG6SILU4FJZ54Q66D4QV2O/
[Bug 1590453] Review Request: newsboat - terminal RSS/ATOM feed reader
https://bugzilla.redhat.com/show_bug.cgi?id=1590453 Artur Iwicki changed: What|Removed |Added CC||fed...@svgames.pl --- Comment #1 from Artur Iwicki --- >%make_install prefix=/usr Use %{_prefix}. Apart from that, looks good to me. Unfortunately I can't do a full review right now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KXJB6TGA5ZQ5IPBSG6RHSTV3CW4GKYVA/