[Bug 1590988] Review Request: freight - rpm/ systemd based container utility
https://bugzilla.redhat.com/show_bug.cgi?id=1590988
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- Group: is not used in Fedora
- Use %rpmmacrodir:
mkdir -p %{buildroot}%{rpmmacrodir}
mkdir -p %{buildroot}/usr/bin
mkdir -p %{buildroot}/%{_datadir}/freight/examples
install -m 0644 rpm_macros/macros.freight %{buildroot}%{rpmmacrodir}
install -m 0755 scripts/freight-cmd %{buildroot}/usr/bin/
install -m 0644 examples/* %{buildroot}/%{_datadir}/freight/examples
And in %files:
%{rpmmacrodir}/macros.freight
- Source URL is incorrect. Also use %global, not define:
%global githash c72ed55774bebdb35b5530b1c4bf9ae3c1472aa7
Source0: %url/freight/archive/%{githash}/freight-%{githash}.tar.gz
- Extraction dir is incorrect:
%prep
%autosetup -n %{name}-%{githash}
- There is no upstream release set, so Version: should be 0:
Version: 0
- Snapshot info must be prefixed by a Release number, here 0.1 since it's a
developnental snapshot:
Release: 0.1.20180613git%githash%{?dist}
- %changelog must be corrected accordingly:
* Wed Jun 13 2018 Neil Horman -
0-0.1.20180613gitc72ed55
- Remove the extraneous tabs after Name: freight and Requires: rpm rpm-build
mock bash dnf
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MRQLIM5OZTG4GYPCE6F3RPBT47CTCYND/
[Bug 1590988] Review Request: freight - rpm/ systemd based container utility
https://bugzilla.redhat.com/show_bug.cgi?id=1590988
--- Comment #3 from Robert-André Mauchin ---
I made a mistake:
- Source URL is incorrect.:
%global githashc72ed55774bebdb35b5530b1c4bf9ae3c1472aa7
%global shortcommit%(c=%{githash}; echo ${c:0:7})
Source0: %url/archive/%{githash}/freight-%{shortcommit}.tar.gz
- And Release info:
Release: 0.1.20180613git%{shortcommit}%{?dist}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FTRF4EVZD4C72PS57QYG6FY3IQTQTABW/
[Bug 1590988] Review Request: freight - rpm/ systemd based container utility
https://bugzilla.redhat.com/show_bug.cgi?id=1590988
--- Comment #2 from Robert-André Mauchin ---
I made a mistake:
- Source URL is incorrect.:
%global githashc72ed55774bebdb35b5530b1c4bf9ae3c1472aa7
%global shortcommit%(c=%{commit}; echo ${c:0:7})
Source0: %url/archive/%{githash}/freight-%{shortcommit}.tar.gz
- And Release info:
Release: 0.1.20180613git%{shortcommit}%{?dist}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/DPCRNHI7MZ6CISYSR2XBM6ASHYXZQLNT/
[Bug 1590988] Review Request: freight - rpm/ systemd based container utility
https://bugzilla.redhat.com/show_bug.cgi?id=1590988 --- Comment #4 from Neil Horman --- Thanks for the review. New spec and srpm Spec URL: https://nhorman.fedorapeople.org/freight.spec SRPM URL: https://nhorman.fedorapeople.org/freight-0-0.2.20180613gitc72ed55.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SD3BF3XSIOXZGKHBCVQPW56RGJKPAUE6/
[Bug 1590988] Review Request: freight - rpm/ systemd based container utility
https://bugzilla.redhat.com/show_bug.cgi?id=1590988
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #5 from Robert-André Mauchin ---
- You swapped the release digit in the changelog:
* Tue Jun 19 2018 Neil Horman -
0-0.1.20180613gitc72ed55
- initial creation
- There's already a package named freight:
https://src.fedoraproject.org/rpms/freight
Please find another name for the package.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://admin.fedoraproject.org/pkgdb/package/freight
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v2.1 or later)", "Unknown or generated". 6 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/freight/review-freight/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Review
[Bug 1590988] Review Request: freight - rpm/ systemd based container utility
https://bugzilla.redhat.com/show_bug.cgi?id=1590988 --- Comment #6 from Neil Horman --- freight.noarch: W: only-non-binary-in-usr-lib The above seems like a false positive, as the only file I have with a /usr/lib/ path is in /usr/lib/rpm/macros.d, which should definitely be non-binary The other issues, including naming I can take care of shortly. Thanks for the review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/H2CKUEH4EUFDXLEB23QYEWPOD6GUK2PO/
