[Bug 1594378] Review Request: ignition-dracut - dracut modules for ignition
https://bugzilla.redhat.com/show_bug.cgi?id=1594378 Neal Gompa changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2018-06-25 15:33:29 --- Comment #7 from Neal Gompa --- *** This bug has been marked as a duplicate of bug 1576879 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/RE25G53E2DOZJE2UBFOWQI6MSICIPYOF/
[Bug 1594378] Review Request: ignition-dracut - dracut modules for ignition
https://bugzilla.redhat.com/show_bug.cgi?id=1594378 --- Comment #6 from Dusty Mabe --- It was requested that I add ignition-dracut as a subpackage of ignition instead of a separate package. See https://bugzilla.redhat.com/show_bug.cgi?id=1576879#c16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ELQDK2KVWYBKCKOEEJ6AICVIXZR37I54/
[Bug 1594378] Review Request: ignition-dracut - dracut modules for ignition
https://bugzilla.redhat.com/show_bug.cgi?id=1594378 --- Comment #5 from Dusty Mabe --- (In reply to Neal Gompa from comment #4) > > I use repo2spec too, only because the aspect I want hasn't been broken out > into a subcommand yet. But I just copy the Provides: lines and overwrite > them in my spec file every time. Yeah I guess that's essentially what I'm doing too, but with an extra layer of "vimdiff" in there to make sure nothing else changed. Probably not needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ABLGAH5WPAPM37PZXB3GKI6PUPZFEHWX/
[Bug 1594378] Review Request: ignition-dracut - dracut modules for ignition
https://bugzilla.redhat.com/show_bug.cgi?id=1594378 --- Comment #4 from Neal Gompa --- (In reply to Dusty Mabe from comment #3) > (In reply to Neal Gompa from comment #2) > > Simple question, why are you regenerating the entire spec file every time > > for ignition with gofed? For snapd, I just use gofed to update the > > BuildRequires and Provides list. Generally, the rest of the spec doesn't > > change much. > > yeah. i'm a bit of a noob with go packaging. I tend to regenerate the spec > into a new file then vimdiff the old .orig and .spec file to see what I > changed last time. Then add those changes to the new spec I created and > check it all in (new .orig and new .spec). is there another command you use > other than `gofed repo2spec` ? I use repo2spec too, only because the aspect I want hasn't been broken out into a subcommand yet. But I just copy the Provides: lines and overwrite them in my spec file every time. It's not terribly difficult and because the rest of the spec rarely changes, it's pretty easy. In your case, you don't even really have to do BR checking, since you're using bundled dependencies (snapd is fully unbundled for Fedora). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/73GADGQ3CUN7UXM3PHAMRAYS7QI55WG3/
[Bug 1594378] Review Request: ignition-dracut - dracut modules for ignition
https://bugzilla.redhat.com/show_bug.cgi?id=1594378 --- Comment #3 from Dusty Mabe --- (In reply to Neal Gompa from comment #2) > Simple question, why are you regenerating the entire spec file every time > for ignition with gofed? For snapd, I just use gofed to update the > BuildRequires and Provides list. Generally, the rest of the spec doesn't > change much. yeah. i'm a bit of a noob with go packaging. I tend to regenerate the spec into a new file then vimdiff the old .orig and .spec file to see what I changed last time. Then add those changes to the new spec I created and check it all in (new .orig and new .spec). is there another command you use other than `gofed repo2spec` ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/6XTIJWDHVB5YHXGQ64MIOFAHE6H6XENW/
[Bug 1594378] Review Request: ignition-dracut - dracut modules for ignition
https://bugzilla.redhat.com/show_bug.cgi?id=1594378 --- Comment #2 from Neal Gompa --- Simple question, why are you regenerating the entire spec file every time for ignition with gofed? For snapd, I just use gofed to update the BuildRequires and Provides list. Generally, the rest of the spec doesn't change much. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/53XBEHEONXTX7DWJQOUD7QCGZERRZZQO/
[Bug 1594378] Review Request: ignition-dracut - dracut modules for ignition
https://bugzilla.redhat.com/show_bug.cgi?id=1594378 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/RFCXPXV3K7WDHZESCSQR4QNVR6CIYGHS/
