[Bug 1607124] Review Request: rust-cargo - Cargo, a package manager for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1607124 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-07-30 03:27:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VXCV7LKJZ72FYV5XKUKS46AUU3JQ33QY/
[Bug 1607124] Review Request: rust-cargo - Cargo, a package manager for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1607124 --- Comment #9 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/Y3KMXW4A6MQTAEN32Z2NRPFDJ5WBEP5Z/
[Bug 1607124] Review Request: rust-cargo - Cargo, a package manager for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1607124 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- Works in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=28702523 - License ok - Latest version packaged - Builds in mock - No rpmlint errors - you must install the license files with %license in %files. Package approved but don't forget to install the %license files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/TC7HYSGXWE256CAXSUETUGHYK4S727VO/
[Bug 1607124] Review Request: rust-cargo - Cargo, a package manager for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1607124 Josh Stone changed: What|Removed |Added CC||jist...@redhat.com --- Comment #7 from Josh Stone --- That User-Agent difference is just from using Fedora's libgit2 rather than the bundled one in rust-libgit2-sys. Perhaps that test should be using a regex to match the strings, so the exact libgit2 version doesn't matter. I'm already worried about the ABI in rust-libgit2-sys, as noted in bug 1584928, but that's at a deeper level than just the agent string. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/P2ZRGWMK7LVJSLFN7O3KSR7B537JAFUD/
[Bug 1607124] Review Request: rust-cargo - Cargo, a package manager for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1607124
--- Comment #6 from Robert-André Mauchin ---
Same tests still fail:
failures:
BUILDSTDERR: thread '' panicked at 'assertion failed: `(left ==
right)`
BUILDSTDERR: left: `{"Accept: */*", "User-Agent: git/2.0 (libgit2 0.26.5)",
"GET /foo/bar/info/refs?service=git-upload-pack HTTP/1.1"}`,
BUILDSTDERR: right: `{"Accept: */*", "User-Agent: git/2.0 (libgit2 0.27.0)",
"GET /foo/bar/info/refs?service=git-upload-pack HTTP/1.1"}`',
tests/testsuite/build_auth.rs:40:9
BUILDSTDERR: note: Run with `RUST_BACKTRACE=1` for a backtrace.
test build_auth::http_auth_offered ... FAILED
build_auth::http_auth_offered stdout
running `/builddir/build/BUILD/cargo-0.28.0/target/release/cargo build -v`
running `/builddir/build/BUILD/cargo-0.28.0/target/release/cargo build`
thread 'build_auth::http_auth_offered' panicked at 'called `Option::unwrap()`
on a `None` value', libcore/option.rs:335:21
build_script::custom_build_env_var_rustc_linker stdout
thread 'build_script::custom_build_env_var_rustc_linker' panicked at
'Cannot cross compile to i686-unknown-linux-gnu.
This failure can be safely ignored. If you would prefer to not see this
failure, you can set the environment variable CFG_DISABLE_CROSS_TESTS to "1".
', tests/testsuite/cargotest/support/cross_compile.rs:91:5
failures:
build_auth::http_auth_offered
build_script::custom_build_env_var_rustc_linker
test result: FAILED. 1283 passed; 2 failed; 4 ignored; 0 measured; 0 filtered
out
You could choose to ignore it although finding why it fails would be better.
Another problem: you must install the license files with %license in %files.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/D7R3T4C5QEPLWGRGY7DE5P6DZDC3AQIP/
[Bug 1607124] Review Request: rust-cargo - Cargo, a package manager for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1607124 --- Comment #5 from Igor Gnatenko --- New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-cargo.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-cargo-0.28.0-1.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MYPLFCZDM4RCITK7ULSVFXTVDBNX5BDG/
[Bug 1607124] Review Request: rust-cargo - Cargo, a package manager for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1607124 --- Comment #4 from Robert-André Mauchin --- The last 3 tests fail because you're missing git-core as a BR for the tests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WFYHSWQ7PLDH4IZIVKQ5EUNOLDMO24G3/
[Bug 1607124] Review Request: rust-cargo - Cargo, a package manager for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1607124
--- Comment #3 from Robert-André Mauchin ---
I can't build it so I can't continue the review without the patch.
I'll patch it myself then.
Tests failures:
failures:
build_auth::http_auth_offered stdout
running `/builddir/build/BUILD/cargo-0.28.0/target/release/cargo build -v`
running `/builddir/build/BUILD/cargo-0.28.0/target/release/cargo build`
thread 'build_auth::http_auth_offered' panicked at 'called `Option::unwrap()`
on a `None` value', libcore/option.rs:335:21
build_script::custom_build_env_var_rustc_linker stdout
thread 'build_script::custom_build_env_var_rustc_linker' panicked at
'Cannot cross compile to i686-unknown-linux-gnu.
This failure can be safely ignored. If you would prefer to not see this
failure, you can set the environment variable CFG_DISABLE_CROSS_TESTS to "1".
', tests/testsuite/cargotest/support/cross_compile.rs:91:5
new::author_prefers_cargo stdout
thread 'new::author_prefers_cargo' panicked at 'called `Result::unwrap()`
on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or
directory" }
could not execute process `git config --global user.name foo` (never
executed)', libcore/result.rs:945:5
new::finds_author_git stdout
thread 'new::finds_author_git' panicked at 'called `Result::unwrap()` on an
`Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory"
}
could not execute process `git config --global user.name bar` (never
executed)', libcore/result.rs:945:5
new::finds_local_author_git stdout
thread 'new::finds_local_author_git' panicked at 'called `Result::unwrap()`
on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or
directory" }
could not execute process `git init` (never executed)', libcore/result.rs:945:5
failures:
build_auth::http_auth_offered
build_script::custom_build_env_var_rustc_linker
new::author_prefers_cargo
new::finds_author_git
new::finds_local_author_git
test result: FAILED. 1280 passed; 5 failed; 4 ignored; 0 measured; 0 filtered
out
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2PU6QJ2QJKKBOEQLQKBHGG6TY2ZZDDOH/
[Bug 1607124] Review Request: rust-cargo - Cargo, a package manager for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1607124 --- Comment #2 from Igor Gnatenko --- (In reply to Robert-André Mauchin from comment #1) > DEBUG util.py:489: BUILDSTDERR: No matching package to install: > '(crate(termcolor) >= 0.3.0 with crate(termcolor) < 0.4.0)' I will patch it, it's just bump. Anything else? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LVU2BNRQB4SQHHDC3X7LZIVQQVYH3NXU/
[Bug 1607124] Review Request: rust-cargo - Cargo, a package manager for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1607124 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- DEBUG util.py:489: BUILDSTDERR: No matching package to install: '(crate(termcolor) >= 0.3.0 with crate(termcolor) < 0.4.0)' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CPYBLQQ47TUW5NMDL2WYBUVF6TJRL3K3/
