[Bug 1609038] Review Request: compliance-masonry - Security Documentation Builder
https://bugzilla.redhat.com/show_bug.cgi?id=1609038 redhatri...@gmail.com changed: What|Removed |Added Depends On|1614929 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1614929 [Bug 1614929] Review Request: golang-github-fatih-set - Set data structure for Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2OVBYJD24E7L63OVZUPWO2NVVRXHCNTO/
[Bug 1609038] Review Request: compliance-masonry - Security Documentation Builder
https://bugzilla.redhat.com/show_bug.cgi?id=1609038 ralf...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2018-08-13 20:06:43 --- Comment #6 from ralf...@redhat.com --- I opened this with the wrong email. Apologies for all involved. Closing as duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1615641 *** This bug has been marked as a duplicate of bug 1615641 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/K4RGZLJGCFKEWV7TQUHSXIKCFR2KENHY/
[Bug 1609038] Review Request: compliance-masonry - Security Documentation Builder
https://bugzilla.redhat.com/show_bug.cgi?id=1609038 redhatri...@gmail.com changed: What|Removed |Added Depends On||1614929 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1614929 [Bug 1614929] Review Request: golang-github-fatih-set - Set data structure for Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FRUDGM6SL4BB3CS4JTCIDF6L4BLRABUM/
[Bug 1609038] Review Request: compliance-masonry - Security Documentation Builder
https://bugzilla.redhat.com/show_bug.cgi?id=1609038 --- Comment #5 from ralf...@redhat.com --- > The source URL I provided is valid, check again. Doh! My bad. Typed it in wrong. > Could take months, packages are already being unbundled. Okay. Thanks for the review and answering questions. Will work through your comments. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FS26BKA6GTIFUOQEQOMFV7LY7CM7ECBQ/
[Bug 1609038] Review Request: compliance-masonry - Security Documentation Builder
https://bugzilla.redhat.com/show_bug.cgi?id=1609038
--- Comment #4 from Robert-André Mauchin ---
(In reply to ralford from comment #3)
> > - Use a more meaningful name for your archive:
> >
> > Source0:https://%{provider_prefix}/archive/v%{version}/%{name}-%
> > {version}.tar.gz
>
> That results in the source url no longer being valid and doesn't that go
> against the Fedora url guidelines which wants the actual source url?
>
The source URL I provided is valid, check again.
> > - Add a comment above the patch describing why it is needed.
>
> Will fix
>
> > - You should unbundle the dependencies and remove the vendor directory in
> > %prep (might take a while). That implies packaging any missing dependency.
>
> This was recommended to me by one of the package wranglers as well as the
> cri-o people until the GO packaging guidelines are finalized
>
Could take months, packages are already being unbundled.
> > - It is not ok to apply a patch on some architecture only. The arch
> > detection if needed should be in the patched code itself.
>
> Will fix
>
> > - with_bundled isn't defined anywhere.
>
> Will fix
>
> > There's a new way to package the Go libraries, see
> > https://fedoraproject.org/wiki/More_Go_packaging and samples:
> > https://eclipseo.fedorapeople.org/golang/
> >
> > It would be great to convert to the new style for F27-Rawhide and keep the
> > old style for EPEL7.
>
> That looks to be a proposal. Does the draft not have precedence?
Most Go packages have already been converted to the new style this past year.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YAYAM7OVJBDIQX2YJY4MUUTKRT7353PY/
[Bug 1609038] Review Request: compliance-masonry - Security Documentation Builder
https://bugzilla.redhat.com/show_bug.cgi?id=1609038
--- Comment #3 from ralf...@redhat.com ---
> - Use a more meaningful name for your archive:
>
> Source0:https://%{provider_prefix}/archive/v%{version}/%{name}-%
> {version}.tar.gz
That results in the source url no longer being valid and doesn't that go
against the Fedora url guidelines which wants the actual source url?
> - Add a comment above the patch describing why it is needed.
Will fix
> - You should unbundle the dependencies and remove the vendor directory in
> %prep (might take a while). That implies packaging any missing dependency.
This was recommended to me by one of the package wranglers as well as the cri-o
people until the GO packaging guidelines are finalized
> - It is not ok to apply a patch on some architecture only. The arch detection
> if needed should be in the patched code itself.
Will fix
> - with_bundled isn't defined anywhere.
Will fix
> There's a new way to package the Go libraries, see
> https://fedoraproject.org/wiki/More_Go_packaging and samples:
> https://eclipseo.fedorapeople.org/golang/
>
> It would be great to convert to the new style for F27-Rawhide and keep the
> old style for EPEL7.
That looks to be a proposal. Does the draft not have precedence?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/NU4EKNRDE2VUWBLWDS5RN5ZSHOYBM52S/
[Bug 1609038] Review Request: compliance-masonry - Security Documentation Builder
https://bugzilla.redhat.com/show_bug.cgi?id=1609038
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #2 from Robert-André Mauchin ---
- Use a more meaningful name for your archive:
Source0:
https://%{provider_prefix}/archive/v%{version}/%{name}-%{version}.tar.gz
- Add a comment above the patch describing why it is needed.
- You should unbundle the dependencies and remove the vendor directory in
%prep (might take a while). That implies packaging any missing dependency.
- It is not ok to apply a patch on some architecture only. The arch detection
if needed should be in the patched code itself.
- with_bundled isn't defined anywhere.
There's a new way to package the Go libraries, see
https://fedoraproject.org/wiki/More_Go_packaging and samples:
https://eclipseo.fedorapeople.org/golang/
It would be great to convert to the new style for F27-Rawhide and keep the old
style for EPEL7.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HFEXVX4QFIGARTIIHBEPLBUBZCYQDSJV/
[Bug 1609038] Review Request: compliance-masonry - Security Documentation Builder
https://bugzilla.redhat.com/show_bug.cgi?id=1609038 ralf...@redhat.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #1 from ralf...@redhat.com --- This is my first package. I would like to add it to EPEL7, F27, F28, F29, and Rawhide. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YVCEQCQPKZRVFOIPFXYEQ5MOF2SLPCI5/
