[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383 --- Comment #6 from Pavel Raiskup --- Thanks for the work on the package, btw.! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/PYENQWBETIVPHKG6EG5SG5XAIQZFEEFS/
[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383
Pavel Raiskup changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #5 from Pavel Raiskup ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Header files in -devel subpackage, if present.
Note: timescaledb-debugsource :
/usr/src/debug/timescaledb-0.10.1-1.fc29.x86_64/src/cache.h timescaledb-
debugsource :
praiskup: rhbz#1542507
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
praiskup: not true anymore, rhbz#1613069
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
praiskup: it's not on ldpath
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
(v2.0)". 310 files have unknown license. Detailed output of
licensecheck in /home/praiskup/1613383-timescaledb/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
praiskup: no subpackage
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/.build-id(iputils,
efivar-libs, gc, gdbm, gpgme, rpm-plugin-selinux, libnfsidmap, gdb-
headless, createrepo_c-libs, trousers, bzip2-libs, unzip, libdb-utils,
praisukp: broken fedora-review
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates
[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383
--- Comment #4 from Patrik Novotný ---
Spec URL:
https://gist.githubusercontent.com/UncleAlbie/cfa3c4d70adcf39befb8fde86024080b/raw/4df53d60b614594eeb2524f70af2c81c10eb0485/timescaledb.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/panovotn/timescaledb-test/fedora-rawhide-x86_64/00785720-timescaledb/timescaledb-0.10.1-1.fc29.src.rpm
Package name has been changed to 'timescaledb'. Requirements are now specified
by %{?postgresql_module_requires} macro.
ExcludeArch shouldn't be necessary as 64-bit installation is required only when
building on Windows.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/UOZLGBNDRTE6UZB42NNPXPGTTQSZEYMW/
[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383 --- Comment #3 from Pavel Raiskup --- Per upstream README prerequisities: A standard PostgreSQL 9.6 or 10 64-bit installation Does that mean that we should use ExcludeArch? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KILMO3ORWE5D2ZMFJHCKOY4F5IGE2SSE/
[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383 --- Comment #2 from Pavel Raiskup --- The `fedora-review -b 1613383 -m fedora-rawhide-x86_64` fails with: ERROR: Cannot find/open srpm: /tmp/1613383-postgresql-timescaledb/srpm/postgresql-timescaledb-0.10.1-1.fc28.src.rpm. Error: error reading package header Seems like the SRPM URL above isn't correct. Could you upload the file somewhere else? E.g. copr link should be OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VKWPKX6ERZ3L2LSZ4UKNXTSIT5EQC35T/
[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383
Pavel Raiskup changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|prais...@redhat.com
--- Comment #1 from Pavel Raiskup ---
> %define short_name timescaledb
> Name: postgresql-timescaledb
Please use 'Name: timescaledb'. Otherwise it evokes that the package comes
from postgresql.spec.
> BuildRequires: cmake gcc postgresql-devel
Since we install postgresql module, you should also use:
%{?postgresql_module_requires} macro.
Otherwise looks pretty nice. I'll have a look at fedora-review output
tomorrow.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/C5FQKC4QROMJZ3AIHH2OTLYIA4OMBTZ5/
[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383 Patrik Novotný changed: What|Removed |Added CC||prais...@redhat.com Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KAECMWCMEMIYF453B5N3PKZMYUBGD5PX/
