[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768 Kefu Chai changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed|2018-10-12 21:18:08 |2018-10-31 03:24:39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768 --- Comment #10 from Kefu Chai --- rawhive package built: https://apps.fedoraproject.org/packages/fmt and https://koji.fedoraproject.org/koji/taskinfo?taskID=30467968 i also started a thread at https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/Q4LJVZLHOQQFAY6TGYZ2LC4ZKGTHQKZ2/ for bumping up the fmt library. also, i contacted the kodi maintainers offline for the updated fmt library. currently, kodi is statically linked against libfmt.a at build-time, so this change should be invisible to the users which install existing kodi package(s). but once kodi is rebuilt with updated fmt-devel, kodi will depend on fmt which provides libfmt.so library. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768 Ken Dreyer changed: What|Removed |Added CC||ktdre...@ktdreyer.com Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #9 from Ken Dreyer --- I have worked with Kefu before, so I will sponsor him here. I've added you to the packagers group now, Kefu. Please let me know if you need assistance with the rest of the process. Happy packaging :) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- Package approved. You still need to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768
--- Comment #7 from Kefu Chai ---
(In reply to Robert-André Mauchin from comment #6)
> - Not used anymore for F28+
>
> %post -p /sbin/ldconfig
>
> %postun -p /sbin/ldconfig
>
> If you plan on packaging for EPEL7 or F27, use %ldconfig_scriptlets
yes, i plan to package for EPEL7. have changed to %ldconfig_scriptlets .
>
> - In order to avoid unintentional soname bump, we now forbid globbing the
> major soname version. Be more specific instead:
>
> %{_libdir}/libfmt.so.5*
>
> - %{_datarootdir} → %{_datadir}
>
thanks fixed all of them.
>
> (In reply to Kefu Chai from comment #4)
> > to understand the reverse dependencies of fmt, i ran following commands on
> > an update-to-date fedora28:
> >
> > $ for pkg in -devel "" -static -doc; do \
> > dnf repoquery -q --alldeps --whatrequires fmt$pkg; \
> > done
> > fmt-static-0:3.0.2-5.fc28.i686
> > fmt-static-0:3.0.2-5.fc28.x86_64
> > fmt-devel-0:3.0.2-5.fc28.i686
> > fmt-devel-0:3.0.2-5.fc28.x86_64
> >
> > $ for pkg in -devel "" -static -doc; do \
> > dnf repoquery --archlist=src --repoid=fedora-source -q --whatrequires
> > fmt$pkg; \
> > done
> > # nothing returned
> >
> >
> > so i think it's safe to update fmt{,-devel,-doc} on fedora28. and the same
> > is very likely to be true on rawhive.
>
> $ dnf repoquery --whatrequires fmt --enablerepo="*-source"
> fmt-devel-0:3.0.2-7.fc29.i686
> fmt-devel-0:3.0.2-7.fc29.x86_64
> kodi-gbm-0:18.0-0.10.b3.fc29.x86_64
> kodi-gbm-0:18.0-0.9.b2.fc29.x86_64
> kodi-wayland-0:18.0-0.10.b3.fc29.x86_64
> kodi-wayland-0:18.0-0.9.b2.fc29.x86_64
> kodi-x11-0:18.0-0.10.b3.fc29.x86_64
> kodi-x11-0:18.0-0.9.b2.fc29.x86_64
>
> dnf repoquery --whatrequires fmt-devel --enablerepo="*-source"
> fmt-static-0:3.0.2-7.fc29.i686
> fmt-static-0:3.0.2-7.fc29.x86_64
> kodi-0:18.0-0.10.b3.fc29.src
> kodi-0:18.0-0.9.b2.fc29.src
>
> Bumping fmt would requires rebuilding kodi. You'll need to announce the bump
> in the devel mailing list one week in advance and coordinate directly with
> the kodi* maintainers.
>
ahh! thank you! i checked the packaging of kodi. guess we will just need to
change
BuildRequires: fmt-devel
to
BuildRequires: fmt-devel >= 5.2.1
i will get in touch with kodi*'s maintainers over the devel mailing list.
>
>
> Package Review
> ==
>
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
>
>
> Issues:
> ===
> - ldconfig not called in %post and %postun for Fedora 28 and later.
> Note: /sbin/ldconfig called in fmt
> See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
>
>
> = MUST items =
>
> C/C++:
> [x]: Package does not contain kernel modules.
> [x]: Package contains no static executables.
> [x]: If your application is a C or C++ application you must list a
> BuildRequires against gcc, gcc-c++ or clang.
> [x]: Header files in -devel subpackage, if present.
> [x]: Package does not contain any libtool archives (.la)
> [x]: Rpath absent or only used for internal libs.
> [x]: Development (unversioned) .so files in -devel subpackage, if present.
>
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
> [x]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses
> found: "BSD (unspecified)", "BSD 2-clause "Simplified" License",
> "Expat License", "Unknown or generated", "BSD 3-clause "New" or
> "Revised" License". 185 files have unknown license. Detailed output of
> licensecheck in /home/bob/packaging/review/fmt/review-
> fmt/licensecheck.txt
> [x]: License file installed when any subpackage combination is installed.
> [x]: %build honors applicable compiler flags or justifies otherwise.
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [-]: Package contains desktop file if it is a GUI application.
> [x]: Development files must be in a -devel package
> [x]: Package uses nothing in %doc for runtime.
> [x]: Package consistently uses macros (instead of hard-coded directory
> names).
> [x]: Package is named according to the Package Naming Guidelines.
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [-]: If the package is a rename of another package, proper Obsoletes and
> Provides are present.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [-]: Package contains systemd file(s) if in need.
> [x]: Useful -debuginfo package or justification otherwise.
> [x]: Package is not known to require an ExcludeArch tag.
> [-]: Large documentation must go in a -doc
[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #6 from Robert-André Mauchin ---
- Not used anymore for F28+
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
If you plan on packaging for EPEL7 or F27, use %ldconfig_scriptlets
- In order to avoid unintentional soname bump, we now forbid globbing the
major soname version. Be more specific instead:
%{_libdir}/libfmt.so.5*
- %{_datarootdir} → %{_datadir}
(In reply to Kefu Chai from comment #4)
> to understand the reverse dependencies of fmt, i ran following commands on
> an update-to-date fedora28:
>
> $ for pkg in -devel "" -static -doc; do \
> dnf repoquery -q --alldeps --whatrequires fmt$pkg; \
> done
> fmt-static-0:3.0.2-5.fc28.i686
> fmt-static-0:3.0.2-5.fc28.x86_64
> fmt-devel-0:3.0.2-5.fc28.i686
> fmt-devel-0:3.0.2-5.fc28.x86_64
>
> $ for pkg in -devel "" -static -doc; do \
> dnf repoquery --archlist=src --repoid=fedora-source -q --whatrequires
> fmt$pkg; \
> done
> # nothing returned
>
>
> so i think it's safe to update fmt{,-devel,-doc} on fedora28. and the same
> is very likely to be true on rawhive.
$ dnf repoquery --whatrequires fmt --enablerepo="*-source"
fmt-devel-0:3.0.2-7.fc29.i686
fmt-devel-0:3.0.2-7.fc29.x86_64
kodi-gbm-0:18.0-0.10.b3.fc29.x86_64
kodi-gbm-0:18.0-0.9.b2.fc29.x86_64
kodi-wayland-0:18.0-0.10.b3.fc29.x86_64
kodi-wayland-0:18.0-0.9.b2.fc29.x86_64
kodi-x11-0:18.0-0.10.b3.fc29.x86_64
kodi-x11-0:18.0-0.9.b2.fc29.x86_64
dnf repoquery --whatrequires fmt-devel --enablerepo="*-source"
fmt-static-0:3.0.2-7.fc29.i686
fmt-static-0:3.0.2-7.fc29.x86_64
kodi-0:18.0-0.10.b3.fc29.src
kodi-0:18.0-0.9.b2.fc29.src
Bumping fmt would requires rebuilding kodi. You'll need to announce the bump in
the devel mailing list one week in advance and coordinate directly with the
kodi* maintainers.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- ldconfig not called in %post and %postun for Fedora 28 and later.
Note: /sbin/ldconfig called in fmt
See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (unspecified)", "BSD 2-clause "Simplified" License",
"Expat License", "Unknown or generated", "BSD 3-clause "New" or
"Revised" License". 185 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/fmt/review-
fmt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 92160 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note:
[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768 --- Comment #5 from Kefu Chai --- corp build: https://copr.fedorainfracloud.org/coprs/tchaikov/libfmt/build/812180/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768
--- Comment #4 from Kefu Chai ---
to understand the reverse dependencies of fmt, i ran following commands on an
update-to-date fedora28:
$ for pkg in -devel "" -static -doc; do \
dnf repoquery -q --alldeps --whatrequires fmt$pkg; \
done
fmt-static-0:3.0.2-5.fc28.i686
fmt-static-0:3.0.2-5.fc28.x86_64
fmt-devel-0:3.0.2-5.fc28.i686
fmt-devel-0:3.0.2-5.fc28.x86_64
$ for pkg in -devel "" -static -doc; do \
dnf repoquery --archlist=src --repoid=fedora-source -q --whatrequires
fmt$pkg; \
done
# nothing returned
so i think it's safe to update fmt{,-devel,-doc} on fedora28. and the same is
very likely to be true on rawhive.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768 Kefu Chai changed: What|Removed |Added Status|CLOSED |NEW Blocks||177841 (FE-NEEDSPONSOR) Resolution|NOTABUG |--- Keywords||Reopened --- Comment #3 from Kefu Chai --- Spec URL: https://raw.githubusercontent.com/tchaikov/libfmt/master/fmt.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/tchaikov/libfmt/fedora-28-x86_64/00811149-fmt/fmt-5.2.1-1.fc28.src.rpm Description: C++ Format is an open-source formatting library for C++. It can be used as a safe alternative to printf or as a fast alternative to IOStreams. Fedora Account System Username: tchaikov Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30288703 Review Description: this is my first package, and I would like to have a sponsor. I am reopening this bug, as the maintainer has orphaned the package. so I think to get the package uploaded I need to have a sponsor first. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768 Kefu Chai changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2018-10-12 21:18:08 --- Comment #2 from Kefu Chai --- Thank you Jason for the links and detailed instructions! they helped a lot. I didn't realize that fmt's rpm packaging is maintained using a gith repo. this is a lot easier to track the changes. will close this bug as NOTABUG, and send a PR instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768 --- Comment #1 from Jason Tibbitts --- But fmt is already in the distribution, so a package review ticket is not helpful. Name : fmt Version : 3.0.2 Release : 5.fc28 Arch : x86_64 Size : 43 k Source : fmt-3.0.2-5.fc28.src.rpm Repo : fedora Summary : Small, safe and fast formatting library for C++ URL : https://github.com/fmtlib/fmt License : BSD Description : C++ Format is an open-source formatting library for C++. It can be used as a : safe alternative to printf or as a fast alternative to IOStreams. https://src.fedoraproject.org/rpms/fmt If you were trying to get the existing version updated, you should work with the existing maintainer. Submit patches or a pull request. If the maintainer is unresponsive, begin the process to address that: https://fedoraproject.org/wiki/Policy_for_nonresponsive_package_maintainers. If there are bugs or the outdated version is blocking something, ask for the assistance of a provenpackager. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1638768] Review Request: fmt - Small, safe and fast formatting library for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1638768 Kefu Chai changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1465701 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
