[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 Mattia Verga changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |ERRATA Last Closed||2021-06-26 12:43:31 --- Comment #13 from Mattia Verga --- Package has been imported and then retired -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-zendframework-zenddiagnostics -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 --- Comment #11 from Remi Collet --- Thanks! SCM requests https://pagure.io/releng/fedora-scm-requests/issue/9831 https://pagure.io/releng/fedora-scm-requests/issue/9832 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #10 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 3-clause "New" or "Revised" License", "*No copyright* BSD
3-clause "New" or "Revised" License", "Unknown or generated". 94 files
have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/php-zendframework-zenddiagnostics/review-
php-zendframework-zenddiagnostics/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unles
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 --- Comment #9 from Remi Collet --- @Robert-André Mauchin can you please check with latest changes ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 Bug 1663283 depends on bug 1663245, which changed state. Bug 1663245 Summary: Review Request: php-sensiolabs-security-checker - A security checker for your composer.lock https://bugzilla.redhat.com/show_bug.cgi?id=1663245 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 --- Comment #8 from Remi Collet --- I will simply ignore these failure for now, and investigate them later https://git.remirepo.net/cgit/rpms/php/zendframework/php-zendframework-zenddiagnostics.git/commit/?id=52c9c6a9a7cdf1594286363b11db20a27eabfce1 Spec URL: https://git.remirepo.net/cgit/rpms/php/zendframework/php-zendframework-zenddiagnostics.git/plain/php-zendframework-zenddiagnostics.spec?id=52c9c6a9a7cdf1594286363b11db20a27eabfce1 SRPM URL: http://rpms.remirepo.net/SRPMS/php-zendframework-zenddiagnostics-1.4.0-2.remi.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=32741220 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 --- Comment #7 from Remi Collet --- Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=32740679 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 --- Comment #6 from Remi Collet --- Scratch build: I encounter another failure, because this test is 64-bit only 1) ZendDiagnosticsTest\DiskFreeTest::testJitFreeSpace Failed asserting that ZendDiagnostics\Result\Success Object (...) is an instance of interface "ZendDiagnostics\Result\FailureInterface". /builddir/build/BUILD/zend-diagnostics-79d0b7d0a1cab8f18e73d76ff1c2ec028f113840/test/DiskFreeTest.php:136 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 Bug 1663283 depends on bug 1663221, which changed state. Bug 1663221 Summary: Review Request: php-doctrine-migrations - PHP Doctrine Migrations project https://bugzilla.redhat.com/show_bug.cgi?id=1663221 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 --- Comment #5 from Remi Collet --- Very strange... I cannot reproduce, and InvalidArgumentException is exactly the expected / tested exception by this test... so not an error... Will try a scratch as soon as possible (when doctrine/migrations will be available) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 --- Comment #4 from Robert-André Mauchin --- I've got a test error: Time: 1.57 seconds, Memory: 10.00MB There was 1 error: 1) ZendDiagnosticsTest\DiskUsageTest::testCheck InvalidArgumentException: Invalid warningThreshold argument - expecting an integer between 1 and 100 /builddir/build/BUILDROOT/php-zendframework-zenddiagnostics-1.4.0-1.fc30.x86_64/usr/share/php/ZendDiagnostics/Check/DiskUsage.php:68 /builddir/build/BUILD/zend-diagnostics-79d0b7d0a1cab8f18e73d76ff1c2ec028f113840/test/DiskUsageTest.php:40 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 --- Comment #3 from Robert-André Mauchin --- My bad' didn't see the deps. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #2 from Robert-André Mauchin --- Build error: DEBUG util.py:490: BUILDSTDERR: No matching package to install: '(php-composer(doctrine/migrations) >= 1.0 with php-composer(doctrine/migrations) < 2)' DEBUG util.py:490: BUILDSTDERR: No matching package to install: '(php-composer(sensiolabs/security-checker) >= 5.0 with php-composer(sensiolabs/security-checker) < 6)' DEBUG util.py:490: BUILDSTDERR: Not all dependencies satisfied DEBUG util.py:490: BUILDSTDERR: Error: Some packages could not be found. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 --- Comment #1 from Remi Collet --- Updated to 1.4: https://git.remirepo.net/cgit/rpms/php/zendframework/php-zendframework-zenddiagnostics.git/commit/?id=603c4890fe391b283d61d7c2540168a02f68ae5c Spec URL: https://git.remirepo.net/cgit/rpms/php/zendframework/php-zendframework-zenddiagnostics.git/plain/php-zendframework-zenddiagnostics.spec?id=603c4890fe391b283d61d7c2540168a02f68ae5c SRPM URL: http://rpms.remirepo.net/SRPMS/php-zendframework-zenddiagnostics-1.4.0-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 Remi Collet changed: What|Removed |Added Depends On||1663245, 1663221 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1663221 [Bug 1663221] Review Request: php-doctrine-migrations - PHP Doctrine Migrations project https://bugzilla.redhat.com/show_bug.cgi?id=1663245 [Bug 1663245] Review Request: php-sensiolabs-security-checker - A security checker for your composer.lock -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
