[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #28 from Fedora Update System --- python-pipreqs-0.4.9-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-07-08 01:08:35 --- Comment #27 from Fedora Update System --- python-pipreqs-0.4.9-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #26 from Fedora Update System --- python-pipreqs-0.4.9-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c20719358e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #25 from Fedora Update System --- python-pipreqs-0.4.9-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2541fa7b35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #24 from Fedora Update System --- FEDORA-2019-c20719358e has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c20719358e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #23 from Fedora Update System --- FEDORA-2019-2541fa7b35 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2541fa7b35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #22 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pipreqs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #21 from Zbigniew Jędrzejewski-Szmek --- Looks OK. '-D' is repeated (that was my error). The package is already marked as accepted, so you can request the repo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #20 from Robert-André Mauchin --- (In reply to Dhanesh B. Sabane from comment #19) > (In reply to Robert-André Mauchin from comment #18) > > > Unfortunately, my 'fedora-review' does not work due to some issues with > > > 'mock'. As a result, I can't verify if the changes did work out well. Koji > > > builds complete successfully though. > > > > What kind of issue? Have you updated to the latest fedora-review 0.7.2? If > > yes please report any bug: https://pagure.io/FedoraReview/issues > > This is interesting. I have version 0.6.1. Repos on my system do not show > the 0.7.x versions. > > The issue is with the dnf cache. The error says: `Cannot run dnf makecache` > and fails with a bunch of "cache non-existent" errors. 0.7.x are in updates-testing. It will definitively solve your issue is now we run dnf makecache inside the mock chroot instead of the root system. Pick it up here: https://bodhi.fedoraproject.org/updates/?packages=fedora-review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #19 from Dhanesh B. Sabane --- (In reply to Robert-André Mauchin from comment #18) > > Unfortunately, my 'fedora-review' does not work due to some issues with > > 'mock'. As a result, I can't verify if the changes did work out well. Koji > > builds complete successfully though. > > What kind of issue? Have you updated to the latest fedora-review 0.7.2? If > yes please report any bug: https://pagure.io/FedoraReview/issues This is interesting. I have version 0.6.1. Repos on my system do not show the 0.7.x versions. The issue is with the dnf cache. The error says: `Cannot run dnf makecache` and fails with a bunch of "cache non-existent" errors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #18 from Robert-André Mauchin --- > Unfortunately, my 'fedora-review' does not work due to some issues with > 'mock'. As a result, I can't verify if the changes did work out well. Koji > builds complete successfully though. What kind of issue? Have you updated to the latest fedora-review 0.7.2? If yes please report any bug: https://pagure.io/FedoraReview/issues -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749
--- Comment #17 from Dhanesh B. Sabane ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #16)
> > for lib in %{python_sitelib}/${srcname}/*.py; do ...
>
> You probably need to move this section to the end of %install.
> ${srcname} → %{srcname}
> %{python_sitelib} → %{buildroot}%{python2_sitelib}
>
> > install -p build/man/pipreqs.1 -Dt %buildroot/%_mandir/man1/
>
> install -Dm0644 -p build/man/pipreqs.1 -Dt %buildroot/%_mandir/man1/
Thanks for the help! :)
I've pushed the latest changes. Please take a look and let me know.
Unfortunately, my 'fedora-review' does not work due to some issues with 'mock'.
As a result, I can't verify if the changes did work out well. Koji builds
complete successfully though.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Flags|needinfo?(zbys...@in.waw.pl |
|) |
--- Comment #16 from Zbigniew Jędrzejewski-Szmek ---
> for lib in %{python_sitelib}/${srcname}/*.py; do ...
You probably need to move this section to the end of %install.
${srcname} → %{srcname}
%{python_sitelib} → %{buildroot}%{python2_sitelib}
> install -p build/man/pipreqs.1 -Dt %buildroot/%_mandir/man1/
install -Dm0644 -p build/man/pipreqs.1 -Dt %buildroot/%_mandir/man1/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 Dhanesh B. Sabane changed: What|Removed |Added Flags||needinfo?(zbys...@in.waw.pl ||) --- Comment #15 from Dhanesh B. Sabane --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #14) > rpmlint: > python3-pipreqs.noarch: E: wrong-script-interpreter > /usr/lib/python3.7/site-packages/pipreqs/pipreqs.py /usr/bin/env python > python3-pipreqs.noarch: E: non-executable-script > /usr/lib/python3.7/site-packages/pipreqs/pipreqs.py 644 /usr/bin/env python I believe these errors are due to the shebang lines. But I do have a small piece of code in the '%prep' section that should handle this case. I'm not sure why it's still an issue. Will you please help me resolve this? > python3-pipreqs.noarch: W: spurious-executable-perm > /usr/share/man/man1/pipreqs.1.gz > I'm thinking this can be fixed using '%defattr' in the '%files' section. Is that an acceptable fix? > Those are not very important, but correct. Please consider fixing them. > > Package is APPROVED. Thanks! I'll resolve the previous issues before pushing the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
Flags||fedora-review+
--- Comment #14 from Zbigniew Jędrzejewski-Szmek ---
This library generates a 'requirements.txt' file for any project
→ This library generates a 'requirements.txt' file for any Python project
BuildRequires (and other dependencies) should be one-per-line:
BuildRequires: %{py3_dist docopt setuptools yarg sphinx}
→ BuildRequires: %{py3_dist docopt}
BuildRequires: %{py3_dist setuptools}
...
+ package name is OK (and subpackages too)
+ license is acceptable for Fedora (ASL 2)
+ license is specified correctly
+ latest version (upstream seems to have tagged 0.4.7 as the latest, but has
0.4.8 in the changelog, and 0.4.9 on pypi.)
+ builds and installs OK
+ requires/provides look OK
rpmlint:
python3-pipreqs.noarch: E: wrong-script-interpreter
/usr/lib/python3.7/site-packages/pipreqs/pipreqs.py /usr/bin/env python
python3-pipreqs.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/pipreqs/pipreqs.py 644 /usr/bin/env python
python3-pipreqs.noarch: W: spurious-executable-perm
/usr/share/man/man1/pipreqs.1.gz
Those are not very important, but correct. Please consider fixing them.
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #13 from Dhanesh B. Sabane --- Spec URL: https://pagure.io/rpm-packaging/raw/master/f/python-pipreqs/python-pipreqs.spec SRPM URL: https://pagure.io/rpm-packaging/raw/master/f/python-pipreqs/python-pipreqs-0.4.9-1.fc29.src.rpm Fixed the Spec file as per Hirotaka Wakabayashi's comments and rebuilt the package. Koji Builds: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=34307033 Fedora 29: https://koji.fedoraproject.org/koji/taskinfo?taskID=34307190 Fedora 30: https://koji.fedoraproject.org/koji/taskinfo?taskID=34307224 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #12 from Zbigniew Jędrzejewski-Szmek --- Add BuildRequires: python3-spinx, and in %build add 'sphinx-build -b man docs build/man/', and in %install add 'install -p build/man/pipreqs.1 -Dt %buildroot/%_mandir/man1/' and in %files add '%_mandir/man1/pipreqs.1*'. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #11 from Dhanesh B. Sabane --- Hello folks! I need some help with including the manual page. The docs directory in the source contains a Makefile that provides `man` as a target to build the manual page. How can I emulate this process in the spec file and use the resulting manual page in %files? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||zbys...@in.waw.pl --- Comment #10 from Zbigniew Jędrzejewski-Szmek --- > 3. Package Naming > -- > > "python-pipreqs-do" should be "python3-pipreqs-do". > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming I assume that was about "-doc". That request is not supported by the guidelines. The binary python package name should be 'python3-*', and it already is. The docs subpackage can be named after the source package. Can we haz a fuller %description please? This is not the run-of-the-mill obvious python library, it'd be nice to have a paragraph or two that explain what this package does. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #9 from Robert-André Mauchin --- CC me. Please address Hirotaka Wakabayashi's comments and I'll finish the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749
Hirotaka Wakabayashi changed:
What|Removed |Added
CC||hiw...@yahoo.com
--- Comment #8 from Hirotaka Wakabayashi ---
(In reply to Dhanesh B. Sabane from comment #6)
> Spec URL:
> https://pagure.io/rpm-packaging/raw/master/f/python-pipreqs/python-pipreqs.
> spec
> SRPM URL:
> https://pagure.io/rpm-packaging/raw/master/f/python-pipreqs/python-pipreqs-0.
> 4.9-1.fc29.src.rpm
>
> Fixed the SRPM URL to point to the raw file.
Hello, this is an unofficial review for your reference.
Summary
1. Koji scratch build succeeded
2. Rpmlint issues
3. Package Naming
4. Licensing
5. Spec Legibility
6. Package Dependencies
7. Manpages
8. TestSuites
9. Shebang lines
Appendix 1. rpmlint full outputs
Appendix 2. an example spec file
Details
1. Koji scratch build succeeded
-
https://koji.fedoraproject.org/koji/taskinfo?taskID=32281857
2. Rpmlint issues
--
See Appendix 1 for full outputs of rpmlint. Here is summarized outputs here.
1 packages and 0 specfiles checked; 0 errors, 6 warnings on source rpm::
python-pipreqs.src: W: spelling-error Summary(en_US) txt -> text, ext, tit
python-pipreqs.src: W: spelling-error %description -l en_US txt -> text, ext,
tit
python-pipreqs.src: W: spelling-error %description -l en_US projct ->
project, pro jct, pro-jct
python-pipreqs.src:55: W: macro-in-comment %check
python-pipreqs.src:56: W: macro-in-comment %{__python3}
python-pipreqs.src: W: invalid-license Apache License
1 packages and 0 specfiles checked; 2 errors, 5 warnings on binary rpm::
python3-pipreqs.noarch: W: spelling-error Summary(en_US) txt -> text, ext,
tit
python3-pipreqs.noarch: W: spelling-error %description -l en_US txt -> text,
ext, tit
python3-pipreqs.noarch: W: spelling-error %description -l en_US projct ->
project, pro jct, pro-jct
python3-pipreqs.noarch: W: invalid-license Apache License
python3-pipreqs.noarch: E: wrong-script-interpreter
/usr/lib/python3.7/site-packages/pipreqs/pipreqs.py /usr/bin/env python
python3-pipreqs.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/pipreqs/pipreqs.py 644 /usr/bin/env python
python3-pipreqs.noarch: W: no-manual-page-for-binary pipreqs
1 packages and 0 specfiles checked; 0 errors, 2 warnings on document rpm::
python-pipreqs-doc.noarch: W: summary-not-capitalized C pipreqs documentation
python3-pipreqs.noarch: W: invalid-license Apache License
3. Package Naming
--
"python-pipreqs-do" should be "python3-pipreqs-do".
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming
4. Licensing
-
"Apache License" should be "ASL 2.0".
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
"%license LICENSE" in the "doc" package is not needed according to the
following
guideline.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing
5. Spec Legibility
---
You may use the %{py3_dist} macro for legibility like::
"BuildRequires: %{py3_dist setuptools docopt yarg sphinx}".
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_requires_and_buildrequires_with_standardized_names
6. Package Dependencies
The "%{?python_enable_dependency_generator}" macro is useful when upstream
provides egg-info metadata. For example::
...
%package -n python3-%{srcname}
Summary:%{summary}
%{?python_provide:%python_provide python3-%{srcname}}
%{?python_enable_dependency_generator}
%description -n python3-%{srcname} %_description
...
The macro will automatically generates following requires::
$ rpm -q --requires python3-pipreqs
/usr/bin/python3
python(abi) = 3.7
python3.7dist(docopt)
python3.7dist(yarg)
...
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies
7. Manpages
A manpage for "pipreqs" should be contained.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
8. Test Suites
--
A test suite should be executed in the %check section if upstream provides it
and it is practical. I think there should be a spec file comment if you don't
execute it for some reason.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites
9. Shebang lines
/usr/bin/env MUST NOT be used.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines
Appendix 1. rpmlint full outputs
-
$ rpmlint -i python-pipreqs-0.4.9-1.fc29.src.rpm
python-pipreqs.src: W: spelling-error Summary(en_US) txt -> text, ext, tit
The value of this tag appears to be misspelled. Please double-check.
python-pipreqs.src: W: spelling-error %descri
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #7 from Raphael Groner --- Maybe review swap with bug #1669793? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #6 from Dhanesh B. Sabane --- Spec URL: https://pagure.io/rpm-packaging/raw/master/f/python-pipreqs/python-pipreqs.spec SRPM URL: https://pagure.io/rpm-packaging/raw/master/f/python-pipreqs/python-pipreqs-0.4.9-1.fc29.src.rpm Fixed the SRPM URL to point to the raw file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #5 from Dhanesh B. Sabane --- (In reply to Raphael Groner from comment #2) > Are you interested in a review swap? Maybe you could look into bug #1659777. Hello Raphael! I'd definitely be interested in it. But seems like I was a bit late and Igor has beat me to it. Let me know if you have any other package that is pending review. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #4 from Raphael Groner --- (In reply to Elliott Sales de Andrade from comment #3) > The posted SRPM appears to be an HTML file. The given link works for me. Maybe I misunderstand something. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #3 from Elliott Sales de Andrade --- The posted SRPM appears to be an HTML file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 --- Comment #2 from Raphael Groner --- Are you interested in a review swap? Maybe you could look into bug #1659777. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports
https://bugzilla.redhat.com/show_bug.cgi?id=1665749 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #1 from Raphael Groner --- Are you interested in a review swap? Maybe you could look into büg #1659777. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
