[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-02-27 03:28:43 --- Comment #16 from Fedora Update System --- cheat-2.5.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 --- Comment #15 from Fedora Update System --- cheat-2.5.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- cheat-2.5.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-90e2fc2614 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #13 from Fedora Update System --- cheat-2.5.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-90e2fc2614 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- cheat-2.5.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-294b6d60fb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #11 from Fedora Update System --- cheat-2.5.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-294b6d60fb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cheat -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 --- Comment #9 from Tomas Korbar --- Thanks for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 Gergely Gombos changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 --- Comment #8 from Gergely Gombos --- Super! In the above review, all of the issues have been corrected: - License field updated - Manpage is installed uncompressed - Changelog updated - URL updated - Version updated - Specfile and SRPM match. So I approve of the package. Good luck for building and let me know if you have questions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 --- Comment #7 from Tomas Korbar --- Changelog updated. While we were working on this, rawhide changed to f31, so i'm providing srpms for both f30 and f31. Updated specfile: https://tkorbar.fedorapeople.org/cheat.spec Updated SRPM for f30: https://tkorbar.fedorapeople.org/cheat-2.5.1-1.fc30.src.rpm Updated SRPM for f31: https://tkorbar.fedorapeople.org/cheat-2.5.1-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 --- Comment #6 from Gergely Gombos --- Awesome! :) Looks good, please add a changelog entry after modifying the spec file. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_multiple_changelog_entries_per_release. Then I'll run a final review and approve. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 Tomas Korbar changed: What|Removed |Added Flags|needinfo?(tkor...@redhat.co | |m) | --- Comment #5 from Tomas Korbar --- Hi Gergely, Updated specfile: https://tkorbar.fedorapeople.org/cheat.spec Updated SRPM: https://tkorbar.fedorapeople.org/cheat-2.5.1-1.fc30.src.rpm I hope i solved all problems. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 Gergely Gombos changed: What|Removed |Added CC||tkor...@redhat.com Flags||needinfo?(tkor...@redhat.co ||m) --- Comment #4 from Gergely Gombos --- I'm taking this review, Tomas, I'm waiting for package updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 Gergely Gombos changed: What|Removed |Added Assignee|nob...@fedoraproject.org|gomb...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 --- Comment #3 from Dominik 'Rathann' Mierzejewski --- Gergely, as I have just sponsored you into the packager group, you can take this review officially (assign to yourself) and continue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added CC||domi...@greysector.net --- Comment #2 from Dominik 'Rathann' Mierzejewski --- Good review, Gergely. I have only one additional comment: To remain future-looking, the manpage should be installed uncompressed in %install. It gets compressed by rpm build scripts anyway, with the currently chosen compression tool. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670070] Review Request: cheat - Help for various commands and their usecases
https://bugzilla.redhat.com/show_bug.cgi?id=1670070
Gergely Gombos changed:
What|Removed |Added
CC||gomb...@gmail.com
--- Comment #1 from Gergely Gombos ---
Hi, here's an unofficial review. It's a first time review for me so I used the
complete review list to follow through all the points.
I like cheat, it's a great companion to tldr, I'd love to see this in Fedora.
:)
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
-> Dual license is marked, see rpmlint errors
[x]: License field in the package spec file matches the actual license.
-> No 'other license' files found.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
-> You can make https://github.com/chrisallenlane/cheat into %url and use
that in URL and Source0 fields.
[x]: Package is named according to the Package Naming Guidelines.
-> It's an app, no ptyhon prefix needed.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
-> In accordance with setup.py
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
-> See rpmlint part
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[!]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
-> You can include all 3 license files at %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
-> This is mostly relevant for the man file.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
-> All dependencies are covered in BuildRequires.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
-> Providing python3-cheat is not needed here, since it's not a library
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane.
[x]: Package functions as described.
-> Installs and runs just fine. Man page works.
[!]: Latest version is packaged.
-> Bump to 2.5.0
[x]: Package does not include license text files separate fr
