https://bugzilla.redhat.com/show_bug.cgi?id=1672903
Peter Lemenkov changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Peter Lemenkov ---
REVIEW:
[+] rpmlint is silent (or produces only messages which can be safely ignored:
Auriga ~/rpmbuild/SPECS: rpmlint ../SRPMS/erlang-hex_core-0.4.0-1.fc29.src.rpm
../RPMS/noarch/erlang-hex_core-0.4.0-1.fc29.noarch.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Auriga ~/rpmbuild/SPECS:
[+] The package is named according to the Package Naming Guidelines.
[+] The spec file name matches the base package %{name}, in the format
%{name}.spec.
[+] The package meets the Packaging Guidelines (incl. yet officially promoted
Erlang Packaging Guidelines).
[+] The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
[+] The License field in the package spec file matches the actual license
(Apache 2.0).
[+] The file, containing the text of the license(s) for the package, is
included in %doc and marked as %license.
[+] The spec file is written in American English.
[+] The spec file for the package is legible.
[+] The sources used to build the package matches the upstream source, as
provided in the spec URL.
Auriga ~/rpmbuild/SOURCES: sha256sum hex_core-0.4.0.tar*
8ace8c6cfa10df4cb8be876f42f7446890e124203c094cc7b4e7616fb8de5d7f
hex_core-0.4.0.tar
8ace8c6cfa10df4cb8be876f42f7446890e124203c094cc7b4e7616fb8de5d7f
hex_core-0.4.0.tar.1
Auriga ~/rpmbuild/SOURCES:
[+] The package successfully compiles and builds into binary rpms (tested on my
machine).
[+] All build dependencies are listed in BuildRequires.
[0] No need to handle locales.
[0] The package does not contain any shared library files.
[+] Packages does not bundle copies of system libraries.
[+] The package isn't designed to be relocatable.
[+] The package owns all directories that it creates.
[+] The package does not list a file more than once in the spec file's %files
listings.
[+] Permissions on files are set properly.
[+] The package consistently uses macros.
[+] The package contains code, or permissible content.
[0] No large documentation files.
[+] Anything, the package includes as %doc, does not affect the runtime of the
application.
[0] No static libraries.
[0] No -devel sub-package.
[+] The package does not contain any .la libtool archives.
[0] Not a GUI application.
[+] The package does not own files or directories already owned by other
packages.
[+] All filenames in rpm packages are valid UTF-8.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
