[Bug 1672994] Review Request: spread-sheet-widget - A library for Gtk+ which provides a spread sheet widget
https://bugzilla.redhat.com/show_bug.cgi?id=1672994 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-02-26 03:05:10 --- Comment #12 from Fedora Update System --- spread-sheet-widget-0.3-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672994] Review Request: spread-sheet-widget - A library for Gtk+ which provides a spread sheet widget
https://bugzilla.redhat.com/show_bug.cgi?id=1672994 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- spread-sheet-widget-0.3-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-82708a56e1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672994] Review Request: spread-sheet-widget - A library for Gtk+ which provides a spread sheet widget
https://bugzilla.redhat.com/show_bug.cgi?id=1672994 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #10 from Fedora Update System --- spread-sheet-widget-0.3-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-82708a56e1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672994] Review Request: spread-sheet-widget - A library for Gtk+ which provides a spread sheet widget
https://bugzilla.redhat.com/show_bug.cgi?id=1672994 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- spread-sheet-widget-0.3-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-61fa9f7489 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672994] Review Request: spread-sheet-widget - A library for Gtk+ which provides a spread sheet widget
https://bugzilla.redhat.com/show_bug.cgi?id=1672994 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #7 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/spread-sheet-widget --- Comment #8 from Fedora Update System --- spread-sheet-widget-0.3-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-61fa9f7489 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672994] Review Request: spread-sheet-widget - A library for Gtk+ which provides a spread sheet widget
https://bugzilla.redhat.com/show_bug.cgi?id=1672994
Elliott Sales de Andrade changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags||fedora-review+
--- Comment #6 from Elliott Sales de Andrade ---
> Source0: https://alpha.gnu.org/gnu/ssw/spread-sheet-widget-0.3.tar.gz
Can replace 0.3 with %{version} so you don't have to keep updating it.
> %{_libdir}/lib%{name}.so.0.0.0
You probably want to make this .so.0.*, because that's the only number that
matters.
These are minor things, so approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672994] Review Request: spread-sheet-widget - A library for Gtk+ which provides a spread sheet widget
https://bugzilla.redhat.com/show_bug.cgi?id=1672994 --- Comment #5 from Peter Lemenkov --- (In reply to Peter Lemenkov from comment #4) > > - There is something wrong with the linking of the shared library. It uses > > GTK > > and GObject symbols, but it not linked to them. Consequently, the main rpm > > does not depend on either. > > > ... > > > > [!]: Final provides and requires are sane (see attachments). > > > I'll look into this. Hold on. Done. I've added patch to link main libraries against GTK3 and GLIB2 (in the same way they do with examples). Spec URL: https://peter.fedorapeople.org/packages/spread-sheet-widget.spec SRPM URL: https://peter.fedorapeople.org/packages/spread-sheet-widget-0.3-1.fc29.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=32775788 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672994] Review Request: spread-sheet-widget - A library for Gtk+ which provides a spread sheet widget
https://bugzilla.redhat.com/show_bug.cgi?id=1672994 --- Comment #4 from Peter Lemenkov --- (In reply to Elliott Sales de Andrade from comment #2) > This is mostly good; a few minor issues: > > - You have COPYING doubly listed in %doc and %license. Done. > - Should add the soversion to the %files to prevent unintentional soname > breaks. Neat trick! Will do the same in some my other packages. Done. > - BuildRequires:pkgconfig is unnecessary since you already require some > pkgconfig files. Done. > - Use %make_build. Done. > - There is something wrong with the linking of the shared library. It uses > GTK > and GObject symbols, but it not linked to them. Consequently, the main rpm > does not depend on either. > ... > > [!]: Final provides and requires are sane (see attachments). I'll look into this. Hold on. > [!]: %check is present and all tests pass. Added a check section. Just in case upstream adds tests in a future. (In reply to Elliott Sales de Andrade from comment #3) > Also, the pc.in file should not be executable; there's a warning about this > during the build and it's automatically corrected. Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672994] Review Request: spread-sheet-widget - A library for Gtk+ which provides a spread sheet widget
https://bugzilla.redhat.com/show_bug.cgi?id=1672994 --- Comment #3 from Elliott Sales de Andrade --- Also, the pc.in file should not be executable; there's a warning about this during the build and it's automatically corrected. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672994] Review Request: spread-sheet-widget - A library for Gtk+ which provides a spread sheet widget
https://bugzilla.redhat.com/show_bug.cgi?id=1672994 Elliott Sales de Andrade changed: What|Removed |Added Status|NEW |ASSIGNED CC||quantum.anal...@gmail.com Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com --- Comment #2 from Elliott Sales de Andrade --- This is mostly good; a few minor issues: - You have COPYING doubly listed in %doc and %license. - Should add the soversion to the %files to prevent unintentional soname breaks. - BuildRequires:pkgconfig is unnecessary since you already require some pkgconfig files. - Use %make_build. - There is something wrong with the linking of the shared library. It uses GTK and GObject symbols, but it not linked to them. Consequently, the main rpm does not depend on either. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "FSF All Permissive License", "GPL (v3 or later)", "Unknown or generated", "GNU Free Documentation License (v1.3)", "GPL (v7)", "GNU Free Documentation License (v1.3 or later)", "Expat License", "FSF Unlimited License (with Retention) GNU General Public License", "FSF Unlimited License (with Retention)". 27 files have unknown license. Detailed output of licensecheck in 1672994-spread-sheet-widget/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(R-date, kde-platform-plugin, libreport-plugin-kerneloops, libhbalinux, cups- client, efivar-libs, netcdf, python3-cffi, librsync, qemu-block- gluster, perl-Cpanel-JSON-XS, rpm-plugin-selinux, abrt, ghc- transformers, ghc-parallel, libmediaart, cygwin64-gcc-gfortran, python3-qt5-webkit, libimagequant, giflib, libreoffice-graphicfilter, openmpi, xsel, libfaketime, trousers, dirac-libs, gst-devtools, qemu- ui-gtk, python2-h5py, libdb-utils, tracker-miners, xorg-x11-font- utils, PackageKit-command-not-found, OpenEXR-libs, ghc-monad-par- extras, libcom_err, libseccomp, double-conversion, flare-engine, ksysguardd, mingw64-qt-qmake, openblas-openmp64_, p11-kit, fcgi, libabw, ghc-wai-extra, libvirt-daemon-driver-storage-iscsi, libid3tag, libmodman, ghc-semigroups, telepathy-gabble, cfitsio, argyllcms, parted, gnome-disk-utility, libdvdread, zstd, bluez-libs, xml- security-c, kf5-kjobwidgets, ghc-uniplate, libwebp, libxslt, quesoglc, herqq, netty-tcnative, system-config-printer-udev, python3-netifaces, ghc-criterion, python2-nss, mingw64-gcc, libverto-libev, python2-cryptography, kf5-kdeclarative, libevdev, libgpg-error, libmaxminddb, lvm2-libs, kf5-sonnet-core, libpurple, perl-Digest-SHA, abrt-gui, perl-Params-Classify, libmicrohttpd, portmidi, med, R-httpuv, mlt, python3-unbound, ghc-prelude-extras, kf5-solid, libzstd, ghc-bsb-http-chunked, wxBase, libdazzle, xdg-desktop-portal- gtk, ghc-mmorph, lua-lpeg, symlinks, python3-simplejson, perl-Unicode- String, python3-crypto, armacycles-ad, libcdr, ghc-shakespeare, e2fsprogs-libs, pulseaudio-libs, libdwarf, wxGTK3-webview, tpm2-tools, lcms2, docker-rhel-push-plugin, python3-Bottleneck, avra, qemu-guest- agent, annobin, ntfs-3g, python3-pycosat, libxcb, texlive-chktex, freexl, libyubikey, remmina-plugins-st, libbdplus, python3-pycurl, python3-brlapi, postgresql-libs, mingw64-binutils, CUnit, xcb-util- keysyms, angelscript, celestia, ghc-data-default-instances-dlist, m4, python26, perl-GSSAPI, ghc-StateVar, sushi, libgphoto2, festival-lib, libsavitar, R-XML, R-fansi, festival, tinyxml, xcb-util, libwmf-lite, clutter-gtk, icoutils, python3-PyQt4-webkit, python3-coverage, ghc- cpphs, krb5-devel, gcc-objc++, python2-wrapt, poppler-qt, alsa- plugins-pulseaudio, http-parser, qt5-qtspeech, R-fts, pulseaudio- utils, perl-Sub-Identify, R-openssl, llvm5.0-libs, rubygem-hpricot, perl-PerlIO-utf8_strict, kf5-kdelibs4support-libs, python2-pyqt4-sip, pyorbit, openjpe
[Bug 1672994] Review Request: spread-sheet-widget - A library for Gtk+ which provides a spread sheet widget
https://bugzilla.redhat.com/show_bug.cgi?id=1672994 Peter Lemenkov changed: What|Removed |Added CC||pleme...@redhat.com --- Comment #1 from Peter Lemenkov --- *** Bug 1672991 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
