[Bug 1678006] Review Request: segyio - fast read/write of seismic files in SEG-Y
https://bugzilla.redhat.com/show_bug.cgi?id=1678006 Mattia Verga changed: What|Removed |Added Status|NEW |CLOSED Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed||2021-07-25 14:19:34 --- Comment #8 from Mattia Verga --- Jørgen, thanks for the reply. I'll close this ticket as DEADREVIEW, then. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1678006] Review Request: segyio - fast read/write of seismic files in SEG-Y
https://bugzilla.redhat.com/show_bug.cgi?id=1678006 Jørgen Kvalsvik changed: What|Removed |Added Flags|needinfo?(jo...@equinor.com | |) | --- Comment #7 from Jørgen Kvalsvik --- I would say this packaging is out-of-date (many upstream releases since then, with some building modifications), and I am no longer responsible for upstream. I will not follow up on packaging, which means that the package needs a new sponsor and maintainer if this is to continue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1678006] Review Request: segyio - fast read/write of seismic files in SEG-Y
https://bugzilla.redhat.com/show_bug.cgi?id=1678006 Mattia Verga changed: What|Removed |Added Status|POST|NEW Assignee|zebo...@gmail.com |nob...@fedoraproject.org Flags|fedora-review+ |needinfo?(jo...@equinor.com ||) --- Comment #6 from Mattia Verga --- Review stalled -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1678006] Review Request: segyio - fast read/write of seismic files in SEG-Y
https://bugzilla.redhat.com/show_bug.cgi?id=1678006 Jørgen Kvalsvik changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1678006] Review Request: segyio - fast read/write of seismic files in SEG-Y
https://bugzilla.redhat.com/show_bug.cgi?id=1678006 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Robert-André Mauchin --- All ok, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1678006] Review Request: segyio - fast read/write of seismic files in SEG-Y
https://bugzilla.redhat.com/show_bug.cgi?id=1678006 --- Comment #4 from Jørgen Kvalsvik --- spec: https://nofile.io/f/n7okOHMNktm/segyio.spec sprm: https://nofile.io/f/K5swKaWw7Wj/segyio-1.8.3-1.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1678006] Review Request: segyio - fast read/write of seismic files in SEG-Y
https://bugzilla.redhat.com/show_bug.cgi?id=1678006
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #3 from Robert-André Mauchin ---
- Build error:
BUILDSTDERR: Download error on https://pypi.org/simple/pytest-runner/: [Errno
-2] Name or service not known -- Some packages may not be found!
BUILDSTDERR: Couldn't find index page for 'pytest-runner' (maybe misspelled?)
BUILDSTDERR: Download error on https://pypi.org/simple/setuptools-scm/: [Errno
-2] Name or service not known -- Some packages may not be found!
BUILDSTDERR: Couldn't find index page for 'setuptools_scm' (maybe misspelled?)
Add:
BuildRequires: python3-pytest-runner
BuildRequires: python3-setuptools_scm
- Own this directory:
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/segyio
%dir %{_datadir}/segyio
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/segyio
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: segyio-static.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[Bug 1678006] Review Request: segyio - fast read/write of seismic files in SEG-Y
https://bugzilla.redhat.com/show_bug.cgi?id=1678006 --- Comment #2 from Jørgen Kvalsvik --- Ok, so I've addressed that. Here's the new spec and srpm: https://nofile.io/f/gdT878nfH0T/segyio.spec https://nofile.io/f/npS5rUy6NHV/segyio-1.8.3-1.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1678006] Review Request: segyio - fast read/write of seismic files in SEG-Y
https://bugzilla.redhat.com/show_bug.cgi?id=1678006
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
%package devel
Summary: SEG-Y read/write library for seismic processing (development)
Requires: %{name} = %{version}-%{release}
Provides: %{name}-static = %{version}-%{release}
- Requires should be %{name}%{?_isa} = %{version}-%{release}
- Why have you added Provides: %{name}-static? It doesn't make sense since the
static subpackage is specified afterwards.
- Should be before %description:
%{?python_enable_dependency_generator}
%{?python_provide:%python_provide python3-%{name}}
- Typo: %{?_smpl_mflags} → %{?_smp_mflags}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
